sonarqube 516f6e6bd2c8d82ffaac2aa8f73f063618b972c1

516f6e6bd2c8d82ffaac2aa8f73f063618b972c1

Files Diff

Added: 3
Removed: 1
Renamed: 0
Modified: 20

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Push Down Method	4
Push Down Method public read(lineBuilder DbFileSources.Line.Builder) : void from class org.sonar.ce.task.projectanalysis.source.SourceLineReadersFactory.LineReaders to public read(lineBuilder DbFileSources.Line.Builder, readErrorConsumer Consumer<LineReader.ReadError>) : void from class org.sonar.ce.task.projectanalysis.source.SourceLineReadersFactory.LineReadersImpl	From	To
Push Down Method public getLatestChangeWithRevision() : Changeset from class org.sonar.ce.task.projectanalysis.source.SourceLineReadersFactory.LineReaders to public getLatestChangeWithRevision() : Changeset from class org.sonar.ce.task.projectanalysis.source.SourceLineReadersFactory.LineReadersImpl	From	To
Push Down Method public close() : void from class org.sonar.ce.task.projectanalysis.source.SourceLineReadersFactory.LineReaders to public close() : void from class org.sonar.ce.task.projectanalysis.source.SourceLineReadersFactory.LineReadersImpl	From	To
Push Down Method package LineReaders(readers List<LineReader>, scmLineReader ScmLineReader, closeables List<CloseableIterator<?>>) from class org.sonar.ce.task.projectanalysis.source.SourceLineReadersFactory.LineReaders to package LineReadersImpl(readers List<LineReader>, scmLineReader ScmLineReader, closeables List<CloseableIterator<?>>) from class org.sonar.ce.task.projectanalysis.source.SourceLineReadersFactory.LineReadersImpl	From	To
Move And Rename Method	4
Move And Rename Method public should_not_delegate_latest_changeset() : void from class org.sonar.ce.task.projectanalysis.source.SourceLineReadersFactoryTest to public getLatestChangeWithRevision_returns_null_if_ScmLineReader_is_null() : void from class org.sonar.ce.task.projectanalysis.source.LineReadersImplTest	From	To
Move And Rename Method public should_delegate_latest_changeset() : void from class org.sonar.ce.task.projectanalysis.source.SourceLineReadersFactoryTest to public getLatestChangeWithRevision_delegates_to_ScmLineReader_if_non_null() : void from class org.sonar.ce.task.projectanalysis.source.LineReadersImplTest	From	To
Move And Rename Method public line_readers_should_call_all_readers() : void from class org.sonar.ce.task.projectanalysis.source.SourceLineReadersFactoryTest to public read_calls_all_readers() : void from class org.sonar.ce.task.projectanalysis.source.LineReadersImplTest	From	To
Move And Rename Method public line_readers_should_close_all_closeables() : void from class org.sonar.ce.task.projectanalysis.source.SourceLineReadersFactoryTest to public close_closes_all_closeables() : void from class org.sonar.ce.task.projectanalysis.source.LineReadersImplTest	From	To
Extract Subclass	1
Extract Subclass org.sonar.ce.task.projectanalysis.source.SourceLineReadersFactory.LineReadersImpl from class org.sonar.ce.task.projectanalysis.source.SourceLineReadersFactory.LineReaders	From	To
Inline Method	1
Inline Method private read(fileSourceBuilder DbFileSources.Data.Builder, lineHashesComputer SourceLinesHashRepositoryImpl.LineHashesComputer, lineReaders SourceLineReadersFactory.LineReaders, currentLine int, lineSource String, hasNextLine boolean) : void inlined to public compute(file Component, fileSourceDataWarnings FileSourceDataWarnings) : Data in class org.sonar.ce.task.projectanalysis.source.FileSourceDataComputer	From	To
Change Return Type	7
Change Return Type void to Optional<ReadError> in method public read(lineBuilder DbFileSources.Line.Builder) : Optional<ReadError> in class org.sonar.ce.task.projectanalysis.source.linereader.DuplicationLineReader	From	To
Change Return Type void to Optional<ReadError> in method public read(lineBuilder DbFileSources.Line.Builder) : Optional<ReadError> in class org.sonar.ce.task.projectanalysis.source.linereader.CoverageLineReader	From	To
Change Return Type void to Optional<ReadError> in method public read(lineBuilder DbFileSources.Line.Builder) : Optional<ReadError> in class org.sonar.ce.task.projectanalysis.source.linereader.SymbolsLineReader	From	To
Change Return Type void to Optional<ReadError> in method public read(lineBuilder DbFileSources.Line.Builder) : Optional<ReadError> in class org.sonar.ce.task.projectanalysis.source.linereader.IsNewLineReader	From	To
Change Return Type void to Optional<ReadError> in method public read(lineBuilder DbFileSources.Line.Builder) : Optional<ReadError> in class org.sonar.ce.task.projectanalysis.source.linereader.HighlightingLineReader	From	To
Change Return Type void to Optional<ReadError> in method public read(lineBuilder DbFileSources.Line.Builder) : Optional<ReadError> in class org.sonar.ce.task.projectanalysis.source.linereader.ScmLineReader	From	To
Change Return Type void to Optional<ReadError> in method public read(lineBuilder DbFileSources.Line.Builder) : Optional<ReadError> in class org.sonar.ce.task.projectanalysis.source.linereader.LineReader	From	To
Push Down Attribute	3
Push Down Attribute package closeables : List<CloseableIterator<?>> from class org.sonar.ce.task.projectanalysis.source.SourceLineReadersFactory.LineReaders to package closeables : List<CloseableIterator<?>> from class org.sonar.ce.task.projectanalysis.source.SourceLineReadersFactory.LineReadersImpl	From	To
Push Down Attribute package scmLineReader : ScmLineReader from class org.sonar.ce.task.projectanalysis.source.SourceLineReadersFactory.LineReaders to package scmLineReader : ScmLineReader from class org.sonar.ce.task.projectanalysis.source.SourceLineReadersFactory.LineReadersImpl	From	To
Push Down Attribute package readers : List<LineReader> from class org.sonar.ce.task.projectanalysis.source.SourceLineReadersFactory.LineReaders to package readers : List<LineReader> from class org.sonar.ce.task.projectanalysis.source.SourceLineReadersFactory.LineReadersImpl	From	To
Move Attribute	1
Move Attribute private scmLineReader : ScmLineReader from class org.sonar.ce.task.projectanalysis.source.FileSourceDataComputerTest to package scmLineReader : ScmLineReader from class org.sonar.ce.task.projectanalysis.source.SourceLineReadersFactory.LineReadersImpl	From	To
Change Variable Type	1
Change Variable Type lineReaders : SourceLineReadersFactory.LineReaders to lineReaders : LineReadersImpl in method public should_create_readers() : void in class org.sonar.ce.task.projectanalysis.source.SourceLineReadersFactoryTest	From	To

516f6e6bd2c8d82ffaac2aa8f73f063618b972c1

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: