5258f37933329dfee8b27c1c06cbe32c7da64d08
Files Diff
- Added: 1
- Removed: 0
- Renamed: 0
- Modified: 23
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 5 | ||
| Rename Method public fail_if_template_key_missing() : void renamed to public fail_if_template_uuid_and_name_are_missing() : void in class org.sonar.server.permission.ws.AddUserToTemplateActionTest | From | To | |
| Rename Method public fail_if_template_key_missing() : void renamed to public fail_if_template_missing() : void in class org.sonar.server.permission.ws.RemoveGroupFromTemplateActionTest | From | To | |
| Rename Method public fail_if_template_key_missing() : void renamed to public fail_if_template_missing() : void in class org.sonar.server.permission.ws.RemoveUserFromTemplateActionTest | From | To | |
| Rename Method public fail_if_template_key_missing() : void renamed to public fail_if_template_uuid_and_name_missing() : void in class org.sonar.server.permission.ws.AddGroupToTemplateActionTest | From | To | |
| Rename Method public update_settings_of_default_and_qualifier_default_for_project_qualifier() : void renamed to public update_settings_for_project_qualifier() : void in class org.sonar.server.permission.ws.SetDefaultTemplateActionTest | From | To | |
| Inline Method | 1 | ||
| Inline Method private deleteTemplate(uuid String) : void inlined to public handle(wsRequest Request, wsResponse Response) : void in class org.sonar.server.permission.ws.DeleteTemplateAction | From | To | |
| Rename Variable | 2 | ||
| Rename Variable qualifierTemplateUuid : String to effectiveTemplateUuid : String in method public apply(qualifier String) : TemplateUuidQualifier in class org.sonar.server.permission.ws.DefaultPermissionTemplateFinder.QualifierToTemplateUuidQualifier | From | To | |
| Rename Variable key : String to uuid : String in method public handle(wsRequest Request, wsResponse Response) : void in class org.sonar.server.permission.ws.UpdateTemplateAction | From | To | |
| Rename Attribute | 3 | ||
| Rename Attribute PARAM_TEMPLATE_PATTERN : String to PARAM_PATTERN : String in class org.sonar.server.permission.ws.Parameters | From | To | |
| Rename Attribute defautTemplatePermissionFinder : DefaultPermissionTemplateFinder to defaultTemplatePermissionFinder : DefaultPermissionTemplateFinder in class org.sonar.server.permission.ws.DeleteTemplateActionTest | From | To | |
| Rename Attribute PARAM_TEMPLATE_DESCRIPTION : String to PARAM_DESCRIPTION : String in class org.sonar.server.permission.ws.Parameters | From | To | |
| Extract And Move Method | 7 | ||
| Extract And Move Method package createTemplateParameters(action NewAction) : void extracted from public define(context WebService.NewController) : void in class org.sonar.server.permission.ws.SetDefaultTemplateAction & moved to class org.sonar.server.permission.ws.Parameters | From | To | |
| Extract And Move Method package createTemplateParameters(action NewAction) : void extracted from public define(context WebService.NewController) : void in class org.sonar.server.permission.ws.ApplyTemplateAction & moved to class org.sonar.server.permission.ws.Parameters | From | To | |
| Extract And Move Method package createTemplateParameters(action NewAction) : void extracted from public define(context WebService.NewController) : void in class org.sonar.server.permission.ws.AddGroupToTemplateAction & moved to class org.sonar.server.permission.ws.Parameters | From | To | |
| Extract And Move Method private effectiveTemplateUuid(settings Settings, qualifier String) : String extracted from public apply(qualifier String) : String in class org.sonar.server.permission.ws.DefaultPermissionTemplateFinder.QualifierToDefaultTemplate & moved to class org.sonar.server.permission.ws.DefaultPermissionTemplateFinder | From | To | |
| Extract And Move Method package createTemplateParameters(action NewAction) : void extracted from public define(context WebService.NewController) : void in class org.sonar.server.permission.ws.AddUserToTemplateAction & moved to class org.sonar.server.permission.ws.Parameters | From | To | |
| Extract And Move Method package createTemplateParameters(action NewAction) : void extracted from public define(context WebService.NewController) : void in class org.sonar.server.permission.ws.RemoveGroupFromTemplateAction & moved to class org.sonar.server.permission.ws.Parameters | From | To | |
| Extract And Move Method package createTemplateParameters(action NewAction) : void extracted from public define(context WebService.NewController) : void in class org.sonar.server.permission.ws.RemoveUserFromTemplateAction & moved to class org.sonar.server.permission.ws.Parameters | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter key : String to uuid : String in method private getAndBuildTemplateToUpdate(dbSession DbSession, uuid String, newName String, newDescription String, newProjectKeyPattern String) : PermissionTemplateDto in class org.sonar.server.permission.ws.UpdateTemplateAction | From | To |