5eb66cb787b5dad7f748a64e7e14c41c6a13cd6e
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 20
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 3 | ||
| Rename Method public fail_if_uri_doesnt_contains_callback() : void renamed to public fail_if_uri_does_not_contains_callback() : void in class org.sonar.server.authentication.InitFilterTest | From | To | |
| Rename Method public throw_UnauthorizedException_when_BadRequestException_is_generated() : void renamed to public throw_AuthenticationException_when_BadRequestException_is_generated() : void in class org.sonar.server.authentication.SsoAuthenticatorTest | From | To | |
| Rename Method public handleUnauthorizedError(e UnauthorizedException, response HttpServletResponse) : void renamed to package handleAuthenticationError(e AuthenticationException, response HttpServletResponse) : void in class org.sonar.server.authentication.AuthenticationError | From | To | |
| Change Parameter Type | 2 | ||
| Change Parameter Type e : UnauthorizedException to e : AuthenticationException in method package handleAuthenticationError(e AuthenticationException, response HttpServletResponse) : void in class org.sonar.server.authentication.AuthenticationError | From | To | |
| Change Parameter Type identityProvider : BaseIdentityProvider to identityProvider : IdentityProvider in method public external(identityProvider IdentityProvider) : Source in class org.sonar.server.authentication.event.AuthenticationEvent.Source | From | To | |
| Inline Method | 2 | ||
| Inline Method private assertCallbackCalled(oAuth2IdentityProvider FakeOAuth2IdentityProvider, expectLoginLog boolean) : void inlined to public do_filter_with_context() : void in class org.sonar.server.authentication.OAuth2CallbackFilterTest | From | To | |
| Inline Method private assertCallbackCalled(oAuth2IdentityProvider FakeOAuth2IdentityProvider, expectLoginLog boolean) : void inlined to public do_filter_on_auth2_identity_provider() : void in class org.sonar.server.authentication.OAuth2CallbackFilterTest | From | To | |
| Rename Variable | 2 | ||
| Rename Variable oauthProvider : OAuth2IdentityProvider to httpResponse : HttpServletResponse in method public doFilter(request ServletRequest, response ServletResponse, chain FilterChain) : void in class org.sonar.server.authentication.OAuth2CallbackFilter | From | To | |
| Rename Variable baseIdentityProvider : BaseIdentityProvider to httpResponse : HttpServletResponse in method public doFilter(request ServletRequest, response ServletResponse, chain FilterChain) : void in class org.sonar.server.authentication.InitFilter | From | To | |
| Change Return Type | 2 | ||
| Change Return Type AuthenticationExceptionMatcher to Builder in method public withoutLogin() : Builder in class org.sonar.server.authentication.event.AuthenticationExceptionMatcher.Builder | From | To | |
| Change Return Type AuthenticationExceptionMatcher to Builder in method public withLogin(login String) : Builder in class org.sonar.server.authentication.event.AuthenticationExceptionMatcher.Builder | From | To | |
| Change Variable Type | 2 | ||
| Change Variable Type baseIdentityProvider : BaseIdentityProvider to httpResponse : HttpServletResponse in method public doFilter(request ServletRequest, response ServletResponse, chain FilterChain) : void in class org.sonar.server.authentication.InitFilter | From | To | |
| Change Variable Type oauthProvider : OAuth2IdentityProvider to httpResponse : HttpServletResponse in method public doFilter(request ServletRequest, response ServletResponse, chain FilterChain) : void in class org.sonar.server.authentication.OAuth2CallbackFilter | From | To | |
| Extract Method | 2 | ||
| Extract Method private handleProvider(request HttpServletRequest, response HttpServletResponse, provider IdentityProvider) : void extracted from public doFilter(request ServletRequest, response ServletResponse, chain FilterChain) : void in class org.sonar.server.authentication.InitFilter | From | To | |
| Extract Method private handleProvider(request HttpServletRequest, response HttpServletResponse, provider IdentityProvider) : void extracted from public doFilter(request ServletRequest, response ServletResponse, chain FilterChain) : void in class org.sonar.server.authentication.OAuth2CallbackFilter | From | To |