6189f1973d24799939b1d689a3242820e2494da6
Files Diff
- Added: 0
- Removed: 1
- Renamed: 0
- Modified: 27
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 3 | ||
| Rename Method private applyPermissionTemplate(session DbSession, templateUuid String, project ComponentDto, currentUserId Long) : void renamed to public apply(session DbSession, template PermissionTemplateDto, project ComponentDto, currentUserId Long) : void in class org.sonar.db.permission.PermissionRepository | From | To | |
| Rename Method public fail_when_insufficient_privileges() : void renamed to public fail_when_not_admin_of_organization() : void in class org.sonar.server.permission.ws.template.ApplyTemplateActionTest | From | To | |
| Rename Method private getApplicablePermissionTemplateKey(session DbSession, componentKey String, qualifier String) : String renamed to private getApplicablePermissionTemplate(dbSession DbSession, component ComponentDto) : PermissionTemplateDto in class org.sonar.db.permission.PermissionRepository | From | To | |
| Pull Up Method | 3 | ||
| Pull Up Method private loginAsOrganizationAdmin(org OrganizationDto) : void from class org.sonar.server.permission.ws.RemoveGroupActionTest to protected loginAsAdmin(org OrganizationDto) : void from class org.sonar.server.permission.ws.BasePermissionWsTest | From | To | |
| Pull Up Method private loginAsOrganizationAdmin(org OrganizationDto) : void from class org.sonar.server.permission.ws.AddUserActionTest to protected loginAsAdmin(org OrganizationDto) : void from class org.sonar.server.permission.ws.BasePermissionWsTest | From | To | |
| Pull Up Method private loginAsAdminOnDefaultOrganization() : void from class org.sonar.server.permission.ws.AddGroupActionTest to protected loginAsAdminOnDefaultOrganization() : void from class org.sonar.server.permission.ws.BasePermissionWsTest | From | To | |
| Change Parameter Type | 1 | ||
| Change Parameter Type templateUuid : String to template : PermissionTemplateDto in method public apply(session DbSession, template PermissionTemplateDto, project ComponentDto, currentUserId Long) : void in class org.sonar.db.permission.PermissionRepository | From | To | |
| Rename Variable | 1 | ||
| Rename Variable rootComponents : List<ComponentDto> to projects : List<ComponentDto> in method private doHandle(request BulkApplyTemplateWsRequest) : void in class org.sonar.server.permission.ws.template.BulkApplyTemplateAction | From | To | |
| Change Return Type | 2 | ||
| Change Return Type String to PermissionTemplateDto in method private getApplicablePermissionTemplate(dbSession DbSession, component ComponentDto) : PermissionTemplateDto in class org.sonar.db.permission.PermissionRepository | From | To | |
| Change Return Type PermissionTemplate to PermissionTemplateDto in method private selectTemplate() : PermissionTemplateDto in class org.sonar.server.startup.RegisterPermissionTemplatesTest | From | To | |
| Merge Parameter | 1 | ||
| Merge Parameter [componentKey : String, qualifier : String] to component : ComponentDto in method private getApplicablePermissionTemplate(dbSession DbSession, component ComponentDto) : PermissionTemplateDto in class org.sonar.db.permission.PermissionRepository | From | To | |
| Change Variable Type | 2 | ||
| Change Variable Type defaultTemplate : PermissionTemplate to defaultTemplate : PermissionTemplateDto in method public ignore_administrators_permissions_if_group_does_not_exist() : void in class org.sonar.server.startup.RegisterPermissionTemplatesTest | From | To | |
| Change Variable Type defaultTemplate : PermissionTemplate to defaultTemplate : PermissionTemplateDto in method public insert_default_permission_template_if_fresh_install() : void in class org.sonar.server.startup.RegisterPermissionTemplatesTest | From | To | |
| Rename Parameter | 2 | ||
| Rename Parameter templateUuid : String to template : PermissionTemplateDto in method public apply(session DbSession, template PermissionTemplateDto, project ComponentDto, currentUserId Long) : void in class org.sonar.db.permission.PermissionRepository | From | To | |
| Rename Parameter session : DbSession to dbSession : DbSession in method private getApplicablePermissionTemplate(dbSession DbSession, component ComponentDto) : PermissionTemplateDto in class org.sonar.db.permission.PermissionRepository | From | To |