6bc55b17ebd87802cb9b55d5b6625e1a935f3909
Files Diff
- Added: 31
- Removed: 8
- Renamed: 0
- Modified: 47
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Change Parameter Type | 3 | ||
| Change Parameter Type commandKey : String to processId : ProcessId in method private HttpProcessClient(tempDir File, processId ProcessId) in class org.sonar.process.monitor.MonitorTest.HttpProcessClient | From | To | |
| Change Parameter Type key : String to id : ProcessId in method public JavaCommand(id ProcessId) in class org.sonar.process.monitor.JavaCommand | From | To | |
| Change Parameter Type commandKey : String to processId : ProcessId in method private HttpProcessClient(tempDir File, processId ProcessId, httpPort int) in class org.sonar.process.monitor.MonitorTest.HttpProcessClient | From | To | |
| Move Method | 3 | ||
| Move Method public getKey() : String from class org.sonar.process.monitor.JavaCommand to public getKey() : String from class org.sonar.process.ProcessId | From | To | |
| Move Method public attributes() : LinkedHashMap<String,Object> from class org.sonar.server.computation.monitoring.ComputeEngineQueueMonitor to public attributes() : LinkedHashMap<String,Object> from class org.sonar.server.platform.monitoring.CeDatabaseMonitor | From | To | |
| Move Method public name() : String from class org.sonar.server.computation.monitoring.ComputeEngineQueueMonitor to public name() : String from class org.sonar.server.platform.monitoring.CeDatabaseMonitor | From | To | |
| Move Attribute | 1 | ||
| Move Attribute private key : String from class org.sonar.process.monitor.JavaCommand to private key : String from class org.sonar.process.ProcessId | From | To | |
| Extract Class | 2 | ||
| Extract Class org.sonar.server.platform.monitoring.CeDatabaseMonitor from class org.sonar.server.computation.monitoring.ComputeEngineQueueMonitor | From | To | |
| Extract Class org.sonar.process.ProcessId from class org.sonar.process.monitor.JavaCommand | From | To | |
| Extract Attribute | 1 | ||
| Extract Attribute package commands : ProcessCommands in class org.sonar.process.ProcessEntryPointTest | From | To | |
| Rename Class | 5 | ||
| Rename Class org.sonar.server.platform.monitoring.JvmPropertiesMonitorTest renamed to org.sonar.server.platform.monitoring.JvmPropsMonitorTest | From | To | |
| Rename Class org.sonar.server.platform.monitoring.JvmPropertiesMonitor renamed to org.sonar.server.platform.monitoring.JvmPropsMonitor | From | To | |
| Rename Class org.sonar.server.computation.monitoring.ComputeEngineQueueMonitor renamed to org.sonar.server.computation.monitoring.CeTasksMBeanImpl | From | To | |
| Rename Class org.sonar.search.SearchSettings renamed to org.sonar.search.EsSettings | From | To | |
| Rename Class org.sonar.search.SearchSettingsTest renamed to org.sonar.search.EsSettingsTest | From | To | |
| Move And Rename Class | 1 | ||
| Move And Rename Class org.sonar.server.computation.monitoring.ComputeEngineQueueMonitorMBean moved and renamed to org.sonar.process.jmx.CeTasksMBean | From | To | |
| Move Class | 2 | ||
| Move Class org.sonar.server.computation.monitoring.ComputeEngineQueueMonitorTest.DumbCeConfiguration moved to org.sonar.server.computation.monitoring.CeTasksMBeanImplTest.DumbCeConfiguration | From | To | |
| Move Class org.sonar.server.computation.monitoring.ComputeEngineQueueMonitorTest.DumbCEQueueStatus moved to org.sonar.server.computation.monitoring.CeTasksMBeanImplTest.DumbCEQueueStatus | From | To | |
| Change Variable Type | 2 | ||
| Change Variable Type searchSettings : SearchSettings to esSettings : EsSettings in method public test_default_settings() : void in class org.sonar.search.EsSettingsTest | From | To | |
| Change Variable Type searchSettings : SearchSettings to esSettings : EsSettings in method public test_default_hosts() : void in class org.sonar.search.EsSettingsTest | From | To | |
| Extract Variable | 1 | ||
| Extract Variable node : DiscoveryNode in method private nodeAttributes() : LinkedHashMap<String,LinkedHashMap<String,Object>> from class org.sonar.server.platform.monitoring.EsMonitor | From | To | |
| Extract Method | 3 | ||
| Extract Method public getNodeName() : String extracted from private configureCluster(builder ImmutableSettings.Builder) : void in class org.sonar.search.EsSettings | From | To | |
| Extract Method public getHttpPort() : int extracted from private configureNetwork(builder ImmutableSettings.Builder) : void in class org.sonar.search.EsSettings | From | To | |
| Extract Method public getClusterName() : String extracted from private configureCluster(builder ImmutableSettings.Builder) : void in class org.sonar.search.EsSettings | From | To | |
| Rename Method | 1 | ||
| Rename Method public start_elasticsearch_and_tomcat_by_default() : void renamed to public start_all_processes_by_default() : void in class org.sonar.application.AppTest | From | To | |
| Rename Variable | 3 | ||
| Rename Variable searchSettings : SearchSettings to esSettings : EsSettings in method public test_default_settings() : void in class org.sonar.search.EsSettingsTest | From | To | |
| Rename Variable searchSettings : SearchSettings to esSettings : EsSettings in method public test_default_hosts() : void in class org.sonar.search.EsSettingsTest | From | To | |
| Rename Variable executionTime : long to executionTimeInMs : long in method private updateQueueStatus(status CeActivityDto.Status, activityDto CeActivityDto) : void in class org.sonar.server.computation.queue.InternalCeQueueImpl | From | To | |
| Change Return Type | 2 | ||
| Change Return Type void to T in method private call(command VoidMethod, processNumber int) : T in class org.sonar.server.app.ProcessCommandWrapperImpl | From | To | |
| Change Return Type ObjectName to String in method package objectName() : String in class org.sonar.server.platform.monitoring.BaseMonitorMBean | From | To | |
| Replace Variable With Attribute | 4 | ||
| Replace Variable With Attribute monitor : EsMonitor to underTest : EsMonitor in method public node_attributes() : void in class org.sonar.server.platform.monitoring.EsMonitorTest | From | To | |
| Replace Variable With Attribute monitor : EsMonitor to underTest : EsMonitor in method public cluster_attributes() : void in class org.sonar.server.platform.monitoring.EsMonitorTest | From | To | |
| Replace Variable With Attribute monitor : EsMonitor to underTest : EsMonitor in method public name() : void in class org.sonar.server.platform.monitoring.EsMonitorTest | From | To | |
| Replace Variable With Attribute monitor : EsMonitor to underTest : EsMonitor in method public index_attributes() : void in class org.sonar.server.platform.monitoring.EsMonitorTest | From | To | |
| Rename Attribute | 2 | ||
| Rename Attribute key : String to id : ProcessId in class org.sonar.process.monitor.JavaCommand | From | To | |
| Rename Attribute commandKey : String to processId : ProcessId in class org.sonar.process.monitor.MonitorTest.HttpProcessClient | From | To | |
| Change Attribute Type | 3 | ||
| Change Attribute Type settings : SearchSettings to settings : EsSettings in class org.sonar.search.SearchServer | From | To | |
| Change Attribute Type key : String to id : ProcessId in class org.sonar.process.monitor.JavaCommand | From | To | |
| Change Attribute Type commandKey : String to processId : ProcessId in class org.sonar.process.monitor.MonitorTest.HttpProcessClient | From | To | |
| Rename Parameter | 6 | ||
| Rename Parameter commandKey : String to processId : ProcessId in method private HttpProcessClient(tempDir File, processId ProcessId, httpPort int) in class org.sonar.process.monitor.MonitorTest.HttpProcessClient | From | To | |
| Rename Parameter commandKey : String to processId : ProcessId in method private HttpProcessClient(tempDir File, processId ProcessId) in class org.sonar.process.monitor.MonitorTest.HttpProcessClient | From | To | |
| Rename Parameter time : long to ms : long in method private addProcessingTime(ms long) : void in class org.sonar.server.computation.monitoring.CEQueueStatusImpl | From | To | |
| Rename Parameter key : String to id : ProcessId in method public JavaCommand(id ProcessId) in class org.sonar.process.monitor.JavaCommand | From | To | |
| Rename Parameter processingTime : long to processingTimeInMs : long in method public addError(processingTimeInMs long) : long in class org.sonar.server.computation.monitoring.CEQueueStatusImpl | From | To | |
| Rename Parameter processingTime : long to processingTimeInMs : long in method public addSuccess(processingTimeInMs long) : long in class org.sonar.server.computation.monitoring.CEQueueStatusImpl | From | To |