sonarqube 6f0ec812774c8839234581d6800728b137b9149a

6f0ec812774c8839234581d6800728b137b9149a

Files Diff

Added: 4
Removed: 0
Renamed: 0
Modified: 11

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Rename Method	3
Rename Method public request_fails_with_organization_feature_is_disabled() : void renamed to public request_fails_with_IllegalStateException_if_organization_feature_is_disabled() : void in class org.sonar.server.organization.ws.UpdateActionTest	From	To
Rename Method public request_fails_with_BadRequestException_if_organization_feature_is_disabled() : void renamed to public request_fails_with_IllegalStateException_if_organization_feature_is_disabled() : void in class org.sonar.server.organization.ws.CreateActionTest	From	To
Rename Method public request_fails_with_organization_feature_is_disabled() : void renamed to public request_fails_with_IllegalStateException_if_organization_feature_is_disabled() : void in class org.sonar.server.organization.ws.DeleteActionTest	From	To
Change Parameter Type	2
Change Parameter Type support : OrganizationsWsSupport to organizationFlags : OrganizationFlags in method public EnableSupportAction(userSession UserSession, dbClient DbClient, defaultOrganizationProvider DefaultOrganizationProvider, organizationFlags OrganizationFlags) in class org.sonar.server.organization.ws.EnableSupportAction	From	To
Change Parameter Type support : OrganizationsWsSupport to organizationFlags : OrganizationFlags in method public DeleteAction(userSession UserSession, dbClient DbClient, defaultOrganizationProvider DefaultOrganizationProvider, componentCleanerService ComponentCleanerService, organizationFlags OrganizationFlags) in class org.sonar.server.organization.ws.DeleteAction	From	To
Inline Method	49
Inline Method private enableOrganizationsAndLogInAsRoot() : void inlined to public request_succeeds_if_key_is_2_chars_long() : void in class org.sonar.server.organization.ws.CreateActionTest	From	To
Inline Method private enableOrganizationsAndLogInAsRoot() : void inlined to public request_fails_if_name_param_is_missing() : void in class org.sonar.server.organization.ws.CreateActionTest	From	To
Inline Method private enableOrganizationsAndLogInAsRoot() : void inlined to public request_with_only_key_param_succeeds_and_updates_only_updateAt_field() : void in class org.sonar.server.organization.ws.UpdateActionTest	From	To
Inline Method private enableOrganizationsAndLogInAsRoot() : void inlined to public request_succeeds_if_name_is_64_char_long() : void in class org.sonar.server.organization.ws.CreateActionTest	From	To
Inline Method private enableOrganizationsAndLogInAsRoot() : void inlined to public requests_fails_if_key_contains_non_ascii_chars_but_dash() : void in class org.sonar.server.organization.ws.CreateActionTest	From	To
Inline Method private enableOrganizationsAndLogInAsRoot() : void inlined to public request_fails_if_key_is_33_chars_long() : void in class org.sonar.server.organization.ws.CreateActionTest	From	To
Inline Method private enableOrganizationsAndLogInAsRoot() : void inlined to public request_succeeds_if_name_is_64_char_long() : void in class org.sonar.server.organization.ws.UpdateActionTest	From	To
Inline Method private enableOrganizationsAndLogInAsRoot() : void inlined to public verify_response_example() : void in class org.sonar.server.organization.ws.CreateActionTest	From	To
Inline Method private enableOrganizationsAndLogInAsRoot() : void inlined to public request_succeeds_to_generate_key_from_name_more_then_32_chars_long() : void in class org.sonar.server.organization.ws.CreateActionTest	From	To
Inline Method private enableOrganizationsAndLogInAsRoot() : void inlined to public request_fails_with_IAE_if_key_is_the_one_of_default_organization() : void in class org.sonar.server.organization.ws.DeleteActionTest	From	To
Inline Method private enableOrganizationsAndLogInAsRoot() : void inlined to public request_fails_with_NotFoundException_if_organization_with_specified_key_does_not_exist() : void in class org.sonar.server.organization.ws.DeleteActionTest	From	To
Inline Method private enableOrganizationsAndLogInAsRoot() : void inlined to public request_fails_if_key_is_missing() : void in class org.sonar.server.organization.ws.UpdateActionTest	From	To
Inline Method private enableOrganizationsAndLogInAsRoot() : void inlined to public request_succeeds_if_description_url_and_avatar_are_not_specified() : void in class org.sonar.server.organization.ws.CreateActionTest	From	To
Inline Method private enableOrganizationsAndLogInAsRoot() : void inlined to public request_succeeds_if_description_url_and_avatar_are_not_specified() : void in class org.sonar.server.organization.ws.UpdateActionTest	From	To
Inline Method private enableOrganizationsAndLogInAsRoot() : void inlined to public request_succeeds_if_name_is_two_chars_long() : void in class org.sonar.server.organization.ws.CreateActionTest	From	To
Inline Method private enableOrganizationsAndLogInAsRoot() : void inlined to public request_succeeds_if_name_is_two_chars_long() : void in class org.sonar.server.organization.ws.UpdateActionTest	From	To
Inline Method private enableOrganizationsAndLogInAsRoot() : void inlined to public request_generates_key_ignoring_multiple_following_spaces() : void in class org.sonar.server.organization.ws.CreateActionTest	From	To
Inline Method private enableOrganizationsAndLogInAsRoot() : void inlined to public request_succeeds_if_url_is_256_chars_long() : void in class org.sonar.server.organization.ws.CreateActionTest	From	To
Inline Method private enableOrganizationsAndLogInAsRoot() : void inlined to public request_succeeds_if_url_is_256_chars_long() : void in class org.sonar.server.organization.ws.UpdateActionTest	From	To
Inline Method private enableOrganizationsAndLogInAsRoot() : void inlined to public request_also_deletes_permissions_templates_and_permissions_and_groups_of_specified_organization() : void in class org.sonar.server.organization.ws.DeleteActionTest	From	To
Inline Method private enableOrganizationsAndLogInAsRoot() : void inlined to public request_fails_if_key_computed_from_name_already_exists_in_DB() : void in class org.sonar.server.organization.ws.CreateActionTest	From	To
Inline Method private enableOrganizationsAndLogInAsRoot() : void inlined to public request_fails_if_key_is_specified_and_already_exists_in_DB() : void in class org.sonar.server.organization.ws.CreateActionTest	From	To
Inline Method private enableOrganizationsAndLogInAsRoot() : void inlined to public request_fails_if_name_is_65_chars_long() : void in class org.sonar.server.organization.ws.CreateActionTest	From	To
Inline Method private enableOrganizationsAndLogInAsRoot() : void inlined to public request_fails_if_name_is_65_chars_long() : void in class org.sonar.server.organization.ws.UpdateActionTest	From	To
Inline Method private enableOrganizationsAndLogInAsRoot() : void inlined to public request_fails_if_description_is_257_chars_long() : void in class org.sonar.server.organization.ws.CreateActionTest	From	To
Inline Method private enableOrganizationsAndLogInAsRoot() : void inlined to public request_succeeds_if_description_url_and_avatar_are_specified() : void in class org.sonar.server.organization.ws.CreateActionTest	From	To
Inline Method private enableOrganizationsAndLogInAsRoot() : void inlined to public request_fails_if_name_is_one_char_long() : void in class org.sonar.server.organization.ws.CreateActionTest	From	To
Inline Method private enableOrganizationsAndLogInAsRoot() : void inlined to public request_fails_if_description_is_257_chars_long() : void in class org.sonar.server.organization.ws.UpdateActionTest	From	To
Inline Method private enableOrganizationsAndLogInAsRoot() : void inlined to public request_succeeds_if_description_url_and_avatar_are_specified() : void in class org.sonar.server.organization.ws.UpdateActionTest	From	To
Inline Method private enableOrganizationsAndLogInAsRoot() : void inlined to public request_fails_if_name_is_one_char_long() : void in class org.sonar.server.organization.ws.UpdateActionTest	From	To
Inline Method private enableOrganizationsAndLogInAsRoot() : void inlined to public request_succeeds_if_user_is_root_and_logged_in_users_can_create_organizations() : void in class org.sonar.server.organization.ws.CreateActionTest	From	To
Inline Method private enableOrganizationsAndLogInAsRoot() : void inlined to public request_also_deletes_components_of_specified_organization() : void in class org.sonar.server.organization.ws.DeleteActionTest	From	To
Inline Method private enableOrganizationsAndLogInAsRoot() : void inlined to public request_fails_if_key_contains_space() : void in class org.sonar.server.organization.ws.CreateActionTest	From	To
Inline Method private enableOrganizationsAndLogInAsRoot() : void inlined to public request_fails_if_key_starts_with_a_dash() : void in class org.sonar.server.organization.ws.CreateActionTest	From	To
Inline Method private enableOrganizationsAndLogInAsRoot() : void inlined to public request_fails_if_url_is_257_chars_long() : void in class org.sonar.server.organization.ws.CreateActionTest	From	To
Inline Method private enableOrganizationsAndLogInAsRoot() : void inlined to public request_fails_if_key_ends_with_a_dash() : void in class org.sonar.server.organization.ws.CreateActionTest	From	To
Inline Method private enableOrganizationsAndLogInAsRoot() : void inlined to public request_fails_if_url_is_257_chars_long() : void in class org.sonar.server.organization.ws.UpdateActionTest	From	To
Inline Method private enableOrganizationsAndLogInAsRoot() : void inlined to public request_succeeds_if_user_is_root_and_logged_in_users_cannot_create_organizations() : void in class org.sonar.server.organization.ws.CreateActionTest	From	To
Inline Method private enableOrganizationsAndLogInAsRoot() : void inlined to public request_fails_with_IAE_if_key_param_is_missing() : void in class org.sonar.server.organization.ws.DeleteActionTest	From	To
Inline Method private enableOrganizationsAndLogInAsRoot() : void inlined to public requests_succeeds_if_key_is_32_chars_long() : void in class org.sonar.server.organization.ws.CreateActionTest	From	To
Inline Method private enableOrganizationsAndLogInAsRoot() : void inlined to public request_succeeds_if_avatar_is_256_chars_long() : void in class org.sonar.server.organization.ws.CreateActionTest	From	To
Inline Method private enableOrganizationsAndLogInAsRoot() : void inlined to public request_succeeds_if_avatar_is_256_chars_long() : void in class org.sonar.server.organization.ws.UpdateActionTest	From	To
Inline Method private enableOrganizationsAndLogInAsRoot() : void inlined to public request_removes_optional_parameters_when_associated_parameter_are_empty() : void in class org.sonar.server.organization.ws.UpdateActionTest	From	To
Inline Method private enableOrganizationsAndLogInAsRoot() : void inlined to public request_succeeds_if_user_is_root() : void in class org.sonar.server.organization.ws.UpdateActionTest	From	To
Inline Method private enableOrganizationsAndLogInAsRoot() : void inlined to public request_fails_if_avatar_is_257_chars_long() : void in class org.sonar.server.organization.ws.CreateActionTest	From	To
Inline Method private enableOrganizationsAndLogInAsRoot() : void inlined to public request_fails_if_avatar_is_257_chars_long() : void in class org.sonar.server.organization.ws.UpdateActionTest	From	To
Inline Method private enableOrganizationsAndLogInAsRoot() : void inlined to public request_fails_if_key_one_char_long() : void in class org.sonar.server.organization.ws.CreateActionTest	From	To
Inline Method private enableOrganizationsAndLogInAsRoot() : void inlined to public request_succeeds_if_description_is_256_chars_long() : void in class org.sonar.server.organization.ws.CreateActionTest	From	To
Inline Method private enableOrganizationsAndLogInAsRoot() : void inlined to public request_succeeds_if_description_is_256_chars_long() : void in class org.sonar.server.organization.ws.UpdateActionTest	From	To
Move Attribute	1
Move Attribute private dbClient : DbClient from class org.sonar.server.organization.ws.OrganizationsWsSupport to private dbClient : DbClient from class org.sonar.server.organization.OrganizationFlagsImpl	From	To
Rename Attribute	2
Rename Attribute support : OrganizationsWsSupport to organizationFlags : OrganizationFlags in class org.sonar.server.organization.ws.DeleteAction	From	To
Rename Attribute support : OrganizationsWsSupport to organizationFlags : OrganizationFlags in class org.sonar.server.organization.ws.EnableSupportAction	From	To
Extract Method	1
Extract Method private verifyRoot(user UserDto, root boolean) : void extracted from public enabling_support_saves_internal_property_and_flags_caller_as_root() : void in class org.sonar.server.organization.ws.EnableSupportActionTest	From	To
Change Attribute Type	2
Change Attribute Type support : OrganizationsWsSupport to organizationFlags : OrganizationFlags in class org.sonar.server.organization.ws.DeleteAction	From	To
Change Attribute Type support : OrganizationsWsSupport to organizationFlags : OrganizationFlags in class org.sonar.server.organization.ws.EnableSupportAction	From	To
Rename Parameter	2
Rename Parameter support : OrganizationsWsSupport to organizationFlags : OrganizationFlags in method public DeleteAction(userSession UserSession, dbClient DbClient, defaultOrganizationProvider DefaultOrganizationProvider, componentCleanerService ComponentCleanerService, organizationFlags OrganizationFlags) in class org.sonar.server.organization.ws.DeleteAction	From	To
Rename Parameter support : OrganizationsWsSupport to organizationFlags : OrganizationFlags in method public EnableSupportAction(userSession UserSession, dbClient DbClient, defaultOrganizationProvider DefaultOrganizationProvider, organizationFlags OrganizationFlags) in class org.sonar.server.organization.ws.EnableSupportAction	From	To

6f0ec812774c8839234581d6800728b137b9149a

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: