sonarqube 6f107dcbe90b0fea564e1ecaa96643bfc539329a

6f107dcbe90b0fea564e1ecaa96643bfc539329a

Files Diff

Added: 12
Removed: 4
Renamed: 0
Modified: 127

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Move And Inline Method	1
Move And Inline Method public setKey(key String) : QProfile moved from class org.sonar.scanner.rule.QProfile to class org.sonar.scanner.report.MetadataPublisherTest & inlined to public prepare() : void	From	To
Change Parameter Type	13
Change Parameter Type projectReactor : ProjectReactor to moduleHierarchy : InputModuleHierarchy in method public ProjectLock(moduleHierarchy InputModuleHierarchy) in class org.sonar.scanner.scan.ProjectLock	From	To
Change Parameter Type projectReactor : ProjectReactor to moduleHierarchy : InputModuleHierarchy in method public provide(moduleHierarchy InputModuleHierarchy) : TempFolder in class org.sonar.scanner.analysis.AnalysisTempFolderProvider	From	To
Change Parameter Type projectReactor : ImmutableProjectReactor to moduleHierarchy : InputModuleHierarchy in method public ScmConfiguration(moduleHierarchy InputModuleHierarchy, analysisMode AnalysisMode, settings Configuration) in class org.sonar.scanner.scm.ScmConfiguration	From	To
Change Parameter Type projectReactor : ProjectReactor to moduleHierarchy : InputModuleHierarchy in method public WorkDirectoryCleaner(moduleHierarchy InputModuleHierarchy) in class org.sonar.scanner.scan.WorkDirectoryCleaner	From	To
Change Parameter Type moduleHierarchy : DefaultInputModuleHierarchy to moduleHierarchy : InputModuleHierarchy in method public ModuleIndexer(componentTree DefaultComponentTree, componentStore InputComponentStore, moduleHierarchy InputModuleHierarchy) in class org.sonar.scanner.scan.ModuleIndexer	From	To
Change Parameter Type moduleDefinition : ProjectDefinition to module : DefaultInputModule in method public provide(globalSettings GlobalConfiguration, module DefaultInputModule, projectRepos ProjectRepositories, analysisMode AnalysisMode, contextReportPublisher AnalysisContextReportPublisher) : ModuleSettings in class org.sonar.scanner.scan.ModuleSettingsProvider	From	To
Change Parameter Type moduleDefinition : ProjectDefinition to module : DefaultInputModule in method private collectModuleSpecificProps(module DefaultInputModule) : Map<String,String> in class org.sonar.scanner.report.AnalysisContextReportPublisher	From	To
Change Parameter Type projectReactor : ImmutableProjectReactor to moduleHierarchy : InputModuleHierarchy in method public ReportPublisher(settings Configuration, wsClient ScannerWsClient, server Server, contextPublisher AnalysisContextReportPublisher, moduleHierarchy InputModuleHierarchy, analysisMode DefaultAnalysisMode, temp TempFolder, publishers ReportPublisherStep[]) in class org.sonar.scanner.report.ReportPublisher	From	To
Change Parameter Type moduleDefinition : ProjectDefinition to module : DefaultInputModule in method public dumpModuleSettings(module DefaultInputModule) : void in class org.sonar.scanner.report.AnalysisContextReportPublisher	From	To
Change Parameter Type settings : Configuration to settings : CpdSettings in method public SonarCpdBlockIndex(publisher ReportPublisher, settings CpdSettings) in class org.sonar.scanner.cpd.index.SonarCpdBlockIndex	From	To
Change Parameter Type reactor : ImmutableProjectReactor to componentStore : InputComponentStore in method public ServerIssueRepository(caches Storages, previousIssuesLoader ServerIssuesLoader, componentStore InputComponentStore) in class org.sonar.scanner.issue.tracking.ServerIssueRepository	From	To
Change Parameter Type settings : Configuration to settings : CpdSettings in method public CpdExecutor(settings CpdSettings, index SonarCpdBlockIndex, publisher ReportPublisher, inputComponentCache InputComponentStore) in class org.sonar.scanner.cpd.CpdExecutor	From	To
Change Parameter Type projectReactor : ImmutableProjectReactor to moduleHierarchy : InputModuleHierarchy in method public ScmConfiguration(moduleHierarchy InputModuleHierarchy, analysisMode AnalysisMode, settings Configuration, providers ScmProvider...) in class org.sonar.scanner.scm.ScmConfiguration	From	To
Move Method	4
Move Method public isCrossProjectDuplicationEnabled(settings Configuration) : boolean from class org.sonar.scanner.cpd.index.SonarCpdBlockIndex to public isCrossProjectDuplicationEnabled() : boolean from class org.sonar.scanner.cpd.CpdSettings	From	To
Move Method public minimumTokensByLanguage() : void from class org.sonar.scanner.cpd.CpdExecutorTest to public minimumTokensByLanguage() : void from class org.sonar.scanner.cpd.CpdSettingsTest	From	To
Move Method package getMinimumTokens(languageKey String) : int from class org.sonar.scanner.cpd.CpdExecutor to package getMinimumTokens(languageKey String) : int from class org.sonar.scanner.cpd.CpdSettings	From	To
Move Method public defaultMinimumTokens() : void from class org.sonar.scanner.cpd.CpdExecutorTest to public defaultMinimumTokens() : void from class org.sonar.scanner.cpd.CpdSettingsTest	From	To
Extract Class	2
Extract Class org.sonar.scanner.cpd.CpdSettingsTest from class org.sonar.scanner.cpd.CpdExecutorTest	From	To
Extract Class org.sonar.scanner.rule.QProfile.Builder from class org.sonar.scanner.rule.QProfile	From	To
Move Class	7
Move Class org.sonar.api.batch.fs.internal.IntArrayList moved to org.sonar.api.batch.fs.internal.charhandler.IntArrayList	From	To
Move Class org.sonar.api.batch.fs.internal.FileMetadata.CharHandler moved to org.sonar.api.batch.fs.internal.charhandler.CharHandler	From	To
Move Class org.sonar.api.batch.fs.internal.FileMetadata.FileHashComputer moved to org.sonar.api.batch.fs.internal.charhandler.FileHashComputer	From	To
Move Class org.sonar.api.batch.fs.internal.FileMetadata.LineHashComputer moved to org.sonar.api.batch.fs.internal.charhandler.LineHashComputer	From	To
Move Class org.sonar.api.batch.fs.internal.IntArrayListTest moved to org.sonar.api.batch.fs.internal.charhandler.IntArrayListTest	From	To
Move Class org.sonar.api.batch.fs.internal.FileMetadata.LineCounter moved to org.sonar.api.batch.fs.internal.charhandler.LineCounter	From	To
Move Class org.sonar.api.batch.fs.internal.FileMetadata.LineOffsetCounter moved to org.sonar.api.batch.fs.internal.charhandler.LineOffsetCounter	From	To
Extract Variable	2
Extract Variable def : ProjectDefinition in method public before() : void from class org.sonar.scanner.scan.report.JSONReportTest	From	To
Extract Variable capacity : int in method private ensureCapacityInternal(minCapacity int) : void from class org.sonar.api.batch.fs.internal.charhandler.IntArrayList	From	To
Change Variable Type	6
Change Variable Type projectReactor : ProjectReactor to hierarchy : InputModuleHierarchy in method public setUp() : void in class org.sonar.scanner.scan.WorkDirectoryCleanerTest	From	To
Change Variable Type projectReactor : ProjectReactor to hierarchy : InputModuleHierarchy in method private setUpTest(file File) : ProjectLock in class org.sonar.scanner.scan.ProjectLockTest	From	To
Change Variable Type projectDefinition : ProjectDefinition to module : DefaultInputModule in method public setUp() : void in class org.sonar.scanner.analysis.AnalysisTempFolderProviderTest	From	To
Change Variable Type projectDefinition : ProjectDefinition to root : DefaultInputModule in method private setUpTest(file File) : ProjectLock in class org.sonar.scanner.scan.ProjectLockTest	From	To
Change Variable Type projectDefinition : ProjectDefinition to root : DefaultInputModule in method public setUp() : void in class org.sonar.scanner.scan.WorkDirectoryCleanerTest	From	To
Change Variable Type projectDefinition : ProjectDefinition to module : InputModule in method private store(issue ServerIssue) : void in class org.sonar.scanner.issue.tracking.ServerIssueRepository	From	To
Extract Method	31
Extract Method private detectLanguage(detection LanguageDetection, path String) : String extracted from public solve_conflict_using_filepattern() : void in class org.sonar.scanner.scan.filesystem.LanguageDetectionTest	From	To
Extract Method private detectLanguage(detection LanguageDetection, path String) : String extracted from public search_by_file_extension() : void in class org.sonar.scanner.scan.filesystem.LanguageDetectionTest	From	To
Extract Method private createReportIssue(issue Issue, batchId int, ruleName String, activeRuleSeverity String) : ScannerReport.Issue extracted from public initAndAddIssue(issue Issue) : boolean in class org.sonar.scanner.issue.ModuleIssues	From	To
Extract Method private detectLanguage(detection LanguageDetection, path String) : String extracted from public fail_if_conflicting_filepattern() : void in class org.sonar.scanner.scan.filesystem.LanguageDetectionTest	From	To
Extract Method private detectLanguage(detection LanguageDetection, path String) : String extracted from public fail_if_conflicting_language_suffix() : void in class org.sonar.scanner.scan.filesystem.LanguageDetectionTest	From	To
Extract Method private detectLanguage(detection LanguageDetection, path String) : String extracted from public should_not_fail_if_no_language() : void in class org.sonar.scanner.scan.filesystem.LanguageDetectionTest	From	To
Extract Method private detectLanguage(detection LanguageDetection, path String) : String extracted from public plugin_can_declare_a_file_extension_twice_for_case_sensitivity() : void in class org.sonar.scanner.scan.filesystem.LanguageDetectionTest	From	To
Extract Method private getDetails(detectedLanguage String, patterns PathPattern[]) : String extracted from private getDetails(detectedLanguage String) : String in class org.sonar.scanner.scan.filesystem.LanguageDetection	From	To
Extract Method private detectLanguage(detection LanguageDetection, path String) : String extracted from public language_with_no_extension() : void in class org.sonar.scanner.scan.filesystem.LanguageDetectionTest	From	To
Extract Method private createPublisher(def ProjectDefinition) : void extracted from public prepare() : void in class org.sonar.scanner.report.MetadataPublisherTest	From	To
Extract Method public newDefaultInputModule(projectDefinition ProjectDefinition) : DefaultInputModule extracted from public newDefaultInputModule(moduleKey String, baseDir File) : DefaultInputModule in class org.sonar.api.batch.fs.internal.TestInputFileBuilder	From	To
Extract Method private detectLanguage(detection LanguageDetection, path String) : String extracted from public force_language_using_deprecated_property() : void in class org.sonar.scanner.scan.filesystem.LanguageDetectionTest	From	To
Rename Method	2
Rename Method public setUp() : void renamed to public createIndexer(rootModule DefaultInputModule) : void in class org.sonar.scanner.scan.ModuleIndexerTest	From	To
Rename Method public prepare() : void renamed to public setUp() : void in class org.sonar.scanner.postjob.DefaultPostJobContextTest	From	To
Inline Method	1
Inline Method package initPatterns() : void inlined to public start() : void in class org.sonar.scanner.sensor.coverage.CoverageExclusions	From	To
Rename Variable	6
Rename Variable projectDefinition : ProjectDefinition to root : DefaultInputModule in method public setUp() : void in class org.sonar.scanner.scan.WorkDirectoryCleanerTest	From	To
Rename Variable projectDefinition : ProjectDefinition to root : DefaultInputModule in method private setUpTest(file File) : ProjectLock in class org.sonar.scanner.scan.ProjectLockTest	From	To
Rename Variable projectDefinition : ProjectDefinition to module : InputModule in method private store(issue ServerIssue) : void in class org.sonar.scanner.issue.tracking.ServerIssueRepository	From	To
Rename Variable projectReactor : ProjectReactor to hierarchy : InputModuleHierarchy in method private setUpTest(file File) : ProjectLock in class org.sonar.scanner.scan.ProjectLockTest	From	To
Rename Variable projectReactor : ProjectReactor to hierarchy : InputModuleHierarchy in method public setUp() : void in class org.sonar.scanner.scan.WorkDirectoryCleanerTest	From	To
Rename Variable projectDefinition : ProjectDefinition to module : DefaultInputModule in method public setUp() : void in class org.sonar.scanner.analysis.AnalysisTempFolderProviderTest	From	To
Parameterize Variable	2
Parameterize Variable relativePath : String to parentRelativePath : String in method private indexParentDir(fileSystem DefaultModuleFileSystem, inputFile InputFile, parentRelativePath String) : void in class org.sonar.scanner.scan.filesystem.FileIndexer	From	To
Parameterize Variable definition : ProjectDefinition to projectDefinition : ProjectDefinition in method public newDefaultInputModule(projectDefinition ProjectDefinition) : DefaultInputModule in class org.sonar.api.batch.fs.internal.TestInputFileBuilder	From	To
Rename Attribute	5
Rename Attribute projectReactor : ProjectReactor to moduleHierarchy : InputModuleHierarchy in class org.sonar.scanner.analysis.AnalysisTempFolderProviderTest	From	To
Rename Attribute projectReactor : ImmutableProjectReactor to moduleHierarchy : InputModuleHierarchy in class org.sonar.scanner.scm.ScmConfiguration	From	To
Rename Attribute projectReactor : ImmutableProjectReactor to moduleHierarchy : InputModuleHierarchy in class org.sonar.scanner.report.ReportPublisher	From	To
Rename Attribute reactor : ImmutableProjectReactor to moduleHierarchy : InputModuleHierarchy in class org.sonar.scanner.report.ReportPublisherTest	From	To
Rename Attribute patternInitializer : IssueInclusionPatternInitializer to multicriteriaPatterns : List<IssuePattern> in class org.sonar.scanner.issue.ignore.EnforceIssuesFilter	From	To
Change Attribute Type	16
Change Attribute Type activeRulesByLanguage : ListMultimap<String,ActiveRule> to activeRulesByLanguage : ImmutableListMultimap<String,ActiveRule> in class org.sonar.api.batch.rule.internal.DefaultActiveRules	From	To
Change Attribute Type settings : Configuration to settings : CpdSettings in class org.sonar.scanner.cpd.index.SonarCpdBlockIndex	From	To
Change Attribute Type moduleHierarchy : DefaultInputModuleHierarchy to moduleHierarchy : InputModuleHierarchy in class org.sonar.scanner.scan.ModuleIndexer	From	To
Change Attribute Type root : ProjectDefinition to root : DefaultInputModule in class org.sonar.scanner.report.ReportPublisherTest	From	To
Change Attribute Type projectReactor : ProjectReactor to moduleHierarchy : InputModuleHierarchy in class org.sonar.scanner.analysis.AnalysisTempFolderProviderTest	From	To
Change Attribute Type projectReactor : ImmutableProjectReactor to moduleHierarchy : InputModuleHierarchy in class org.sonar.scanner.scm.ScmConfiguration	From	To
Change Attribute Type projectReactor : ImmutableProjectReactor to moduleHierarchy : InputModuleHierarchy in class org.sonar.scanner.report.ReportPublisher	From	To
Change Attribute Type reactor : ImmutableProjectReactor to moduleHierarchy : InputModuleHierarchy in class org.sonar.scanner.report.ReportPublisherTest	From	To
Change Attribute Type children : Multimap<DefaultInputModule,DefaultInputModule> to children : ImmutableMultimap<DefaultInputModule,DefaultInputModule> in class org.sonar.scanner.scan.DefaultInputModuleHierarchy	From	To
Change Attribute Type patternInitializer : IssueInclusionPatternInitializer to multicriteriaPatterns : List<IssuePattern> in class org.sonar.scanner.issue.ignore.EnforceIssuesFilter	From	To
Change Attribute Type settings : MapSettings to settings : CpdSettings in class org.sonar.scanner.cpd.CpdExecutorTest	From	To
Change Attribute Type fileDataByModuleAndPath : Table<String,String,FileData> to fileDataByModuleAndPath : ImmutableTable<String,String,FileData> in class org.sonar.scanner.repository.ProjectRepositories	From	To
Change Attribute Type settingsByModule : Table<String,String,String> to settingsByModule : ImmutableTable<String,String,String> in class org.sonar.scanner.repository.ProjectRepositories	From	To
Change Attribute Type activeRulesByRepository : ListMultimap<String,ActiveRule> to activeRulesByRepository : ImmutableListMultimap<String,ActiveRule> in class org.sonar.api.batch.rule.internal.DefaultActiveRules	From	To
Change Attribute Type rulesByRepository : ListMultimap<String,Rule> to rulesByRepository : ImmutableListMultimap<String,Rule> in class org.sonar.api.batch.rule.internal.DefaultRules	From	To
Change Attribute Type settings : Configuration to settings : CpdSettings in class org.sonar.scanner.cpd.CpdExecutor	From	To
Rename Parameter	12
Rename Parameter projectReactor : ProjectReactor to moduleHierarchy : InputModuleHierarchy in method public WorkDirectoryCleaner(moduleHierarchy InputModuleHierarchy) in class org.sonar.scanner.scan.WorkDirectoryCleaner	From	To
Rename Parameter projectReactor : ImmutableProjectReactor to moduleHierarchy : InputModuleHierarchy in method public ScmConfiguration(moduleHierarchy InputModuleHierarchy, analysisMode AnalysisMode, settings Configuration, providers ScmProvider...) in class org.sonar.scanner.scm.ScmConfiguration	From	To
Rename Parameter projectReactor : ImmutableProjectReactor to moduleHierarchy : InputModuleHierarchy in method public ReportPublisher(settings Configuration, wsClient ScannerWsClient, server Server, contextPublisher AnalysisContextReportPublisher, moduleHierarchy InputModuleHierarchy, analysisMode DefaultAnalysisMode, temp TempFolder, publishers ReportPublisherStep[]) in class org.sonar.scanner.report.ReportPublisher	From	To
Rename Parameter moduleDefinition : ProjectDefinition to module : DefaultInputModule in method public dumpModuleSettings(module DefaultInputModule) : void in class org.sonar.scanner.report.AnalysisContextReportPublisher	From	To
Rename Parameter projectReactor : ImmutableProjectReactor to moduleHierarchy : InputModuleHierarchy in method public ScmConfiguration(moduleHierarchy InputModuleHierarchy, analysisMode AnalysisMode, settings Configuration) in class org.sonar.scanner.scm.ScmConfiguration	From	To
Rename Parameter reactor : ImmutableProjectReactor to componentStore : InputComponentStore in method public ServerIssueRepository(caches Storages, previousIssuesLoader ServerIssuesLoader, componentStore InputComponentStore) in class org.sonar.scanner.issue.tracking.ServerIssueRepository	From	To
Rename Parameter moduleDefinition : ProjectDefinition to module : DefaultInputModule in method public provide(globalSettings GlobalConfiguration, module DefaultInputModule, projectRepos ProjectRepositories, analysisMode AnalysisMode, contextReportPublisher AnalysisContextReportPublisher) : ModuleSettings in class org.sonar.scanner.scan.ModuleSettingsProvider	From	To
Rename Parameter moduleDefinition : ProjectDefinition to module : DefaultInputModule in method private collectModuleSpecificProps(module DefaultInputModule) : Map<String,String> in class org.sonar.scanner.report.AnalysisContextReportPublisher	From	To
Rename Parameter projectReactor : ProjectReactor to moduleHierarchy : InputModuleHierarchy in method public ProjectLock(moduleHierarchy InputModuleHierarchy) in class org.sonar.scanner.scan.ProjectLock	From	To
Rename Parameter resourceCache : InputComponentStore to componentStore : InputComponentStore in method public ServerIssueRepository(caches Storages, previousIssuesLoader ServerIssuesLoader, componentStore InputComponentStore) in class org.sonar.scanner.issue.tracking.ServerIssueRepository	From	To
Rename Parameter moduleKey : String to moduleKeyWithBranch : String in method public getModule(moduleKeyWithBranch String) : InputModule in class org.sonar.scanner.scan.filesystem.InputComponentStore	From	To
Rename Parameter projectReactor : ProjectReactor to moduleHierarchy : InputModuleHierarchy in method public provide(moduleHierarchy InputModuleHierarchy) : TempFolder in class org.sonar.scanner.analysis.AnalysisTempFolderProvider	From	To

6f107dcbe90b0fea564e1ecaa96643bfc539329a

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: