sonarqube 6fa3d925c688fa8e67480c7a69ded9f86aba5326

6fa3d925c688fa8e67480c7a69ded9f86aba5326

Files Diff

Added: 67
Removed: 49
Renamed: 0
Modified: 17

Link to commit

Dependency Action
Added
	com.hazelcast:hazelcast-client:3.8
	com.hazelcast:hazelcast:3.8
Removed
	com.google.code.bean-matchers:bean-matchers:0.9
	org.codehaus.sonar:sonar-graph:5.1
	xpp3:xpp3:1.1.3.3
	xmlunit:xmlunit:1.4

Refactorings reported:

Refactoring Name	Occurences
Change Parameter Type	3
Change Parameter Type embeddedDatabasePort : String to embeddedDatabasePort : int in method private buildH2JdbcUrl(embeddedDatabasePort int) : String in class org.sonar.application.config.JdbcSettings	From	To
Change Parameter Type props : Props to appSettings : AppSettings in method package ClusterProperties(appSettings AppSettings) in class org.sonar.application.cluster.ClusterProperties	From	To
Change Parameter Type port : String to port : int in method private warnIfUrlIsSet(port int, existing String, expectedUrl String) : void in class org.sonar.application.config.JdbcSettings	From	To
Move Method	1
Move Method public closeStreams(process Process) : void from class org.sonar.process.ProcessUtils to public closeStreams() : void from class org.sonar.application.process.ProcessMonitorImpl	From	To
Move Source Folder	1
Move Source Folder sonar-application to server/sonar-process-monitor	From	To
Move Attribute	2
Move Attribute private systemExit : SystemExit from class org.sonar.process.monitor.Monitor to private systemExit : SystemExit from class org.sonar.application.App	From	To
Move Attribute private javaCommandFactory : JavaCommandFactory from class org.sonar.application.App to private javaCommandFactory : JavaCommandFactory from class org.sonar.application.SchedulerImpl	From	To
Rename Class	2
Rename Class org.sonar.process.FileUtilsTest renamed to org.sonar.process.FileUtils2Test	From	To
Rename Class org.sonar.process.FileUtils renamed to org.sonar.process.FileUtils2	From	To
Move And Rename Class	5
Move And Rename Class org.sonar.process.monitor.Monitor.RestartRequestWatcherThread moved and renamed to org.sonar.application.process.SQProcess.EventWatcher	From	To
Move And Rename Class org.sonar.process.monitor.JavaProcessLauncher moved and renamed to org.sonar.application.process.JavaProcessLauncherImpl	From	To
Move And Rename Class org.sonar.process.monitor.Monitor.RestartorThread moved and renamed to org.sonar.application.SchedulerImpl.RestarterThread	From	To
Move And Rename Class org.sonar.process.monitor.Monitor.TerminatorThread moved and renamed to org.sonar.application.SchedulerImpl.StopperThread	From	To
Move And Rename Class org.sonar.process.monitor.Monitor.MonitorShutdownHook moved and renamed to org.sonar.application.process.SQProcess.StopWatcher	From	To
Move Class	12
Move Class org.sonar.process.monitor.StreamGobbler moved to org.sonar.application.process.StreamGobbler	From	To
Move Class org.sonar.process.monitor.JavaCommandTest moved to org.sonar.application.process.JavaCommandTest	From	To
Move Class org.sonar.application.JdbcSettings moved to org.sonar.application.config.JdbcSettings	From	To
Move Class org.sonar.application.ClusterProperties moved to org.sonar.application.cluster.ClusterProperties	From	To
Move Class org.sonar.process.monitor.StreamGobblerTest moved to org.sonar.application.process.StreamGobblerTest	From	To
Move Class org.sonar.application.CommandLineParser moved to org.sonar.application.config.CommandLineParser	From	To
Move Class org.sonar.application.JavaCommandFactory moved to org.sonar.application.process.JavaCommandFactory	From	To
Move Class org.sonar.application.JdbcSettingsTest moved to org.sonar.application.config.JdbcSettingsTest	From	To
Move Class org.sonar.process.monitor.FileSystem moved to org.sonar.application.FileSystem	From	To
Move Class org.sonar.application.JavaCommandFactoryImpl moved to org.sonar.application.process.JavaCommandFactoryImpl	From	To
Move Class org.sonar.process.monitor.JavaCommand moved to org.sonar.application.process.JavaCommand	From	To
Move Class org.sonar.application.ClusterPropertiesTest moved to org.sonar.application.cluster.ClusterPropertiesTest	From	To
Change Variable Type	4
Change Variable Type props : Props to appSettings : AppSettings in method public test_interfaces_parameter() : void in class org.sonar.application.cluster.ClusterPropertiesTest	From	To
Change Variable Type props : Props to appSettings : AppSettings in method public validate_does_not_fail_if_cluster_enabled_and_name_specified() : void in class org.sonar.application.cluster.ClusterPropertiesTest	From	To
Change Variable Type props : Props to appSettings : AppSettings in method public test_missing_name() : void in class org.sonar.application.cluster.ClusterPropertiesTest	From	To
Change Variable Type processBuilder : ProcessBuilder to processBuilder : SystemProcessBuilder in method public launch(javaCommand JavaCommand) : ProcessMonitor in class org.sonar.application.process.JavaProcessLauncherImpl	From	To
Rename Method	10
Rename Method public createCeCommand(props Props, workDir File) : JavaCommand renamed to public createWebCommand(leader boolean) : JavaCommand in class org.sonar.application.process.JavaCommandFactoryImpl	From	To
Rename Method public createESCommand(props Props, homeDir File) : JavaCommand renamed to public createEsCommand() : JavaCommand in class org.sonar.application.process.JavaCommandFactory	From	To
Rename Method public createESCommand(props Props, workDir File) : JavaCommand renamed to public createEsCommand() : JavaCommand in class org.sonar.application.process.JavaCommandFactoryImpl	From	To
Rename Method public checkAndComplete(homeDir File, props Props) : void renamed to public accept(props Props) : void in class org.sonar.application.config.JdbcSettings	From	To
Rename Method public test_parameters() : void renamed to public test_command_with_complete_information() : void in class org.sonar.application.process.JavaCommandTest	From	To
Rename Method public createCeCommand(props Props, homeDir File) : JavaCommand renamed to public createWebCommand(leader boolean) : JavaCommand in class org.sonar.application.process.JavaCommandFactory	From	To
Rename Method public checkAndComplete_sets_driver_path_for_h2() : void renamed to public sets_driver_path_for_h2() : void in class org.sonar.application.config.JdbcSettingsTest	From	To
Rename Method public add_java_options() : void renamed to public addJavaOptions_adds_jvm_options() : void in class org.sonar.application.process.JavaCommandTest	From	To
Rename Method public createWebCommand(props Props, homeDir File) : JavaCommand renamed to public createCeCommand() : JavaCommand in class org.sonar.application.process.JavaCommandFactory	From	To
Rename Method public createWebCommand(props Props, workDir File) : JavaCommand renamed to public createCeCommand() : JavaCommand in class org.sonar.application.process.JavaCommandFactoryImpl	From	To
Change Return Type	2
Change Return Type ProcessBuilder to SystemProcessBuilder in method private create(javaCommand JavaCommand) : SystemProcessBuilder in class org.sonar.application.process.JavaProcessLauncherImpl	From	To
Change Return Type ProcessRef to ProcessMonitor in method public launch(javaCommand JavaCommand) : ProcessMonitor in class org.sonar.application.process.JavaProcessLauncherImpl	From	To
Replace Variable With Attribute	11
Replace Variable With Attribute props : Props to appSettings : AppSettings in method public test_missing_name() : void in class org.sonar.application.cluster.ClusterPropertiesTest	From	To
Replace Variable With Attribute props : Props to appSettings : AppSettings in method public validate_does_not_fail_if_cluster_enabled_and_name_specified() : void in class org.sonar.application.cluster.ClusterPropertiesTest	From	To
Replace Variable With Attribute home : File to homeDir : File in method public sets_driver_path_for_h2() : void in class org.sonar.application.config.JdbcSettingsTest	From	To
Replace Variable With Attribute props : Props to appSettings : AppSettings in method public test_interfaces_parameter() : void in class org.sonar.application.cluster.ClusterPropertiesTest	From	To
Replace Variable With Attribute home : File to homeDir : File in method public checkAndComplete_sets_driver_path_for_oracle() : void in class org.sonar.application.config.JdbcSettingsTest	From	To
Replace Variable With Attribute home : File to homeDir : File in method public driver_file() : void in class org.sonar.application.config.JdbcSettingsTest	From	To
Replace Variable With Attribute home : File to homeDir : File in method public checkAndComplete_sets_driver_path_for_mssql() : void in class org.sonar.application.config.JdbcSettingsTest	From	To
Replace Variable With Attribute home : File to homeDir : File in method public driver_dir_does_not_exist() : void in class org.sonar.application.config.JdbcSettingsTest	From	To
Replace Variable With Attribute home : File to homeDir : File in method public no_files_in_driver_dir() : void in class org.sonar.application.config.JdbcSettingsTest	From	To
Replace Variable With Attribute home : File to homeDir : File in method public too_many_files_in_driver_dir() : void in class org.sonar.application.config.JdbcSettingsTest	From	To
Replace Variable With Attribute home : File to homeDir : File in method public checkAndComplete_sets_driver_path_for_postgresql() : void in class org.sonar.application.config.JdbcSettingsTest	From	To
Rename Attribute	1
Rename Attribute settings : JdbcSettings to underTest : JdbcSettings in class org.sonar.application.config.JdbcSettingsTest	From	To
Change Package	1
Change Package org.sonar.process.monitor to org.sonar.application.process	From	To
Extract Interface	1
Extract Interface org.sonar.application.process.JavaProcessLauncher from classes [org.sonar.application.process.JavaProcessLauncherImpl]	From	To
Rename Parameter	3
Rename Parameter props : Props to appSettings : AppSettings in method package ClusterProperties(appSettings AppSettings) in class org.sonar.application.cluster.ClusterProperties	From	To
Rename Parameter workDir : File to homeDir : File in method private newJavaCommand(id ProcessId, homeDir File) : JavaCommand in class org.sonar.application.process.JavaCommandFactoryImpl	From	To
Rename Parameter command : JavaCommand to javaCommand : JavaCommand in method public launch(javaCommand JavaCommand) : ProcessMonitor in class org.sonar.application.process.JavaProcessLauncherImpl	From	To

6fa3d925c688fa8e67480c7a69ded9f86aba5326

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: