751e4000e40a4af66b80767d632b1bef64dc5647
Files Diff
- Added: 45
- Removed: 0
- Renamed: 0
- Modified: 228
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 5 | ||
| Rename Method public selectByKey() : void renamed to public selectByBranchKey() : void in class org.sonar.db.component.BranchDaoTest | From | To | |
| Rename Method public isShortLivingBranch() : boolean renamed to public isShortOrPullRequest() : boolean in class org.sonar.scanner.scan.branch.BranchConfiguration | From | To | |
| Rename Method package getBranchName(taskUuid String) : Optional<String> renamed to package getBranchKey(taskUuid String) : Optional<String> in class org.sonar.server.ce.ws.TaskFormatter.DtoCache | From | To | |
| Rename Method private toDisplayName(branchType BranchType) : String renamed to private branchTypeToDisplayName(branchType BranchType) : String in class org.sonar.scanner.scan.ProjectScanContainer | From | To | |
| Rename Method public upsert() : void renamed to public upsert_branch() : void in class org.sonar.db.component.BranchDaoTest | From | To | |
| Move And Inline Method | 2 | ||
| Move And Inline Method public getByKeyAndOptionalBranch(dbSession DbSession, key String, branch String) : ComponentDto moved from class org.sonar.server.component.ComponentFinder to class org.sonar.server.component.ws.AppAction & inlined to private loadComponent(dbSession DbSession, request Request) : ComponentDto | From | To | |
| Move And Inline Method public getByKeyAndOptionalBranch(dbSession DbSession, key String, branch String) : ComponentDto moved from class org.sonar.server.component.ComponentFinder to class org.sonar.server.duplication.ws.ShowAction & inlined to private loadComponent(dbSession DbSession, request Request) : ComponentDto | From | To | |
| Rename Variable | 2 | ||
| Rename Variable branchConfig : BranchConfiguration to result : BranchConfiguration in method public should_use_loader() : void in class org.sonar.scanner.scan.branch.BranchConfigurationProviderTest | From | To | |
| Rename Variable configuration : BranchConfiguration to result : BranchConfiguration in method public should_return_default_if_no_loader() : void in class org.sonar.scanner.scan.branch.BranchConfigurationProviderTest | From | To | |
| Change Return Type | 1 | ||
| Change Return Type String to void in method public delete(request DeleteRequest) : void in class org.sonarqube.ws.client.projectbranches.ProjectBranchesService | From | To | |
| Extract Attribute | 5 | ||
| Extract Attribute private PARAM_UUID : String in class org.sonar.server.duplication.ws.ShowAction | From | To | |
| Extract Attribute private PARAM_KEY : String in class org.sonar.server.source.ws.RawAction | From | To | |
| Extract Attribute private PARAM_BRANCH : String in class org.sonar.server.source.ws.RawAction | From | To | |
| Extract Attribute private PARAM_KEY : String in class org.sonar.server.duplication.ws.ShowAction | From | To | |
| Extract Attribute private PARAM_BRANCH : String in class org.sonar.server.duplication.ws.ShowAction | From | To | |
| Extract Variable | 3 | ||
| Extract Variable branchType : BranchType in method private addBranchInformation(builder ScannerReport.Metadata.Builder) : void from class org.sonar.scanner.report.MetadataPublisher | From | To | |
| Extract Variable branchKey : String in method private createBranch() : BranchImpl from class org.sonar.server.computation.task.projectanalysis.api.posttask.PostProjectAnalysisTasksExecutor | From | To | |
| Extract Variable branchUuids : List<String> in method public handle(request Request, response Response) : void from class org.sonar.server.branch.ws.ListAction | From | To | |
| Extract Method | 3 | ||
| Extract Method private addBranchInformation(builder ScannerReport.Metadata.Builder) : void extracted from public publish(writer ScannerReportWriter) : void in class org.sonar.scanner.report.MetadataPublisher | From | To | |
| Extract Method private addScmInformation(builder ScannerReport.Metadata.Builder) : void extracted from public publish(writer ScannerReportWriter) : void in class org.sonar.scanner.report.MetadataPublisher | From | To | |
| Extract Method private isBranchFeatureAvailable() : boolean extracted from public validate(reactor ProjectReactor) : void in class org.sonar.scanner.scan.ProjectReactorValidator | From | To | |
| Extract And Move Method | 2 | ||
| Extract And Move Method public getByKeyAndOptionalBranchOrPullRequest(dbSession DbSession, key String, branch String, pullRequest String) : ComponentDto extracted from private loadComponent(dbSession DbSession, request SearchRequest) : ComponentDto in class org.sonar.server.projectanalysis.ws.SearchAction & moved to class org.sonar.server.component.ComponentFinder | From | To | |
| Extract And Move Method public getByKeyAndOptionalBranchOrPullRequest(dbSession DbSession, key String, branch String, pullRequest String) : ComponentDto extracted from private loadComponent(dbSession DbSession, request SearchHistoryRequest) : ComponentDto in class org.sonar.server.measure.ws.SearchHistoryAction & moved to class org.sonar.server.component.ComponentFinder | From | To |