75e926deef21688a74904b1feae2a687309a6ab3
Files Diff
- Added: 4
- Removed: 0
- Renamed: 0
- Modified: 20
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Change Parameter Type | 2 | ||
| Change Parameter Type items : Collection<EsQueueDto> to items : List<EsQueueDto> in method private postCommit(dbSession DbSession, items List<EsQueueDto>) : void in class org.sonar.server.rule.index.RuleIndexer | From | To | |
| Change Parameter Type settings : Settings to config : Configuration in method public RecoveryIndexer(system2 System2, config Configuration, dbClient DbClient, userIndexer UserIndexer, ruleIndexer RuleIndexer, activeRuleIndexer ActiveRuleIndexer) in class org.sonar.server.es.RecoveryIndexer | From | To | |
| Move Method | 4 | ||
| Move Method private findBytemanJar() : String from class org.sonarqube.tests.qualityProfile.ActiveRuleEsResilienceTest to private findBytemanJar() : String from class org.sonarqube.tests.Byteman | From | To | |
| Move Method private findBytemanJar() : String from class org.sonarqube.tests.user.UserEsResilienceTest to private findBytemanJar() : String from class org.sonarqube.tests.Byteman | From | To | |
| Move Method private findBytemanScript() : String from class org.sonarqube.tests.user.UserEsResilienceTest to private findBytemanScript(filename String) : String from class org.sonarqube.tests.Byteman | From | To | |
| Move Method private findBytemanScript() : String from class org.sonarqube.tests.qualityProfile.ActiveRuleEsResilienceTest to private findBytemanScript(filename String) : String from class org.sonarqube.tests.Byteman | From | To | |
| Rename Variable | 1 | ||
| Rename Variable rules : Set<RuleKey> to ruleKeys : List<RuleKey> in method private doIndexRules(dbSession DbSession, items List<EsQueueDto>) : IndexingResult in class org.sonar.server.rule.index.RuleIndexer | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute settings : Settings to config : Configuration in class org.sonar.server.es.RecoveryIndexer | From | To | |
| Extract Variable | 1 | ||
| Extract Variable docId : RuleExtensionId in method private doIndexRuleExtensions(dbSession DbSession, items List<EsQueueDto>) : IndexingResult from class org.sonar.server.rule.index.RuleIndexer | From | To | |
| Change Variable Type | 8 | ||
| Change Variable Type docIds : Set<RuleExtensionId> to docIds : List<RuleExtensionId> in method private doIndexRuleExtensions(dbSession DbSession, items List<EsQueueDto>) : IndexingResult in class org.sonar.server.rule.index.RuleIndexer | From | To | |
| Change Variable Type settings : Settings to settings : MapSettings in method public stop_run_if_too_many_failures() : void in class org.sonar.server.es.RecoveryIndexerTest | From | To | |
| Change Variable Type logins : Set<String> to logins : List<String> in method public index(dbSession DbSession, items Collection<EsQueueDto>) : IndexingResult in class org.sonar.server.user.index.UserIndexer | From | To | |
| Change Variable Type settings : Settings to settings : MapSettings in method public start_triggers_recovery_run_at_fixed_rate() : void in class org.sonar.server.es.RecoveryIndexerTest | From | To | |
| Change Variable Type itemsById : Map<String,EsQueueDto> to itemsById : Multimap<String,EsQueueDto> in method public onSuccess(docIds Collection<String>) : void in class org.sonar.server.es.ResiliencyIndexingListener | From | To | |
| Change Variable Type settings : Settings to settings : MapSettings in method private newRecoveryIndexer(userIndexer UserIndexer, ruleIndexer RuleIndexer) : RecoveryIndexer in class org.sonar.server.es.RecoveryIndexerTest | From | To | |
| Change Variable Type rules : Set<RuleKey> to ruleKeys : List<RuleKey> in method private doIndexRules(dbSession DbSession, items List<EsQueueDto>) : IndexingResult in class org.sonar.server.rule.index.RuleIndexer | From | To | |
| Change Variable Type settings : Settings to settings : MapSettings in method public do_not_stop_run_if_success_rate_is_greater_than_ratio() : void in class org.sonar.server.es.RecoveryIndexerTest | From | To | |
| Extract Method | 2 | ||
| Extract Method public idOf(ruleKey RuleKey, scope RuleExtensionScope) : String extracted from public getId() : String in class org.sonar.server.rule.index.RuleExtensionDoc | From | To | |
| Extract Method private createQueueDtoForRule(ruleKey RuleKey) : EsQueueDto extracted from public commitAndIndex(dbSession DbSession, organizationDto OrganizationDto, ruleKey RuleKey) : void in class org.sonar.server.rule.index.RuleIndexer | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type settings : Settings to config : Configuration in class org.sonar.server.es.RecoveryIndexer | From | To | |
| Rename Parameter | 3 | ||
| Rename Parameter settings : Settings to config : Configuration in method public RecoveryIndexer(system2 System2, config Configuration, dbClient DbClient, userIndexer UserIndexer, ruleIndexer RuleIndexer, activeRuleIndexer ActiveRuleIndexer) in class org.sonar.server.es.RecoveryIndexer | From | To | |
| Rename Parameter ruleDtos : Collection<RuleKey> to ruleKeys : Collection<RuleKey> in method public commitAndIndex(dbSession DbSession, ruleKeys Collection<RuleKey>) : void in class org.sonar.server.rule.index.RuleIndexer | From | To | |
| Rename Parameter organizationDto : OrganizationDto to organization : OrganizationDto in method public commitAndIndex(dbSession DbSession, ruleKey RuleKey, organization OrganizationDto) : void in class org.sonar.server.rule.index.RuleIndexer | From | To |