sonarqube 76a4e8fb654e850944ff179ba945989fe7afecec

76a4e8fb654e850944ff179ba945989fe7afecec

Files Diff

Added: 0
Removed: 3
Renamed: 0
Modified: 55

Link to commit

Dependency Action
Removed
	com.google.code.bean-matchers:bean-matchers:0.9
	org.codehaus.sonar:sonar-graph:5.1
	xpp3:xpp3:1.1.3.3
	xmlunit:xmlunit:1.4

Refactorings reported:

Refactoring Name	Occurences
Rename Method	4
Rename Method public shouldNotUpdateKey() : void renamed to public updateKey_throws_IAE_if_component_with_specified_key_does_not_exist() : void in class org.sonar.db.component.ComponentKeyUpdaterDaoTest	From	To
Rename Method public update_key_does_not_updated_inactive_components() : void renamed to public updateKey_does_not_updated_inactive_components() : void in class org.sonar.db.component.ComponentKeyUpdaterDaoTest	From	To
Rename Method public fail_with_functional_exception_when_sub_component_key_is_longer_than_authorized() : void renamed to public updateKey_throws_IAE_when_sub_component_key_is_too_long() : void in class org.sonar.db.component.ComponentKeyUpdaterDaoTest	From	To
Rename Method public shouldUpdateKey() : void renamed to public updateKey_changes_the_key_of_tree_of_components() : void in class org.sonar.db.component.ComponentKeyUpdaterDaoTest	From	To
Move And Inline Method	10
Move And Inline Method public insert(loadedTemplateDto LoadedTemplateDto) : void moved from class org.sonar.db.loadedtemplate.LoadedTemplateDao to class org.sonar.db.source.FileSourceDaoTest & inlined to public insert() : void	From	To
Move And Inline Method public update(qGate QualityGateConditionDto) : void moved from class org.sonar.db.qualitygate.QualityGateConditionDao to class org.sonar.db.qualitygate.QualityGateConditionDaoTest & inlined to public testUpdate() : void	From	To
Move And Inline Method public update(qGate QualityGateConditionDto) : void moved from class org.sonar.db.qualitygate.QualityGateConditionDao to class org.sonar.db.qualitygate.QualityGateDaoTest & inlined to public testUpdate() : void	From	To
Move And Inline Method public insert(loadedTemplateDto LoadedTemplateDto) : void moved from class org.sonar.db.loadedtemplate.LoadedTemplateDao to class org.sonar.server.source.ws.ScmActionTest & inlined to public group_lines_by_commit() : void	From	To
Move And Inline Method public insert(loadedTemplateDto LoadedTemplateDto) : void moved from class org.sonar.db.loadedtemplate.LoadedTemplateDao to class org.sonar.server.source.ws.ScmActionTest & inlined to public not_group_lines_by_commit() : void	From	To
Move And Inline Method public insert(loadedTemplateDto LoadedTemplateDto) : void moved from class org.sonar.db.loadedtemplate.LoadedTemplateDao to class org.sonar.db.source.FileSourceDaoTest & inlined to public readLineHashesStream_does_not_fail_when_lineshashes_is_null() : void	From	To
Move And Inline Method public update(qGate QualityGateConditionDto) : void moved from class org.sonar.db.qualitygate.QualityGateConditionDao to class org.sonar.server.qualitygate.QualityGates & inlined to public rename(idToRename long, name String) : QualityGateDto	From	To
Move And Inline Method public insert(loadedTemplateDto LoadedTemplateDto) : void moved from class org.sonar.db.loadedtemplate.LoadedTemplateDao to class org.sonar.server.source.ws.ScmActionTest & inlined to public accept_negative_value_in_from_parameter() : void	From	To
Move And Inline Method public insert(loadedTemplateDto LoadedTemplateDto) : void moved from class org.sonar.db.loadedtemplate.LoadedTemplateDao to class org.sonar.server.source.ws.ScmActionTest & inlined to public show_scm_from_given_range_lines() : void	From	To
Move And Inline Method public insert(loadedTemplateDto LoadedTemplateDto) : void moved from class org.sonar.db.loadedtemplate.LoadedTemplateDao to class org.sonar.db.source.FileSourceDaoTest & inlined to public selectLineHashes_does_not_fail_when_lineshashes_is_null() : void	From	To
Change Parameter Type	6
Change Parameter Type qualityGateDao : QualityGateDao to dbClient : DbClient in method public QualityGateServiceImpl(dbClient DbClient, metricRepository MetricRepository) in class org.sonar.server.computation.task.projectanalysis.qualitygate.QualityGateServiceImpl	From	To
Change Parameter Type userDao : UserDao to dbClient : DbClient in method public DeprecatedUserFinder(dbClient DbClient) in class org.sonar.server.user.DeprecatedUserFinder	From	To
Change Parameter Type conditionDao : QualityGateConditionDao to metricRepository : MetricRepository in method public QualityGateServiceImpl(dbClient DbClient, metricRepository MetricRepository) in class org.sonar.server.computation.task.projectanalysis.qualitygate.QualityGateServiceImpl	From	To
Change Parameter Type userDao : UserDao to dbClient : DbClient in method public DefaultUserFinder(dbClient DbClient) in class org.sonar.server.user.DefaultUserFinder	From	To
Change Parameter Type dbClient : DbClient to dbSession : DbSession in method private checkQualityGate(dbSession DbSession, id long) : void in class org.sonar.server.qualitygate.ws.SelectAction	From	To
Change Parameter Type myBatis : MyBatis to dbClient : DbClient in method public BackendCleanup(esClient EsClient, dbClient DbClient) in class org.sonar.server.platform.BackendCleanup	From	To
Move Method	1
Move Method private createCommands(props Props) : List<JavaCommand> from class org.sonar.application.App to private createCommands(props Props) : List<JavaCommand> from class org.sonar.application.App.ReloadableCommandSupplier	From	To
Inline Method	1
Inline Method public profile(name String, language String, session DbSession) : QProfile inlined to public profile(name String, language String) : QProfile in class org.sonar.server.qualityprofile.QProfileLookup	From	To
Replace Variable With Attribute	3
Replace Variable With Attribute finder : DeprecatedUserFinder to underTest : DeprecatedUserFinder in method public shouldFindUserById() : void in class org.sonar.server.user.DeprecatedUserFinderTest	From	To
Replace Variable With Attribute finder : DeprecatedUserFinder to underTest : DeprecatedUserFinder in method public shouldFindUserByLogin() : void in class org.sonar.server.user.DeprecatedUserFinderTest	From	To
Replace Variable With Attribute session : DbSession to dbSession : DbSession in method public do_not_reset_default_profile_if_still_valid() : void in class org.sonar.server.qualityprofile.RegisterQualityProfilesMediumTest	From	To
Parameterize Variable	1
Parameterize Variable session : DbSession to dbSession : DbSession in method public updateKey(dbSession DbSession, projectUuid String, newKey String) : void in class org.sonar.db.component.ComponentKeyUpdaterDao	From	To
Rename Attribute	6
Rename Attribute myBatis : MyBatis to dbClient : DbClient in class org.sonar.server.platform.BackendCleanup	From	To
Rename Attribute backendCleanup : BackendCleanup to underTest : BackendCleanup in class org.sonar.server.platform.BackendCleanupTest	From	To
Rename Attribute userDao : UserDao to dbClient : DbClient in class org.sonar.server.user.DeprecatedUserFinder	From	To
Rename Attribute userDao : UserDao to dbClient : DbClient in class org.sonar.server.user.DefaultUserFinder	From	To
Rename Attribute qualityGateDao : QualityGateDao to dbClient : DbClient in class org.sonar.server.computation.task.projectanalysis.qualitygate.QualityGateServiceImpl	From	To
Rename Attribute conditionDao : QualityGateConditionDao to metricRepository : MetricRepository in class org.sonar.server.computation.task.projectanalysis.qualitygate.QualityGateServiceImpl	From	To
Change Attribute Type	5
Change Attribute Type conditionDao : QualityGateConditionDao to metricRepository : MetricRepository in class org.sonar.server.computation.task.projectanalysis.qualitygate.QualityGateServiceImpl	From	To
Change Attribute Type myBatis : MyBatis to dbClient : DbClient in class org.sonar.server.platform.BackendCleanup	From	To
Change Attribute Type userDao : UserDao to dbClient : DbClient in class org.sonar.server.user.DeprecatedUserFinder	From	To
Change Attribute Type userDao : UserDao to dbClient : DbClient in class org.sonar.server.user.DefaultUserFinder	From	To
Change Attribute Type qualityGateDao : QualityGateDao to dbClient : DbClient in class org.sonar.server.computation.task.projectanalysis.qualitygate.QualityGateServiceImpl	From	To
Split Attribute	1
Split Attribute dao : QualityGateDao to [underTest : QualityGateDao, dbSession : DbSession] in class org.sonar.db.qualitygate.QualityGateDaoTest	From	To
Rename Parameter	6
Rename Parameter dbClient : DbClient to dbSession : DbSession in method private checkQualityGate(dbSession DbSession, id long) : void in class org.sonar.server.qualitygate.ws.SelectAction	From	To
Rename Parameter myBatis : MyBatis to dbClient : DbClient in method public BackendCleanup(esClient EsClient, dbClient DbClient) in class org.sonar.server.platform.BackendCleanup	From	To
Rename Parameter qualityGateDao : QualityGateDao to dbClient : DbClient in method public QualityGateServiceImpl(dbClient DbClient, metricRepository MetricRepository) in class org.sonar.server.computation.task.projectanalysis.qualitygate.QualityGateServiceImpl	From	To
Rename Parameter userDao : UserDao to dbClient : DbClient in method public DeprecatedUserFinder(dbClient DbClient) in class org.sonar.server.user.DeprecatedUserFinder	From	To
Rename Parameter userDao : UserDao to dbClient : DbClient in method public DefaultUserFinder(dbClient DbClient) in class org.sonar.server.user.DefaultUserFinder	From	To
Rename Parameter conditionDao : QualityGateConditionDao to metricRepository : MetricRepository in method public QualityGateServiceImpl(dbClient DbClient, metricRepository MetricRepository) in class org.sonar.server.computation.task.projectanalysis.qualitygate.QualityGateServiceImpl	From	To

76a4e8fb654e850944ff179ba945989fe7afecec

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: