sonarqube 78e2ea2661c8e3bcf26932e33e04ec9a4327fc04

78e2ea2661c8e3bcf26932e33e04ec9a4327fc04

Files Diff

Added: 6
Removed: 5
Renamed: 0
Modified: 81

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Merge Attribute	9
Merge Attribute [userAdminWsClient : WsClient, nav : Navigation] to tester : Tester in class it.projectSearch.ProjectsPageTest	From	To
Merge Attribute [userRule : UserRule, adminWsClient : WsClient] to tester : Tester in class it.user.MyAccountPageTest	From	To
Merge Attribute [adminUser : String, ASSIGNEE_LOGIN : String] to user : User in class it.issue.OrganizationIssueAssignTest	From	To
Merge Attribute [adminClient : WsClient, organizations : OrganizationRule] to tester : Tester in class it.organization.OrganizationMembershipTest	From	To
Merge Attribute [anonymousClient : WsClient, adminWsClient : WsClient] to tester : Tester in class it.user.ForceAuthenticationTest	From	To
Merge Attribute [adminClient : WsClient, nav : Navigation, userRule : UserRule] to tester : Tester in class it.organization.BillingTest	From	To
Merge Attribute [organizationRule : OrganizationRule, nav : Navigation] to tester : Tester in class it.projectSearch.LeakProjectsPageTest	From	To
Merge Attribute [userRule : UserRule, adminClient : WsClient, nav : Navigation] to tester : Tester in class it.issue.OrganizationIssueAssignTest	From	To
Merge Attribute [organizationRule : OrganizationRule, adminWsClient : WsClient] to tester : Tester in class it.qualityProfile.OrganizationQualityProfilesUiTest	From	To
Move And Inline Method	2
Move And Inline Method private enablePlugin() : void moved from class it.user.OrganizationIdentityProviderTest to class it.user.OAuth2IdentityProviderTest & inlined to public fail_to_authenticate_when_not_allowed_to_sign_up() : void	From	To
Move And Inline Method private enablePlugin() : void moved from class it.user.OrganizationIdentityProviderTest to class it.user.OAuth2IdentityProviderTest & inlined to public display_message_in_ui_but_not_in_log_when_unauthorized_exception_in_callback() : void	From	To
Change Parameter Type	3
Change Parameter Type member : String to member : User in method private grantUserPermission(projectKey String, member User) : void in class it.issue.IssueTagsTest	From	To
Change Parameter Type member : String to member : User in method private addMemberToOrganization(member User) : void in class it.issue.IssueTagsTest	From	To
Change Parameter Type request : DeleteRequest to profileKey : String in method public delete(profileKey String) : void in class org.sonarqube.ws.client.qualityprofile.QualityProfilesService	From	To
Move Method	3
Move Method public before() : void from class it.uiExtension.UiExtensionsTest to protected before() : void from class org.sonarqube.test.Tester	From	To
Move Method public before() : void from class it.user.OrganizationIdentityProviderTest to protected before() : void from class org.sonarqube.test.Tester	From	To
Move Method public before() : void from class it.uiExtension.OrganizationUiExtensionsTest to protected before() : void from class org.sonarqube.test.Tester	From	To
Extract Class	3
Extract Class org.sonarqube.test.Tester from class it.uiExtension.UiExtensionsTest	From	To
Extract Class org.sonarqube.test.Tester from class it.uiExtension.OrganizationUiExtensionsTest	From	To
Extract Class org.sonarqube.test.Tester from class it.user.OrganizationIdentityProviderTest	From	To
Move And Rename Class	1
Move And Rename Class util.QualityProfileSupport moved and renamed to org.sonarqube.test.QProfileTester	From	To
Change Variable Type	4
Change Variable Type adminProfiles : QualityProfileSupport to adminSession : QProfileTester in method public deleting_an_organization_delete_all_profiles_on_this_organization() : void in class it.qualityProfile.CustomQualityProfilesTest	From	To
Change Variable Type anonymousProfiles : QualityProfileSupport to anonymousSession : Session in method public anonymous_cannot_manage_the_profiles_of_an_organization() : void in class it.qualityProfile.CustomQualityProfilesTest	From	To
Change Variable Type adminProfiles : QualityProfileSupport to adminSession : QProfileTester in method public an_organization_administrator_can_manage_the_profiles_of_organization() : void in class it.qualityProfile.CustomQualityProfilesTest	From	To
Change Variable Type org : Organizations.Organization to organization : Organization in method public logged_in_user_can_create_organizations_if_anyone_is_allowed_to() : void in class it.organization.OrganizationTest	From	To
Extract Variable	7
Extract Variable anonymousConnector : WsConnector in method public batch_ws_does_not_require_authentication() : void from class it.user.ForceAuthenticationTest	From	To
Extract Variable login : String in method public generate(populators Consumer<CreateRequest.Builder>...) : WsUsers.CreateWsResponse.User from class util.user.UserRule	From	To
Extract Variable request : SearchWsRequest in method private verifyOrganization(createdOrganization Organization, name String, description String, url String, avatarUrl String) : void from class it.organization.OrganizationTest	From	To
Extract Variable issuesService : IssuesService in method public call_issues_ws() : void from class it.lite.LiteTest	From	To
Extract Variable request : WsRequest in method private call(client WsClient, path String, method WsRequest.Method) : WsResponse from class it.user.ForceAuthenticationTest	From	To
Extract Variable anonymousConnector : WsConnector in method public authentication_ws_does_not_require_authentication() : void from class it.user.ForceAuthenticationTest	From	To
Extract Variable measuresService : MeasuresService in method public call_measures_ws() : void from class it.lite.LiteTest	From	To
Extract Method	1
Extract Method private delete(profile QualityProfile) : void extracted from public deleting_an_organization_delete_all_profiles_on_this_organization() : void in class it.qualityProfile.CustomQualityProfilesTest	From	To
Inline Variable	4
Inline Variable orgKey : String in method public admin_can_add_members() : void from class it.organization.OrganizationMembershipUiTest	From	To
Inline Variable orgKey : String in method public groups_count_should_be_updated_when_a_member_was_just_added() : void from class it.organization.OrganizationMembershipUiTest	From	To
Inline Variable orgKey : String in method public admin_can_manage_groups() : void from class it.organization.OrganizationMembershipUiTest	From	To
Inline Variable orgKey : String in method public admin_can_remove_members() : void from class it.organization.OrganizationMembershipUiTest	From	To
Rename Method	19
Rename Method public openHomepage() : Navigation renamed to public openHome() : Navigation in class pageobjects.Navigation	From	To
Rename Method private purgeSettings() : void renamed to public tearDown() : void in class it.user.OrganizationIdentityProviderTest	From	To
Rename Method public createUser(populators Consumer<CreateRequest.Builder>...) : WsUsers.CreateWsResponse.User renamed to public generate(populators Consumer<CreateRequest.Builder>...) : WsUsers.CreateWsResponse.User in class util.user.UserRule	From	To
Rename Method public global_admin_page() : void renamed to public test_project_page() : void in class it.uiExtension.UiExtensionsTest	From	To
Rename Method private addMember(member String) : void renamed to private addMemberToOrganization(member User) : void in class it.issue.IssueTagsTest	From	To
Rename Method public rootService() : RootsService renamed to public roots() : RootsService in class org.sonarqube.ws.client.WsClient	From	To
Rename Method public rootService() : RootsService renamed to public roots() : RootsService in class org.sonarqube.ws.client.DefaultWsClient	From	To
Rename Method public create_new_user_when_authenticate() : void renamed to public create_user_when_authenticating_for_the_first_time() : void in class it.user.OAuth2IdentityProviderTest	From	To
Rename Method public settingsService() : SettingsService renamed to public settings() : SettingsService in class org.sonarqube.ws.client.DefaultWsClient	From	To
Rename Method private addMembership(organization Organization, user User) : void renamed to private addMember(organization Organization, member1 User) : OrganizationTester in class it.organization.OrganizationMembershipUiTest	From	To
Rename Method public shouldBeRedirectToLogin() : void renamed to public shouldBeRedirectedToLogin() : Navigation in class pageobjects.Navigation	From	To
Rename Method public project_page() : void renamed to public test_project_administration_page() : void in class it.uiExtension.UiExtensionsTest	From	To
Rename Method public settingsService() : SettingsService renamed to public settings() : SettingsService in class org.sonarqube.ws.client.WsClient	From	To
Rename Method private assertOnboardingTutorial(expectedOnboardingTutorial boolean) : void renamed to private verifyTutorial(user User, expectedTutorial boolean) : void in class it.user.OnboardingTest	From	To
Rename Method public deleteSampleProfile() : void renamed to public tearDown() : void in class it.qualityProfile.QualityProfilesUiTest	From	To
Rename Method public global_page() : void renamed to public test_global_administration_page() : void in class it.uiExtension.UiExtensionsTest	From	To
Rename Method public createAdminUser() : void renamed to public setUp() : void in class it.organization.BillingTest	From	To
Rename Method public projectAnanlysis() : ProjectAnalysisService renamed to public projectAnalysis() : ProjectAnalysisService in class org.sonarqube.ws.client.WsClient	From	To
Rename Method public projectAnanlysis() : ProjectAnalysisService renamed to public projectAnalysis() : ProjectAnalysisService in class org.sonarqube.ws.client.DefaultWsClient	From	To
Rename Variable	7
Rename Variable user : User to user1 : User in method public admin_can_add_members() : void in class it.organization.OrganizationMembershipUiTest	From	To
Rename Variable user1 : User to member1 : User in method public search_for_members() : void in class it.organization.OrganizationMembershipUiTest	From	To
Rename Variable adminProfiles : QualityProfileSupport to adminSession : QProfileTester in method public deleting_an_organization_delete_all_profiles_on_this_organization() : void in class it.qualityProfile.CustomQualityProfilesTest	From	To
Rename Variable anonymousProfiles : QualityProfileSupport to anonymousSession : Session in method public anonymous_cannot_manage_the_profiles_of_an_organization() : void in class it.qualityProfile.CustomQualityProfilesTest	From	To
Rename Variable org : Organizations.Organization to organization : Organization in method public logged_in_user_can_create_organizations_if_anyone_is_allowed_to() : void in class it.organization.OrganizationTest	From	To
Rename Variable adminProfiles : QualityProfileSupport to adminSession : QProfileTester in method public an_organization_administrator_can_manage_the_profiles_of_organization() : void in class it.qualityProfile.CustomQualityProfilesTest	From	To
Rename Variable user2 : User to member2 : User in method public search_for_members() : void in class it.organization.OrganizationMembershipUiTest	From	To
Inline Method	1
Inline Method private executeAnalysis(projectKey String, organizationKey String) : String inlined to private executeAnalysis(projectKey String) : String in class it.organization.BillingTest	From	To
Change Return Type	7
Change Return Type QualityProfileSupport to QProfileTester in method public assertThatNumberOfActiveRulesEqualsTo(profile QualityProfile, expectedActiveRules int) : QProfileTester in class org.sonarqube.test.QProfileTester	From	To
Change Return Type QualityProfileSupport to QProfileTester in method public activateRule(profile QualityProfile, ruleKey String) : QProfileTester in class org.sonarqube.test.QProfileTester	From	To
Change Return Type void to Navigation in method public shouldBeRedirectedToLogin() : Navigation in class pageobjects.Navigation	From	To
Change Return Type QualityProfileSupport to QProfileTester in method public deactivateRule(profile QualityProfile, ruleKey String) : QProfileTester in class org.sonarqube.test.QProfileTester	From	To
Change Return Type void to Navigation in method public shouldBeLoggedIn() : Navigation in class pageobjects.Navigation	From	To
Change Return Type void to Navigation in method public shouldNotBeLoggedIn() : Navigation in class pageobjects.Navigation	From	To
Change Return Type void to OrganizationTester in method private addMember(organization Organization, member1 User) : OrganizationTester in class it.organization.OrganizationMembershipUiTest	From	To
Rename Attribute	4
Rename Attribute ORCHESTRATOR : Orchestrator to orchestrator : Orchestrator in class it.user.LocalAuthenticationTest	From	To
Rename Attribute adminUser : String to administrator : User in class it.user.MyAccountPageTest	From	To
Rename Attribute profiles : QualityProfileRule to tester : Tester in class it.qualityProfile.CustomQualityProfilesTest	From	To
Rename Attribute ORCHESTRATOR : Orchestrator to orchestrator : Orchestrator in class it.user.OAuth2IdentityProviderTest	From	To
Change Attribute Type	3
Change Attribute Type adminUser : String to administrator : User in class it.user.MyAccountPageTest	From	To
Change Attribute Type profiles : QualityProfileRule to tester : Tester in class it.qualityProfile.CustomQualityProfilesTest	From	To
Change Attribute Type organization : Organizations.Organization to organization : Organization in class it.issue.IssueTagsTest	From	To
Extract And Move Method	3
Extract And Move Method public expectHttpError(expectedCode int, expectedMessage String, runnable Runnable) : void extracted from public fail_to_update_project_visibility_to_private() : void in class it.organization.BillingTest & moved to class util.ItUtils	From	To
Extract And Move Method public expectHttpError(expectedCode int, expectedMessage String, runnable Runnable) : void extracted from public fail_to_create_private_project() : void in class it.organization.BillingTest & moved to class util.ItUtils	From	To
Extract And Move Method public expectHttpError(expectedCode int, expectedMessage String, runnable Runnable) : void extracted from public fail_to_update_organization_default_visibility_to_private() : void in class it.organization.BillingTest & moved to class util.ItUtils	From	To
Rename Parameter	6
Rename Parameter user : String to userLogin : String in method private assertTags(userLogin String, organization String, expectedTags String...) : void in class it.issue.IssueTagsTest	From	To
Rename Parameter showOnboardingTutorial : boolean to showTutorial : boolean in method private setShownOnboardingSetting(showTutorial boolean) : void in class it.user.OnboardingTest	From	To
Rename Parameter user : User to member1 : User in method private addMember(organization Organization, member1 User) : OrganizationTester in class it.organization.OrganizationMembershipUiTest	From	To
Rename Parameter request : DeleteRequest to profileKey : String in method public delete(profileKey String) : void in class org.sonarqube.ws.client.qualityprofile.QualityProfilesService	From	To
Rename Parameter organizationKey : String to projectKey : String in method private executeAnalysis(projectKey String) : String in class it.organization.BillingTest	From	To
Rename Parameter expectedOnboardingTutorial : boolean to expectedTutorial : boolean in method private verifyTutorial(user User, expectedTutorial boolean) : void in class it.user.OnboardingTest	From	To

78e2ea2661c8e3bcf26932e33e04ec9a4327fc04

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: