sonarqube 7a894686606925522e1a6d8b01c7c2fc092200c9

7a894686606925522e1a6d8b01c7c2fc092200c9

Files Diff

Added: 27
Removed: 6
Renamed: 0
Modified: 46

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Extract Subclass	1
Extract Subclass org.sonar.server.authentication.UserIdentityAuthenticatorImpl from class org.sonar.server.authentication.UserIdentityAuthenticator	From	To
Change Parameter Type	2
Change Parameter Type organizationCreation : OrganizationCreation to organizationUpdater : OrganizationUpdater in method public UserUpdater(newUserNotifier NewUserNotifier, dbClient DbClient, userIndexer UserIndexer, organizationFlags OrganizationFlags, defaultOrganizationProvider DefaultOrganizationProvider, organizationUpdater OrganizationUpdater, defaultGroupFinder DefaultGroupFinder, config Configuration, localAuthentication LocalAuthentication) in class org.sonar.server.user.UserUpdater	From	To
Change Parameter Type organizationCreation : OrganizationCreation to organizationUpdater : OrganizationUpdater in method public CreateAction(config Configuration, userSession UserSession, dbClient DbClient, wsSupport OrganizationsWsSupport, organizationValidation OrganizationValidation, organizationUpdater OrganizationUpdater, organizationFlags OrganizationFlags) in class org.sonar.server.organization.ws.CreateAction	From	To
Push Down Attribute	6
Push Down Attribute private organizationFlags : OrganizationFlags from class org.sonar.server.authentication.UserIdentityAuthenticator to private organizationFlags : OrganizationFlags from class org.sonar.server.authentication.UserIdentityAuthenticatorImpl	From	To
Push Down Attribute private defaultGroupFinder : DefaultGroupFinder from class org.sonar.server.authentication.UserIdentityAuthenticator to private defaultGroupFinder : DefaultGroupFinder from class org.sonar.server.authentication.UserIdentityAuthenticatorImpl	From	To
Push Down Attribute private dbClient : DbClient from class org.sonar.server.authentication.UserIdentityAuthenticator to private dbClient : DbClient from class org.sonar.server.authentication.UserIdentityAuthenticatorImpl	From	To
Push Down Attribute private userUpdater : UserUpdater from class org.sonar.server.authentication.UserIdentityAuthenticator to private userUpdater : UserUpdater from class org.sonar.server.authentication.UserIdentityAuthenticatorImpl	From	To
Push Down Attribute private LOGGER : Logger from class org.sonar.server.authentication.UserIdentityAuthenticator to private LOGGER : Logger from class org.sonar.server.authentication.UserIdentityAuthenticatorImpl	From	To
Push Down Attribute private defaultOrganizationProvider : DefaultOrganizationProvider from class org.sonar.server.authentication.UserIdentityAuthenticator to private defaultOrganizationProvider : DefaultOrganizationProvider from class org.sonar.server.authentication.UserIdentityAuthenticatorImpl	From	To
Rename Class	5
Rename Class org.sonar.server.organization.OrganizationCreation renamed to org.sonar.server.organization.OrganizationUpdater	From	To
Rename Class org.sonarqube.tests.user.OrganizationIdentityProviderTest renamed to org.sonarqube.tests.user.OrganizationBaseIdentityProviderTest	From	To
Rename Class org.sonar.server.authentication.UserIdentityAuthenticatorTest renamed to org.sonar.server.authentication.UserIdentityAuthenticatorImplTest	From	To
Rename Class org.sonar.server.organization.OrganizationCreationImpl renamed to org.sonar.server.organization.OrganizationUpdaterImpl	From	To
Rename Class org.sonar.server.organization.OrganizationCreationImplTest renamed to org.sonar.server.organization.OrganizationUpdaterImplTest	From	To
Move And Rename Class	1
Move And Rename Class org.sonar.server.authentication.EmailAlreadyExistsException moved and renamed to org.sonar.server.authentication.exception.EmailAlreadyExistsRedirectionException	From	To
Move Class	1
Move Class org.sonar.server.authentication.UserIdentityAuthenticator.ExistingEmailStrategy moved to org.sonar.server.authentication.UserIdentityAuthenticatorParameters.ExistingEmailStrategy	From	To
Extract Method	1
Extract Method private checkKey(dbSession DbSession, key String) : void extracted from public createForUser(dbSession DbSession, newUser UserDto) : Optional<OrganizationDto> in class org.sonar.server.organization.OrganizationUpdaterImpl	From	To
Rename Method	5
Rename Method public init_create_cookie_containing_parameters_from_request() : void renamed to public init_create_cookie() : void in class org.sonar.server.authentication.OAuth2AuthenticationParametersImplTest	From	To
Rename Method public update_does_not_update_key_nor_createdAt() : void renamed to public update_does_not_update_createdAt() : void in class org.sonar.db.organization.OrganizationDaoTest	From	To
Rename Method public migration_is_reentrant() : void renamed to public migration_is_not_reentrant() : void in class org.sonar.server.platform.db.migration.version.v72.AddExternalIdToUsersTest	From	To
Rename Method public default_group_is_not_added_for_new_user() : void renamed to public synchronize_groups_for_new_user() : void in class org.sonarqube.tests.user.OrganizationBaseIdentityProviderTest	From	To
Rename Method public default_group_is_not_sync_for_existing_user() : void renamed to public synchronize_groups_for_existing_user() : void in class org.sonarqube.tests.user.OrganizationBaseIdentityProviderTest	From	To
Push Down Method	12
Push Down Method private validateEmail(dbSession DbSession, identity UserIdentity, provider IdentityProvider, source AuthenticationEvent.Source, existingEmailStrategy ExistingEmailStrategy) : Optional<UserDto> from class org.sonar.server.authentication.UserIdentityAuthenticator to private detectEmailUpdate(dbSession DbSession, authenticatorParameters UserIdentityAuthenticatorParameters) : Optional<UserDto> from class org.sonar.server.authentication.UserIdentityAuthenticatorImpl	From	To
Push Down Method public UserIdentityAuthenticator(dbClient DbClient, userUpdater UserUpdater, defaultOrganizationProvider DefaultOrganizationProvider, organizationFlags OrganizationFlags, defaultGroupFinder DefaultGroupFinder) from class org.sonar.server.authentication.UserIdentityAuthenticator to public UserIdentityAuthenticatorImpl(dbClient DbClient, userUpdater UserUpdater, defaultOrganizationProvider DefaultOrganizationProvider, organizationFlags OrganizationFlags, organizationUpdater OrganizationUpdater, defaultGroupFinder DefaultGroupFinder) from class org.sonar.server.authentication.UserIdentityAuthenticatorImpl	From	To
Push Down Method private syncGroups(dbSession DbSession, userIdentity UserIdentity, userDto UserDto) : void from class org.sonar.server.authentication.UserIdentityAuthenticator to private syncGroups(dbSession DbSession, userIdentity UserIdentity, userDto UserDto) : void from class org.sonar.server.authentication.UserIdentityAuthenticatorImpl	From	To
Push Down Method private createNewUser(identity UserIdentity, provider IdentityProvider, source AuthenticationEvent.Source) : NewUser from class org.sonar.server.authentication.UserIdentityAuthenticator to private createNewUser(authenticatorParameters UserIdentityAuthenticatorParameters) : NewUser from class org.sonar.server.authentication.UserIdentityAuthenticatorImpl	From	To
Push Down Method public authenticate(userIdentity UserIdentity, provider IdentityProvider, source AuthenticationEvent.Source, existingEmailStrategy ExistingEmailStrategy) : UserDto from class org.sonar.server.authentication.UserIdentityAuthenticator to public authenticate(authenticatorParameters UserIdentityAuthenticatorParameters) : UserDto from class org.sonar.server.authentication.UserIdentityAuthenticatorImpl	From	To
Push Down Method private getUser(dbSession DbSession, userIdentity UserIdentity, provider IdentityProvider) : UserDto from class org.sonar.server.authentication.UserIdentityAuthenticator to private getUser(dbSession DbSession, userIdentity UserIdentity, provider IdentityProvider) : UserDto from class org.sonar.server.authentication.UserIdentityAuthenticatorImpl	From	To
Push Down Method private toArray(userDto Optional<UserDto>) : UserDto[] from class org.sonar.server.authentication.UserIdentityAuthenticator to private toArray(userDto Optional<UserDto>) : UserDto[] from class org.sonar.server.authentication.UserIdentityAuthenticatorImpl	From	To
Push Down Method private getDefaultGroup(dbSession DbSession) : Optional<GroupDto> from class org.sonar.server.authentication.UserIdentityAuthenticator to private getDefaultGroup(dbSession DbSession) : Optional<GroupDto> from class org.sonar.server.authentication.UserIdentityAuthenticatorImpl	From	To
Push Down Method private registerNewUser(dbSession DbSession, disabledUser UserDto, identity UserIdentity, provider IdentityProvider, source AuthenticationEvent.Source, existingEmailStrategy ExistingEmailStrategy) : UserDto from class org.sonar.server.authentication.UserIdentityAuthenticator to private registerNewUser(dbSession DbSession, disabledUser UserDto, authenticatorParameters UserIdentityAuthenticatorParameters) : UserDto from class org.sonar.server.authentication.UserIdentityAuthenticatorImpl	From	To
Push Down Method private registerExistingUser(dbSession DbSession, userDto UserDto, identity UserIdentity, provider IdentityProvider, source AuthenticationEvent.Source, existingEmailStrategy ExistingEmailStrategy) : UserDto from class org.sonar.server.authentication.UserIdentityAuthenticator to private registerExistingUser(dbSession DbSession, userDto UserDto, authenticatorParameters UserIdentityAuthenticatorParameters) : UserDto from class org.sonar.server.authentication.UserIdentityAuthenticatorImpl	From	To
Push Down Method private removeGroups(dbSession DbSession, userDto UserDto, groupsToRemove Collection<String>, groupsByName Map<String,GroupDto>) : void from class org.sonar.server.authentication.UserIdentityAuthenticator to private removeGroups(dbSession DbSession, userDto UserDto, groupsToRemove Collection<String>, groupsByName Map<String,GroupDto>) : void from class org.sonar.server.authentication.UserIdentityAuthenticatorImpl	From	To
Push Down Method private addGroups(dbSession DbSession, userDto UserDto, groupsToAdd Collection<String>, groupsByName Map<String,GroupDto>) : void from class org.sonar.server.authentication.UserIdentityAuthenticator to private addGroups(dbSession DbSession, userDto UserDto, groupsToAdd Collection<String>, groupsByName Map<String,GroupDto>) : void from class org.sonar.server.authentication.UserIdentityAuthenticatorImpl	From	To
Extract Superclass	1
Extract Superclass org.sonar.server.authentication.exception.RedirectionException from classes [org.sonar.server.authentication.exception.EmailAlreadyExistsRedirectionException]	From	To
Rename Attribute	5
Rename Attribute organizationCreation : OrganizationCreation to organizationUpdater : OrganizationUpdater in class org.sonar.server.user.UserUpdaterCreateTest	From	To
Rename Attribute organizationCreation : OrganizationCreation to organizationUpdater : OrganizationUpdater in class org.sonar.server.organization.ws.CreateAction	From	To
Rename Attribute organizationCreation : OrganizationCreation to organizationUpdater : OrganizationUpdater in class org.sonar.server.user.UserUpdater	From	To
Rename Attribute organizationCreation : OrganizationCreation to organizationUpdater : OrganizationUpdater in class org.sonar.server.user.ws.CreateActionTest	From	To
Rename Attribute dbTester : DbTester to db : DbTester in class org.sonar.db.organization.OrganizationDaoTest	From	To
Change Attribute Type	13
Change Attribute Type underTest : OAuth2AuthenticationParametersImpl to underTest : OAuth2AuthenticationParameters in class org.sonar.server.authentication.OAuth2AuthenticationParametersImplTest	From	To
Change Attribute Type userIdentityAuthenticator : UserIdentityAuthenticator to userIdentityAuthenticator : UserIdentityAuthenticatorImpl in class org.sonar.server.authentication.SsoAuthenticatorTest	From	To
Change Attribute Type organizationCreation : OrganizationCreation to organizationUpdater : OrganizationUpdater in class org.sonar.server.organization.ws.CreateAction	From	To
Change Attribute Type userIdentityAuthenticator : UserIdentityAuthenticator to userIdentityAuthenticator : TestUserIdentityAuthenticator in class org.sonar.server.authentication.RealmAuthenticatorTest	From	To
Change Attribute Type userIdentityAuthenticator : UserIdentityAuthenticator to userIdentityAuthenticator : TestUserIdentityAuthenticator in class org.sonar.server.authentication.OAuth2ContextFactoryTest	From	To
Change Attribute Type FULL_POPULATED_NEW_ORGANIZATION : OrganizationCreation.NewOrganization to FULL_POPULATED_NEW_ORGANIZATION : OrganizationUpdater.NewOrganization in class org.sonar.server.organization.OrganizationUpdaterImplTest	From	To
Change Attribute Type organizationCreation : OrganizationCreation to organizationUpdater : OrganizationUpdater in class org.sonar.server.user.UserUpdater	From	To
Change Attribute Type organizationCreation : OrganizationCreation to organizationUpdater : OrganizationUpdater in class org.sonar.server.user.ws.CreateActionTest	From	To
Change Attribute Type underTest : UserIdentityAuthenticator to underTest : UserIdentityAuthenticatorImpl in class org.sonar.server.authentication.UserIdentityAuthenticatorImplTest	From	To
Change Attribute Type ORGANIZATION_CREATION_NOT_USED_FOR_UPDATE : OrganizationCreation to ORGANIZATION_CREATION_NOT_USED_FOR_UPDATE : OrganizationUpdater in class org.sonar.server.user.ws.UpdateActionTest	From	To
Change Attribute Type organizationCreation : OrganizationCreation to organizationUpdater : OrganizationUpdater in class org.sonar.server.user.UserUpdaterCreateTest	From	To
Change Attribute Type userIdentityAuthenticator : UserIdentityAuthenticator to userIdentityAuthenticator : TestUserIdentityAuthenticator in class org.sonar.server.authentication.BaseContextFactoryTest	From	To
Change Attribute Type underTest : OrganizationCreationImpl to underTest : OrganizationUpdaterImpl in class org.sonar.server.organization.OrganizationUpdaterImplTest	From	To
Rename Parameter	2
Rename Parameter organizationCreation : OrganizationCreation to organizationUpdater : OrganizationUpdater in method public UserUpdater(newUserNotifier NewUserNotifier, dbClient DbClient, userIndexer UserIndexer, organizationFlags OrganizationFlags, defaultOrganizationProvider DefaultOrganizationProvider, organizationUpdater OrganizationUpdater, defaultGroupFinder DefaultGroupFinder, config Configuration, localAuthentication LocalAuthentication) in class org.sonar.server.user.UserUpdater	From	To
Rename Parameter organizationCreation : OrganizationCreation to organizationUpdater : OrganizationUpdater in method public CreateAction(config Configuration, userSession UserSession, dbClient DbClient, wsSupport OrganizationsWsSupport, organizationValidation OrganizationValidation, organizationUpdater OrganizationUpdater, organizationFlags OrganizationFlags) in class org.sonar.server.organization.ws.CreateAction	From	To

7a894686606925522e1a6d8b01c7c2fc092200c9

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: