7bcccf0899d7bfa9f4d1782b4f5699c1f896502f
Files Diff
- Added: 3
- Removed: 1
- Renamed: 0
- Modified: 29
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 3 | ||
| Rename Method public shouldReturnDispatcherList() : void renamed to public getDispatchers() : void in class org.sonar.server.notifications.NotificationServiceTest | From | To | |
| Rename Method package issuesWithSeverity(severity String) : int renamed to public countIssuesWithSeverity(severity String) : int in class org.sonar.server.issue.notification.NewIssuesNotification.Stats | From | To | |
| Rename Method public shouldReturnNoDispatcher() : void renamed to public getDispatchers_empty() : void in class org.sonar.server.notifications.NotificationServiceTest | From | To | |
| Move And Rename Method | 1 | ||
| Move And Rename Method public new_issue_statistics() : void from class org.sonar.server.computation.step.SendIssueNotificationsStepTest to public stats() : void from class org.sonar.server.issue.notification.NewIssuesNotificationTest | From | To | |
| Change Parameter Type | 3 | ||
| Change Parameter Type service : IssueNotifications to service : NotificationService in method public SendIssueNotificationsStep(issueCache IssueCache, rules RuleCache, service NotificationService) in class org.sonar.server.computation.step.SendIssueNotificationsStep | From | To | |
| Change Parameter Type issueNotifications : IssueNotifications to notificationService : NotificationManager in method public IssueBulkChangeService(dbClient DbClient, issueService IssueService, issueStorage IssueStorage, ruleFinder DefaultRuleFinder, notificationService NotificationManager, actions List<Action>) in class org.sonar.server.issue.IssueBulkChangeService | From | To | |
| Change Parameter Type issueNotifications : IssueNotifications to notificationService : NotificationManager in method public IssueService(dbClient DbClient, indexClient IndexClient, workflow IssueWorkflow, issueStorage IssueStorage, issueUpdater IssueUpdater, notificationService NotificationManager, actionPlanService ActionPlanService, ruleFinder RuleFinder, deprecatedIssueDao IssueDao, userFinder UserFinder, userIndex UserIndex, sourceLineIndex SourceLineIndex) in class org.sonar.server.issue.IssueService | From | To | |
| Rename Variable | 1 | ||
| Rename Variable newIssuesStatistics : NewIssuesStatistics to newIssueStats : NewIssuesNotification.Stats in method private doExecute(context ComputationContext) : void in class org.sonar.server.computation.step.SendIssueNotificationsStep | From | To | |
| Move And Rename Class | 1 | ||
| Move And Rename Class org.sonar.server.computation.step.SendIssueNotificationsStep.NewIssuesStatistics moved and renamed to org.sonar.server.issue.notification.NewIssuesNotification.Stats | From | To | |
| Rename Attribute | 5 | ||
| Rename Attribute issueNotifications : IssueNotifications to notificationService : NotificationManager in class org.sonar.server.issue.IssueBulkChangeService | From | To | |
| Rename Attribute issueNotifications : IssueNotifications to notificationService : NotificationManager in class org.sonar.server.issue.IssueService | From | To | |
| Rename Attribute issueNotifications : IssueNotifications to notificationService : NotificationManager in class org.sonar.server.issue.IssueBulkChangeServiceTest | From | To | |
| Rename Attribute commentOnReviewAssignedToMe : NotificationDispatcher to commentOnIssueAssignedToMe : NotificationDispatcher in class org.sonar.server.notifications.NotificationServiceTest | From | To | |
| Rename Attribute commentOnReviewCreatedByMe : NotificationDispatcher to commentOnIssueCreatedByMe : NotificationDispatcher in class org.sonar.server.notifications.NotificationServiceTest | From | To | |
| Change Variable Type | 1 | ||
| Change Variable Type newIssuesStatistics : NewIssuesStatistics to newIssueStats : NewIssuesNotification.Stats in method private doExecute(context ComputationContext) : void in class org.sonar.server.computation.step.SendIssueNotificationsStep | From | To | |
| Extract Method | 1 | ||
| Extract Method private doExecute(context ComputationContext) : void extracted from public execute(context ComputationContext) : void in class org.sonar.server.computation.step.SendIssueNotificationsStep | From | To | |
| Change Attribute Type | 5 | ||
| Change Attribute Type service : IssueNotifications to service : NotificationService in class org.sonar.server.computation.step.SendIssueNotificationsStep | From | To | |
| Change Attribute Type issueNotifications : IssueNotifications to notificationService : NotificationManager in class org.sonar.server.issue.IssueBulkChangeServiceTest | From | To | |
| Change Attribute Type dispatchers : NotificationDispatcher[] to dispatchers : List<NotificationDispatcher> in class org.sonar.server.notifications.NotificationService | From | To | |
| Change Attribute Type issueNotifications : IssueNotifications to notificationService : NotificationManager in class org.sonar.server.issue.IssueService | From | To | |
| Change Attribute Type issueNotifications : IssueNotifications to notificationService : NotificationManager in class org.sonar.server.issue.IssueBulkChangeService | From | To | |
| Rename Parameter | 2 | ||
| Rename Parameter issueNotifications : IssueNotifications to notificationService : NotificationManager in method public IssueBulkChangeService(dbClient DbClient, issueService IssueService, issueStorage IssueStorage, ruleFinder DefaultRuleFinder, notificationService NotificationManager, actions List<Action>) in class org.sonar.server.issue.IssueBulkChangeService | From | To | |
| Rename Parameter issueNotifications : IssueNotifications to notificationService : NotificationManager in method public IssueService(dbClient DbClient, indexClient IndexClient, workflow IssueWorkflow, issueStorage IssueStorage, issueUpdater IssueUpdater, notificationService NotificationManager, actionPlanService ActionPlanService, ruleFinder RuleFinder, deprecatedIssueDao IssueDao, userFinder UserFinder, userIndex UserIndex, sourceLineIndex SourceLineIndex) in class org.sonar.server.issue.IssueService | From | To |