sonarqube 7c58e989e8bd977b06b0e57aa7e6cf548c34e34a

7c58e989e8bd977b06b0e57aa7e6cf548c34e34a

Files Diff

Added: 5
Removed: 0
Renamed: 0
Modified: 7

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Rename Method	2
Rename Method public start_creates_different_qp_and_their_loaded_templates_if_several_profile_has_same_name_for_different_languages() : void renamed to public start_creates_different_qps_and_their_loaded_templates_if_several_profile_has_same_name_for_different_languages() : void in class org.sonar.server.qualityprofile.RegisterQualityProfilesTest	From	To
Rename Method public start_creates_qp_if_language_exists_and_store_flag_in_loaded_templates_for_each_organization_id_BD() : void renamed to public start_creates_qp_and_store_flag_in_loaded_templates_for_each_organization_id_BD() : void in class org.sonar.server.qualityprofile.RegisterQualityProfilesTest	From	To
Move And Rename Method	3
Move And Rename Method public start_fails_with_ISE_when_two_sq_with_different_name_are_default_for_the_same_language() : void from class org.sonar.server.qualityprofile.RegisterQualityProfilesTest to public initialize_fails_with_ISE_when_two_sq_with_different_name_are_default_for_the_same_language() : void from class org.sonar.server.qualityprofile.DefinedQProfileRepositoryImplTest	From	To
Move And Rename Method public start_throws_IAE_if_profileDefinition_creates_RulesProfile_with_null_name() : void from class org.sonar.server.qualityprofile.RegisterQualityProfilesTest to public initialize_throws_IAE_if_profileDefinition_creates_RulesProfile_with_null_name() : void from class org.sonar.server.qualityprofile.DefinedQProfileRepositoryImplTest	From	To
Move And Rename Method public start_throws_IAE_if_profileDefinition_creates_RulesProfile_with_empty_name() : void from class org.sonar.server.qualityprofile.RegisterQualityProfilesTest to public initialize_throws_IAE_if_profileDefinition_creates_RulesProfile_with_empty_name() : void from class org.sonar.server.qualityprofile.DefinedQProfileRepositoryImplTest	From	To
Change Parameter Type	7
Change Parameter Type existingBuilder : QualityProfile.Builder to existingBuilder : DefinedQProfile.Builder in method private updateOrCreateBuilder(language String, existingBuilder DefinedQProfile.Builder, rulesProfile RulesProfile, name String) : DefinedQProfile.Builder in class org.sonar.server.qualityprofile.DefinedQProfileRepositoryImpl	From	To
Change Parameter Type qualityProfiles : List<QualityProfile> to qualityProfiles : List<DefinedQProfile> in method private registerPerLanguage(session DbSession, qualityProfiles List<DefinedQProfile>, changes List<ActiveRuleChange>) : void in class org.sonar.server.qualityprofile.RegisterQualityProfiles	From	To
Change Parameter Type qualityProfile : QualityProfile to qualityProfile : DefinedQProfile in method private registerPerQualityProfileAndOrganization(session DbSession, qualityProfile DefinedQProfile, organization OrganizationDto, changes List<ActiveRuleChange>) : void in class org.sonar.server.qualityprofile.RegisterQualityProfiles	From	To
Change Parameter Type builders : List<QualityProfile.Builder> to builders : List<DefinedQProfile.Builder> in method private toQualityProfiles(builders List<DefinedQProfile.Builder>) : List<DefinedQProfile> in class org.sonar.server.qualityprofile.DefinedQProfileRepositoryImpl	From	To
Change Parameter Type entry : Map.Entry<String,List<QualityProfile.Builder>> to entry : Map.Entry<String,List<DefinedQProfile.Builder>> in method private ensureAtMostOneDeclaredDefault(entry Map.Entry<String,List<DefinedQProfile.Builder>>) : boolean in class org.sonar.server.qualityprofile.DefinedQProfileRepositoryImpl	From	To
Change Parameter Type qualityProfile : QualityProfile to qualityProfile : DefinedQProfile in method private getOrganizationsWithoutQP(session DbSession, qualityProfile DefinedQProfile) : List<OrganizationDto> in class org.sonar.server.qualityprofile.RegisterQualityProfiles	From	To
Change Parameter Type qualityProfile : QualityProfile to qualityProfile : DefinedQProfile in method private registerPerQualityProfile(session DbSession, qualityProfile DefinedQProfile, changes List<ActiveRuleChange>) : void in class org.sonar.server.qualityprofile.RegisterQualityProfiles	From	To
Move Method	7
Move Method private buildRulesProfilesByLanguage() : ListMultimap<String,RulesProfile> from class org.sonar.server.qualityprofile.RegisterQualityProfiles to private buildRulesProfilesByLanguage() : ListMultimap<String,RulesProfile> from class org.sonar.server.qualityprofile.DefinedQProfileRepositoryImpl	From	To
Move Method private toQualityProfilesByLanguage(rulesProfilesByLanguage ListMultimap<String,RulesProfile>) : Map<String,List<QualityProfile>> from class org.sonar.server.qualityprofile.RegisterQualityProfiles to private toQualityProfilesByLanguage(rulesProfilesByLanguage ListMultimap<String,RulesProfile>) : Map<String,List<DefinedQProfile>> from class org.sonar.server.qualityprofile.DefinedQProfileRepositoryImpl	From	To
Move Method private toQualityProfileBuilders(rulesProfilesByLanguage Map.Entry<String,List<RulesProfile>>) : List<QualityProfile.Builder> from class org.sonar.server.qualityprofile.RegisterQualityProfiles to private toQualityProfileBuilders(rulesProfilesByLanguage Map.Entry<String,List<RulesProfile>>) : List<DefinedQProfile.Builder> from class org.sonar.server.qualityprofile.DefinedQProfileRepositoryImpl	From	To
Move Method private validateAndClean(byLang ListMultimap<String,RulesProfile>) : void from class org.sonar.server.qualityprofile.RegisterQualityProfiles to private validateAndClean(byLang ListMultimap<String,RulesProfile>) : void from class org.sonar.server.qualityprofile.DefinedQProfileRepositoryImpl	From	To
Move Method private ensureAtMostOneDeclaredDefault(entry Map.Entry<String,List<QualityProfile.Builder>>) : boolean from class org.sonar.server.qualityprofile.RegisterQualityProfiles to private ensureAtMostOneDeclaredDefault(entry Map.Entry<String,List<DefinedQProfile.Builder>>) : boolean from class org.sonar.server.qualityprofile.DefinedQProfileRepositoryImpl	From	To
Move Method private updateOrCreateBuilder(language String, existingBuilder QualityProfile.Builder, rulesProfile RulesProfile, name String) : QualityProfile.Builder from class org.sonar.server.qualityprofile.RegisterQualityProfiles to private updateOrCreateBuilder(language String, existingBuilder DefinedQProfile.Builder, rulesProfile RulesProfile, name String) : DefinedQProfile.Builder from class org.sonar.server.qualityprofile.DefinedQProfileRepositoryImpl	From	To
Move Method private toQualityProfiles(builders List<QualityProfile.Builder>) : List<QualityProfile> from class org.sonar.server.qualityprofile.RegisterQualityProfiles to private toQualityProfiles(builders List<DefinedQProfile.Builder>) : List<DefinedQProfile> from class org.sonar.server.qualityprofile.DefinedQProfileRepositoryImpl	From	To
Change Return Type	4
Change Return Type Map<String,List<QualityProfile>> to Map<String,List<DefinedQProfile>> in method private toQualityProfilesByLanguage(rulesProfilesByLanguage ListMultimap<String,RulesProfile>) : Map<String,List<DefinedQProfile>> in class org.sonar.server.qualityprofile.DefinedQProfileRepositoryImpl	From	To
Change Return Type List<QualityProfile.Builder> to List<DefinedQProfile.Builder> in method private toQualityProfileBuilders(rulesProfilesByLanguage Map.Entry<String,List<RulesProfile>>) : List<DefinedQProfile.Builder> in class org.sonar.server.qualityprofile.DefinedQProfileRepositoryImpl	From	To
Change Return Type List<QualityProfile> to List<DefinedQProfile> in method private toQualityProfiles(builders List<DefinedQProfile.Builder>) : List<DefinedQProfile> in class org.sonar.server.qualityprofile.DefinedQProfileRepositoryImpl	From	To
Change Return Type QualityProfile.Builder to DefinedQProfile.Builder in method private updateOrCreateBuilder(language String, existingBuilder DefinedQProfile.Builder, rulesProfile RulesProfile, name String) : DefinedQProfile.Builder in class org.sonar.server.qualityprofile.DefinedQProfileRepositoryImpl	From	To
Move Attribute	4
Move Attribute private languages : Languages from class org.sonar.server.qualityprofile.RegisterQualityProfiles to private languages : Languages from class org.sonar.server.qualityprofile.DefinedQProfileRepositoryImpl	From	To
Move Attribute private SONAR_WAY_QP_NAME : String from class org.sonar.server.qualityprofile.RegisterQualityProfilesTest to private SONAR_WAY_QP_NAME : String from class org.sonar.server.qualityprofile.DefinedQProfileRepositoryImplTest	From	To
Move Attribute private DEFAULT_PROFILE_NAME : String from class org.sonar.server.qualityprofile.RegisterQualityProfiles to private DEFAULT_PROFILE_NAME : String from class org.sonar.server.qualityprofile.DefinedQProfileRepositoryImpl	From	To
Move Attribute private definitions : List<ProfileDefinition> from class org.sonar.server.qualityprofile.RegisterQualityProfiles to private definitions : List<ProfileDefinition> from class org.sonar.server.qualityprofile.DefinedQProfileRepositoryImpl	From	To
Extract Class	1
Extract Class org.sonar.server.qualityprofile.DefinedQProfileRepositoryImpl from class org.sonar.server.qualityprofile.RegisterQualityProfiles	From	To
Move And Rename Class	1
Move And Rename Class org.sonar.server.qualityprofile.RegisterQualityProfiles.QualityProfile moved and renamed to org.sonar.server.qualityprofile.DefinedQProfile	From	To
Move Class	1
Move Class org.sonar.server.qualityprofile.RegisterQualityProfilesTest.DummyProfileDefinition moved to org.sonar.server.qualityprofile.DefinedQProfileRepositoryImplTest.DummyProfileDefinition	From	To
Rename Attribute	1
Rename Attribute definitions : List<ProfileDefinition> to definedQProfileRepository : DefinedQProfileRepository in class org.sonar.server.qualityprofile.RegisterQualityProfiles	From	To
Change Attribute Type	1
Change Attribute Type definitions : List<ProfileDefinition> to definedQProfileRepository : DefinedQProfileRepository in class org.sonar.server.qualityprofile.RegisterQualityProfiles	From	To

7c58e989e8bd977b06b0e57aa7e6cf548c34e34a

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: