7cb96cec759e48ddf167d30d122ddd6c1d2d3ae2
Files Diff
- Added: 13
- Removed: 0
- Renamed: 0
- Modified: 18
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Pull Up Method | 8 | ||
| Pull Up Method private downloadRelease(release Release) : void from class org.sonar.server.plugins.PluginDownloader to private downloadRelease(release Release) : void from class org.sonar.server.plugins.AbstractPluginDownloader | From | To | |
| Pull Up Method public hasDownloads() : boolean from class org.sonar.server.plugins.PluginDownloader to package hasDownloads() : boolean from class org.sonar.server.plugins.AbstractPluginDownloader | From | To | |
| Pull Up Method public getDownloadedPlugins() : Collection<PluginInfo> from class org.sonar.server.plugins.PluginDownloader to public getDownloadedPlugins() : Collection<PluginInfo> from class org.sonar.server.plugins.AbstractPluginDownloader | From | To | |
| Pull Up Method public cancelDownloads() : void from class org.sonar.server.plugins.PluginDownloader to public cancelDownloads() : void from class org.sonar.server.plugins.AbstractPluginDownloader | From | To | |
| Pull Up Method public start() : void from class org.sonar.server.plugins.PluginDownloader to public start() : void from class org.sonar.server.plugins.AbstractPluginDownloader | From | To | |
| Pull Up Method public getDownloadedPluginFilenames() : List<String> from class org.sonar.server.plugins.PluginDownloader to package getDownloadedPluginFilenames() : List<String> from class org.sonar.server.plugins.AbstractPluginDownloader | From | To | |
| Pull Up Method public stop() : void from class org.sonar.server.plugins.PluginDownloader to public stop() : void from class org.sonar.server.plugins.AbstractPluginDownloader | From | To | |
| Pull Up Method private listPlugins(dir File) : Collection<File> from class org.sonar.server.plugins.PluginDownloader to private listPlugins(dir File) : Collection<File> from class org.sonar.server.plugins.AbstractPluginDownloader | From | To | |
| Change Parameter Type | 2 | ||
| Change Parameter Type pluginRepository : ServerPluginRepository to pluginUninstaller : PluginUninstaller in method public CancelAllAction(pluginDownloader PluginDownloader, pluginUninstaller PluginUninstaller, userSession UserSession) in class org.sonar.server.plugins.ws.CancelAllAction | From | To | |
| Change Parameter Type pluginRepository : ServerPluginRepository to pluginUninstaller : PluginUninstaller in method public UninstallAction(pluginUninstaller PluginUninstaller, userSession UserSession) in class org.sonar.server.plugins.ws.UninstallAction | From | To | |
| Move Method | 2 | ||
| Move Method private ensurePluginIsInstalled(key String) : void from class org.sonar.server.plugins.ws.UninstallAction to private ensurePluginIsInstalled(key String) : void from class org.sonar.server.plugins.AbstractPluginUninstaller | From | To | |
| Move Method public getUninstalledPlugins() : Collection<PluginInfo> from class org.sonar.server.plugins.ServerPluginRepository to public getUninstalledPlugins() : Collection<PluginInfo> from class org.sonar.server.plugins.AbstractPluginUninstaller | From | To | |
| Pull Up Attribute | 5 | ||
| Pull Up Attribute private TMP_SUFFIX : String from class org.sonar.server.plugins.PluginDownloader to private TMP_SUFFIX : String from class org.sonar.server.plugins.AbstractPluginDownloader | From | To | |
| Pull Up Attribute private downloadDir : File from class org.sonar.server.plugins.PluginDownloader to private downloadDir : File from class org.sonar.server.plugins.AbstractPluginDownloader | From | To | |
| Pull Up Attribute private LOG : Logger from class org.sonar.server.plugins.PluginDownloader to private LOG : Logger from class org.sonar.server.plugins.AbstractPluginDownloader | From | To | |
| Pull Up Attribute private downloader : HttpDownloader from class org.sonar.server.plugins.PluginDownloader to private downloader : HttpDownloader from class org.sonar.server.plugins.AbstractPluginDownloader | From | To | |
| Pull Up Attribute private PLUGIN_EXTENSION : String from class org.sonar.server.plugins.PluginDownloader to private PLUGIN_EXTENSION : String from class org.sonar.server.plugins.AbstractPluginDownloader | From | To | |
| Extract Superclass | 1 | ||
| Extract Superclass org.sonar.server.plugins.AbstractPluginDownloader from classes [org.sonar.server.plugins.PluginDownloader] | From | To | |
| Rename Attribute | 4 | ||
| Rename Attribute pluginRepository : ServerPluginRepository to pluginUninstaller : PluginUninstaller in class org.sonar.server.plugins.ws.UninstallAction | From | To | |
| Rename Attribute pluginRepository : ServerPluginRepository to pluginUninstaller : PluginUninstaller in class org.sonar.server.plugins.ws.CancelAllActionTest | From | To | |
| Rename Attribute pluginRepository : ServerPluginRepository to pluginUninstaller : PluginUninstaller in class org.sonar.server.plugins.ws.UninstallActionTest | From | To | |
| Rename Attribute pluginRepository : ServerPluginRepository to pluginUninstaller : PluginUninstaller in class org.sonar.server.plugins.ws.CancelAllAction | From | To | |
| Extract Method | 1 | ||
| Extract Method protected cleanTempFiles() : void extracted from public start() : void in class org.sonar.server.plugins.AbstractPluginDownloader | From | To | |
| Change Attribute Type | 4 | ||
| Change Attribute Type pluginRepository : ServerPluginRepository to pluginUninstaller : PluginUninstaller in class org.sonar.server.plugins.ws.UninstallAction | From | To | |
| Change Attribute Type pluginRepository : ServerPluginRepository to pluginUninstaller : PluginUninstaller in class org.sonar.server.plugins.ws.CancelAllActionTest | From | To | |
| Change Attribute Type pluginRepository : ServerPluginRepository to pluginUninstaller : PluginUninstaller in class org.sonar.server.plugins.ws.UninstallActionTest | From | To | |
| Change Attribute Type pluginRepository : ServerPluginRepository to pluginUninstaller : PluginUninstaller in class org.sonar.server.plugins.ws.CancelAllAction | From | To | |
| Rename Parameter | 2 | ||
| Rename Parameter pluginRepository : ServerPluginRepository to pluginUninstaller : PluginUninstaller in method public CancelAllAction(pluginDownloader PluginDownloader, pluginUninstaller PluginUninstaller, userSession UserSession) in class org.sonar.server.plugins.ws.CancelAllAction | From | To | |
| Rename Parameter pluginRepository : ServerPluginRepository to pluginUninstaller : PluginUninstaller in method public UninstallAction(pluginUninstaller PluginUninstaller, userSession UserSession) in class org.sonar.server.plugins.ws.UninstallAction | From | To |