803439a16e9b40da4ad9a5baa9cd84a407c607b5
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 27
Refactorings reported:
Refactoring Name | Occurences | ||
---|---|---|---|
Merge Attribute | 1 | ||
Merge Attribute [notificationQueueDao : NotificationQueueDao, propertiesDao : PropertiesDao] to dbClient : DbClient in class org.sonar.server.notification.DefaultNotificationManagerTest | From | To | |
Rename Method | 2 | ||
Rename Method public selectUsersForNotification(notificationDispatcherKey String, notificationChannelKey String, projectUuid String) : List<String> renamed to public findUsersForNotification(notificationDispatcherKey String, notificationChannelKey String, projectUuid String) : Set<String> in class org.sonar.db.property.PropertiesDao | From | To | |
Rename Method private insertProject(uuid String) : ComponentDto renamed to private insertPrivateProject(uuid String) : ComponentDto in class org.sonar.db.property.PropertiesDaoTest | From | To | |
Change Parameter Type | 1 | ||
Change Parameter Type users : List<String> to users : Collection<String> in method private addUsersToRecipientListForChannel(users Collection<String>, recipients SetMultimap<String,NotificationChannel>, channel NotificationChannel) : void in class org.sonar.server.notification.DefaultNotificationManager | From | To | |
Rename Variable | 7 | ||
Rename Variable projectKey : String to projectUuid : String in method public dispatch(notification Notification, context Context) : void in class org.sonar.server.issue.notification.DoNotFixNotificationDispatcher | From | To | |
Rename Variable projectKey : String to projectUuid : String in method public dispatch(notification Notification, context Context) : void in class org.sonar.server.issue.notification.NewIssuesNotificationDispatcher | From | To | |
Rename Variable userId3 : int to user3 : UserDto in method public shouldFindUsersForNotification() : void in class org.sonar.db.property.PropertiesDaoTest | From | To | |
Rename Variable userId2 : int to user2 : UserDto in method public shouldFindUsersForNotification() : void in class org.sonar.db.property.PropertiesDaoTest | From | To | |
Rename Variable userId1 : int to user1 : UserDto in method public shouldFindUsersForNotification() : void in class org.sonar.db.property.PropertiesDaoTest | From | To | |
Rename Variable projectKey : String to projectUuid : String in method public dispatch(notification Notification, context Context) : void in class org.sonar.server.issue.notification.ChangesOnMyIssueNotificationDispatcher | From | To | |
Rename Variable projectKey : String to projectUuid : String in method public dispatch(notification Notification, context Context) : void in class org.sonar.server.issue.notification.MyNewIssuesNotificationDispatcher | From | To | |
Change Return Type | 3 | ||
Change Return Type List<String> to Set<String> in method public findUsersForNotification(notificationKey String, projectUuid String) : Set<String> in class org.sonar.db.property.PropertiesMapper | From | To | |
Change Return Type List<String> to Set<String> in method public findUsersForNotification(notificationDispatcherKey String, notificationChannelKey String, projectUuid String) : Set<String> in class org.sonar.db.property.PropertiesDao | From | To | |
Change Return Type int to UserDto in method private insertUser(login String) : UserDto in class org.sonar.db.property.PropertiesDaoTest | From | To | |
Rename Attribute | 1 | ||
Rename Attribute manager : DefaultNotificationManager to underTest : DefaultNotificationManager in class org.sonar.server.notification.DefaultNotificationManagerTest | From | To | |
Change Variable Type | 3 | ||
Change Variable Type userId2 : int to user2 : UserDto in method public shouldFindUsersForNotification() : void in class org.sonar.db.property.PropertiesDaoTest | From | To | |
Change Variable Type userId1 : int to user1 : UserDto in method public shouldFindUsersForNotification() : void in class org.sonar.db.property.PropertiesDaoTest | From | To | |
Change Variable Type userId3 : int to user3 : UserDto in method public shouldFindUsersForNotification() : void in class org.sonar.db.property.PropertiesDaoTest | From | To |