90f74707a9248d3041c98cf7791de936cdc901f8
Files Diff
- Added: 3
- Removed: 2
- Renamed: 0
- Modified: 20
Refactorings reported:
Refactoring Name | Occurences | ||
---|---|---|---|
Change Parameter Type | 1 | ||
Change Parameter Type service : IssueFilterService to dbClient : DbClient in method public SearchAction(dbClient DbClient, userSession UserSession) in class org.sonar.server.issue.filter.SearchAction | From | To | |
Rename Variable | 1 | ||
Rename Variable sharedFiltersWithoutUserFilters : List<IssueFilterDto> to sharedFilters : List<IssueFilterDto> in method private searchIssueFilters(dbSession DbSession) : Set<IssueFilterDto> in class org.sonar.server.issue.filter.SearchAction | From | To | |
Merge Parameter | 1 | ||
Merge Parameter [filterDao : IssueFilterDao, favouriteDao : IssueFilterFavouriteDao, authorizationDao : AuthorizationDao] to dbClient : DbClient in method public IssueFilterService(dbClient DbClient, issueIndex IssueIndex, serializer IssueFilterSerializer) in class org.sonar.server.issue.filter.IssueFilterService | From | To | |
Rename Attribute | 4 | ||
Rename Attribute tester : WsTester to ws : WsTester in class org.sonar.server.issue.filter.AppActionTest | From | To | |
Rename Attribute service : IssueFilterService to dbClient : DbClient in class org.sonar.server.issue.filter.SearchAction | From | To | |
Rename Attribute service : IssueFilterService to underTest : IssueFilterService in class org.sonar.server.issue.filter.IssueFilterServiceTest | From | To | |
Rename Attribute action : AppAction to underTest : AppAction in class org.sonar.server.issue.filter.AppActionTest | From | To | |
Change Variable Type | 6 | ||
Change Variable Type session : SqlSession to session : DbSession in method public selectSharedFilters() : List<IssueFilterDto> in class org.sonar.db.issue.IssueFilterDao | From | To | |
Change Variable Type session : SqlSession to session : DbSession in method public delete(id long) : void in class org.sonar.db.issue.IssueFilterDao | From | To | |
Change Variable Type session : SqlSession to session : DbSession in method public insert(filter IssueFilterDto) : void in class org.sonar.db.issue.IssueFilterDao | From | To | |
Change Variable Type session : SqlSession to session : DbSession in method public insert(filter IssueFilterFavouriteDto) : void in class org.sonar.db.issue.IssueFilterFavouriteDao | From | To | |
Change Variable Type session : SqlSession to session : DbSession in method public selectByUser(user String) : List<IssueFilterDto> in class org.sonar.db.issue.IssueFilterDao | From | To | |
Change Variable Type session : SqlSession to session : DbSession in method public update(filter IssueFilterDto) : void in class org.sonar.db.issue.IssueFilterDao | From | To | |
Change Attribute Type | 3 | ||
Change Attribute Type service : IssueFilterService to dbClient : DbClient in class org.sonar.server.issue.filter.SearchAction | From | To | |
Change Attribute Type ws : WsTester to ws : WsActionTester in class org.sonar.server.issue.filter.SearchActionTest | From | To | |
Change Attribute Type ws : IssueFilterWs to ws : WsTester in class org.sonar.server.issue.filter.IssueFilterWsTest | From | To | |
Extract Method | 6 | ||
Extract Method public selectSharedFilters(session DbSession) : List<IssueFilterDto> extracted from public selectSharedFilters() : List<IssueFilterDto> in class org.sonar.db.issue.IssueFilterDao | From | To | |
Extract Method public insert(session DbSession, filter IssueFilterDto) : IssueFilterDto extracted from public insert(filter IssueFilterDto) : void in class org.sonar.db.issue.IssueFilterDao | From | To | |
Extract Method public selectByUser(session DbSession, user String) : List<IssueFilterDto> extracted from public selectByUser(user String) : List<IssueFilterDto> in class org.sonar.db.issue.IssueFilterDao | From | To | |
Extract Method public insert(session DbSession, filter IssueFilterFavouriteDto) : void extracted from public insert(filter IssueFilterFavouriteDto) : void in class org.sonar.db.issue.IssueFilterFavouriteDao | From | To | |
Extract Method private searchIssueFilters(dbSession DbSession) : Set<IssueFilterDto> extracted from public handle(request Request, response Response) : void in class org.sonar.server.issue.filter.SearchAction | From | To | |
Extract Method private writeResponse(response Response, issueFilters Set<IssueFilterDto>, userFavouritesByFilterId Map<Long,IssueFilterFavouriteDto>) : void extracted from public handle(request Request, response Response) : void in class org.sonar.server.issue.filter.SearchAction | From | To | |
Rename Parameter | 1 | ||
Rename Parameter service : IssueFilterService to dbClient : DbClient in method public SearchAction(dbClient DbClient, userSession UserSession) in class org.sonar.server.issue.filter.SearchAction | From | To |