a79d83f7ee9092352cd4581caccf6a1b269935a9
Files Diff
- Added: 0
- Removed: 1
- Renamed: 0
- Modified: 11
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Move And Rename Method | 2 | ||
| Move And Rename Method private tryToResolveByDays(property String) : Integer from class org.sonar.ce.task.projectanalysis.step.PeriodResolver to private parseDaysQuietly(property String) : Integer from class org.sonar.ce.task.projectanalysis.step.LoadPeriodsStep | From | To | |
| Move And Rename Method private formatDate(date long) : String from class org.sonar.ce.task.projectanalysis.step.PeriodResolver to private logDate(date1 Date) : String from class org.sonar.ce.task.projectanalysis.step.LoadPeriodsStep | From | To | |
| Change Parameter Type | 1 | ||
| Change Parameter Type date : long to date1 : Date in method private logDate(date1 Date) : String in class org.sonar.ce.task.projectanalysis.step.LoadPeriodsStep | From | To | |
| Move Method | 2 | ||
| Move Method private createCommonQuery(projectUuid String) : SnapshotQuery from class org.sonar.ce.task.projectanalysis.step.PeriodResolver to private createCommonQuery(projectUuid String) : SnapshotQuery from class org.sonar.ce.task.projectanalysis.step.LoadPeriodsStep | From | To | |
| Move Method private findNearestSnapshotToTargetDate(snapshots List<SnapshotDto>, targetDate Long) : SnapshotDto from class org.sonar.ce.task.projectanalysis.step.PeriodResolver to private findNearestSnapshotToTargetDate(snapshots List<SnapshotDto>, targetDate Long) : SnapshotDto from class org.sonar.ce.task.projectanalysis.step.LoadPeriodsStep | From | To | |
| Change Variable Type | 2 | ||
| Change Variable Type configurationRepositoryMock : ConfigurationRepository to system2Mock : System2 in method public no_period_on_first_analysis_and_execute_has_no_effect() : void in class org.sonar.ce.task.projectanalysis.step.LoadPeriodsStepTest | From | To | |
| Change Variable Type dto : SnapshotDto to dto : Optional<SnapshotDto> in method public select_first_snapshots() : void in class org.sonar.db.component.SnapshotDaoTest | From | To | |
| Extract Variable | 1 | ||
| Extract Variable propertyValue : String in method public fail_with_MessageException_if_period_is_today_but_no_analysis_today() : void from class org.sonar.ce.task.projectanalysis.step.LoadPeriodsStepTest | From | To | |
| Extract Method | 3 | ||
| Extract Method private verifyFailWithInvalidValueMessageException(propertyValue String, debugLog String, otherDebugLogs String...) : void extracted from public no_period_when_settings_match_no_analysis() : void in class org.sonar.ce.task.projectanalysis.step.LoadPeriodsStepTest | From | To | |
| Extract Method private verifyFailWithInvalidValueMessageException(propertyValue String, debugLog String, otherDebugLogs String...) : void extracted from public no_period_when_settings_is_empty() : void in class org.sonar.ce.task.projectanalysis.step.LoadPeriodsStepTest | From | To | |
| Extract Method private verifyFailWithInvalidValueMessageException(propertyValue String, debugLog String, otherDebugLogs String...) : void extracted from public no_period_by_date() : void in class org.sonar.ce.task.projectanalysis.step.LoadPeriodsStepTest | From | To | |
| Rename Method | 5 | ||
| Rename Method public no_period_when_settings_is_empty() : void renamed to public fail_with_MessageException_if_period_is_date_after_today() : void in class org.sonar.ce.task.projectanalysis.step.LoadPeriodsStepTest | From | To | |
| Rename Method public no_period_by_date() : void renamed to public fail_with_MessageException_if_period_is_today_but_no_analysis_today() : void in class org.sonar.ce.task.projectanalysis.step.LoadPeriodsStepTest | From | To | |
| Rename Method public no_period_on_first_analysis() : void renamed to public no_period_on_first_analysis_and_execute_has_no_effect() : void in class org.sonar.ce.task.projectanalysis.step.LoadPeriodsStepTest | From | To | |
| Rename Method public no_period_when_settings_match_no_analysis() : void renamed to public fail_with_MessageException_if_date_does_not_exist() : void in class org.sonar.ce.task.projectanalysis.step.LoadPeriodsStepTest | From | To | |
| Rename Method public no_period_by_days() : void renamed to public fail_with_ISE_if_not_firstAnalysis_but_no_snapshot_in_DB(propertyValue String) : void in class org.sonar.ce.task.projectanalysis.step.LoadPeriodsStepTest | From | To | |
| Rename Variable | 1 | ||
| Rename Variable analysis5 : SnapshotDto to analysis2 : SnapshotDto in method public feed_period_by_previous_version_with_first_analysis_when_no_previous_version_found() : void in class org.sonar.ce.task.projectanalysis.step.LoadPeriodsStepTest | From | To | |
| Change Return Type | 1 | ||
| Change Return Type SnapshotDto to Optional<SnapshotDto> in method public selectOldestSnapshot(session DbSession, componentUuid String) : Optional<SnapshotDto> in class org.sonar.db.component.SnapshotDao | From | To | |
| Replace Variable With Attribute | 2 | ||
| Replace Variable With Attribute configurationRepositoryMock : ConfigurationRepository to system2Mock : System2 in method public no_period_on_first_analysis_and_execute_has_no_effect() : void in class org.sonar.ce.task.projectanalysis.step.LoadPeriodsStepTest | From | To | |
| Replace Variable With Attribute analysisMetadataHolderMock : AnalysisMetadataHolder to analysisMetadataHolder : AnalysisMetadataHolder in method public no_period_on_first_analysis_and_execute_has_no_effect() : void in class org.sonar.ce.task.projectanalysis.step.LoadPeriodsStepTest | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute settingsRepository : ConfigurationRepository to configurationRepository : ConfigurationRepository in class org.sonar.ce.task.projectanalysis.step.LoadPeriodsStepTest | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type analysisMetadataHolder : AnalysisMetadataHolderRule to analysisMetadataHolder : AnalysisMetadataHolder in class org.sonar.ce.task.projectanalysis.step.LoadPeriodsStepTest | From | To | |
| Rename Parameter | 2 | ||
| Rename Parameter configurationRepository : ConfigurationRepository to configRepository : ConfigurationRepository in method public LoadPeriodsStep(analysisMetadataHolder AnalysisMetadataHolder, treeRootHolder TreeRootHolder, periodsHolder PeriodHolderImpl, system2 System2, dbClient DbClient, configRepository ConfigurationRepository) in class org.sonar.ce.task.projectanalysis.step.LoadPeriodsStep | From | To | |
| Rename Parameter date : long to date1 : Date in method private logDate(date1 Date) : String in class org.sonar.ce.task.projectanalysis.step.LoadPeriodsStep | From | To |