af30430e1577d2284a1fce12f8a8a43652627461
Files Diff
- Added: 8
- Removed: 2
- Renamed: 0
- Modified: 27
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Extract Subclass | 1 | ||
| Extract Subclass org.sonar.server.computation.CeQueueImpl from class org.sonar.server.computation.CeQueue | From | To | |
| Change Parameter Type | 1 | ||
| Change Parameter Type taskSubmit : CeTaskSubmit to taskSubmit : TaskSubmission in method public save(taskSubmit TaskSubmission, reportInput InputStream) : void in class org.sonar.server.computation.ReportFiles | From | To | |
| Move Method | 6 | ||
| Move Method public clear_queue_if_version_upgrade() : void from class org.sonar.server.computation.CeQueueInitializerTest to public clear_queue_if_version_upgrade() : void from class org.sonar.server.computation.CeQueueCleanerTest | From | To | |
| Move Method public delete_orphan_report_files() : void from class org.sonar.server.computation.CeQueueInitializerTest to public delete_orphan_report_files() : void from class org.sonar.server.computation.CeQueueCleanerTest | From | To | |
| Move Method private cleanOnUpgrade() : void from class org.sonar.server.computation.CeQueueInitializer to private cleanOnUpgrade() : void from class org.sonar.server.computation.CeQueueCleaner | From | To | |
| Move Method public reset_in_progress_tasks_to_pending() : void from class org.sonar.server.computation.CeQueueInitializerTest to public reset_in_progress_tasks_to_pending() : void from class org.sonar.server.computation.CeQueueCleanerTest | From | To | |
| Move Method private verifyConsistency(dbSession DbSession) : void from class org.sonar.server.computation.CeQueueInitializer to private verifyConsistency(dbSession DbSession) : void from class org.sonar.server.computation.CeQueueCleaner | From | To | |
| Move Method public cancel_task_if_report_file_is_missing() : void from class org.sonar.server.computation.CeQueueInitializerTest to public cancel_task_if_report_file_is_missing() : void from class org.sonar.server.computation.CeQueueCleanerTest | From | To | |
| Push Down Attribute | 5 | ||
| Push Down Attribute private listeners : CeQueueListener[] from class org.sonar.server.computation.CeQueue to private listeners : CeQueueListener[] from class org.sonar.server.computation.CeQueueImpl | From | To | |
| Push Down Attribute private dbClient : DbClient from class org.sonar.server.computation.CeQueue to private dbClient : DbClient from class org.sonar.server.computation.CeQueueImpl | From | To | |
| Push Down Attribute private uuidFactory : UuidFactory from class org.sonar.server.computation.CeQueue to private uuidFactory : UuidFactory from class org.sonar.server.computation.CeQueueImpl | From | To | |
| Push Down Attribute private system2 : System2 from class org.sonar.server.computation.CeQueue to private system2 : System2 from class org.sonar.server.computation.CeQueueImpl | From | To | |
| Push Down Attribute private queueStatus : CEQueueStatus from class org.sonar.server.computation.CeQueue to private queueStatus : CEQueueStatus from class org.sonar.server.computation.CeQueueImpl | From | To | |
| Move Attribute | 4 | ||
| Move Attribute private LOGGER : Logger from class org.sonar.server.computation.CeQueueInitializer to private LOGGER : Logger from class org.sonar.server.computation.CeQueueCleaner | From | To | |
| Move Attribute private reportFiles : ReportFiles from class org.sonar.server.computation.CeQueueInitializer to private reportFiles : ReportFiles from class org.sonar.server.computation.CeQueueCleaner | From | To | |
| Move Attribute private serverUpgradeStatus : ServerUpgradeStatus from class org.sonar.server.computation.CeQueueInitializer to private serverUpgradeStatus : ServerUpgradeStatus from class org.sonar.server.computation.CeQueueCleaner | From | To | |
| Move Attribute package serverUpgradeStatus : ServerUpgradeStatus from class org.sonar.server.computation.CeQueueInitializerTest to package serverUpgradeStatus : ServerUpgradeStatus from class org.sonar.server.computation.CeQueueCleanerTest | From | To | |
| Extract Class | 2 | ||
| Extract Class org.sonar.server.computation.CeQueueCleaner from class org.sonar.server.computation.CeQueueInitializer | From | To | |
| Extract Class org.sonar.server.computation.CeQueueCleanerTest from class org.sonar.server.computation.CeQueueInitializerTest | From | To | |
| Rename Class | 2 | ||
| Rename Class org.sonar.server.computation.CeQueueTest renamed to org.sonar.server.computation.CeQueueImplTest | From | To | |
| Rename Class org.sonar.server.computation.CeTaskSubmit renamed to org.sonar.server.computation.TestTaskSubmission | From | To | |
| Change Variable Type | 3 | ||
| Change Variable Type submit : CeTaskSubmit to submit : TaskSubmission in method public submit(projectKey String, projectBranch String, projectName String, reportInput InputStream) : CeTask in class org.sonar.server.computation.ReportSubmitter | From | To | |
| Change Variable Type submit : CeTaskSubmit to submission : TaskSubmission in method private submit(reportType String, componentUuid String) : CeTask in class org.sonar.server.computation.CeQueueImplTest | From | To | |
| Change Variable Type submit : CeTaskSubmit to submission : TaskSubmission in method public test_submit() : void in class org.sonar.server.computation.CeQueueImplTest | From | To | |
| Extract Method | 2 | ||
| Extract Method private updateQueueStatus(status CeActivityDto.Status, activityDto CeActivityDto) : void extracted from public remove(task CeTask, status CeActivityDto.Status) : void in class org.sonar.server.computation.CeQueueImpl | From | To | |
| Extract Method private readQuery(wsRequest Request) : CeActivityQuery extracted from public handle(wsRequest Request, wsResponse Response) : void in class org.sonar.server.computation.ws.CeActivityWsAction | From | To | |
| Rename Method | 2 | ||
| Rename Method public onServerStart(server Server) : void renamed to public schedule() : void in class org.sonar.server.computation.ReportProcessingScheduler | From | To | |
| Rename Method public test_response_example() : void renamed to public test_example_json_response() : void in class org.sonar.server.computation.ws.CeSubmitWsActionTest | From | To | |
| Push Down Method | 15 | ||
| Push Down Method private remove(dbSession DbSession, task CeTask, queueDto CeQueueDto, activityDto CeActivityDto) : void from class org.sonar.server.computation.CeQueue to private remove(dbSession DbSession, task CeTask, queueDto CeQueueDto, activityDto CeActivityDto) : void from class org.sonar.server.computation.CeQueueImpl | From | To | |
| Push Down Method public pausePeek() : void from class org.sonar.server.computation.CeQueue to public pausePeek() : void from class org.sonar.server.computation.CeQueueImpl | From | To | |
| Push Down Method public isPeekPaused() : boolean from class org.sonar.server.computation.CeQueue to public isPeekPaused() : boolean from class org.sonar.server.computation.CeQueueImpl | From | To | |
| Push Down Method public isSubmitPaused() : boolean from class org.sonar.server.computation.CeQueue to public isSubmitPaused() : boolean from class org.sonar.server.computation.CeQueueImpl | From | To | |
| Push Down Method public CeQueue(system2 System2, dbClient DbClient, uuidFactory UuidFactory, queueStatus CEQueueStatus, listeners CeQueueListener[]) from class org.sonar.server.computation.CeQueue to public CeQueueImpl(system2 System2, dbClient DbClient, uuidFactory UuidFactory, queueStatus CEQueueStatus, listeners CeQueueListener[]) from class org.sonar.server.computation.CeQueueImpl | From | To | |
| Push Down Method public resumeSubmit() : void from class org.sonar.server.computation.CeQueue to public resumeSubmit() : void from class org.sonar.server.computation.CeQueueImpl | From | To | |
| Push Down Method public cancel(taskUuid String) : boolean from class org.sonar.server.computation.CeQueue to public cancel(taskUuid String) : boolean from class org.sonar.server.computation.CeQueueImpl | From | To | |
| Push Down Method public peek() : Optional<CeTask> from class org.sonar.server.computation.CeQueue to public peek() : Optional<CeTask> from class org.sonar.server.computation.CeQueueImpl | From | To | |
| Push Down Method public clear() : int from class org.sonar.server.computation.CeQueue to public clear() : int from class org.sonar.server.computation.CeQueueImpl | From | To | |
| Push Down Method public pauseSubmit() : void from class org.sonar.server.computation.CeQueue to public pauseSubmit() : void from class org.sonar.server.computation.CeQueueImpl | From | To | |
| Push Down Method package cancel(dbSession DbSession, q CeQueueDto) : void from class org.sonar.server.computation.CeQueue to package cancel(dbSession DbSession, q CeQueueDto) : void from class org.sonar.server.computation.CeQueueImpl | From | To | |
| Push Down Method public remove(task CeTask, status CeActivityDto.Status) : void from class org.sonar.server.computation.CeQueue to public remove(task CeTask, status CeActivityDto.Status) : void from class org.sonar.server.computation.CeQueueImpl | From | To | |
| Push Down Method public resumePeek() : void from class org.sonar.server.computation.CeQueue to public resumePeek() : void from class org.sonar.server.computation.CeQueueImpl | From | To | |
| Push Down Method public cancelAll() : int from class org.sonar.server.computation.CeQueue to public cancelAll() : int from class org.sonar.server.computation.CeQueueImpl | From | To | |
| Push Down Method private cancelAll(includeInProgress boolean) : int from class org.sonar.server.computation.CeQueue to private cancelAll(includeInProgress boolean) : int from class org.sonar.server.computation.CeQueueImpl | From | To | |
| Rename Variable | 2 | ||
| Rename Variable submit : CeTaskSubmit to submission : TaskSubmission in method private submit(reportType String, componentUuid String) : CeTask in class org.sonar.server.computation.CeQueueImplTest | From | To | |
| Rename Variable submit : CeTaskSubmit to submission : TaskSubmission in method public test_submit() : void in class org.sonar.server.computation.CeQueueImplTest | From | To | |
| Change Return Type | 3 | ||
| Change Return Type void to TaskSubmission in method public setSubmitterLogin(s String) : TaskSubmission in class org.sonar.server.computation.TestTaskSubmission | From | To | |
| Change Return Type void to TaskSubmission in method public setType(s String) : TaskSubmission in class org.sonar.server.computation.TestTaskSubmission | From | To | |
| Change Return Type void to TaskSubmission in method public setComponentUuid(s String) : TaskSubmission in class org.sonar.server.computation.TestTaskSubmission | From | To | |
| Rename Attribute | 2 | ||
| Rename Attribute reportFiles : ReportFiles to scheduler : ReportProcessingScheduler in class org.sonar.server.computation.CeQueueInitializer | From | To | |
| Rename Attribute queue : CeQueue to cleaner : CeQueueCleaner in class org.sonar.server.computation.CeQueueInitializer | From | To | |
| Extract Interface | 1 | ||
| Extract Interface org.sonar.server.computation.TaskSubmission from classes [org.sonar.server.computation.TestTaskSubmission] | From | To | |
| Change Attribute Type | 2 | ||
| Change Attribute Type reportFiles : ReportFiles to scheduler : ReportProcessingScheduler in class org.sonar.server.computation.CeQueueInitializer | From | To | |
| Change Attribute Type queue : CeQueue to cleaner : CeQueueCleaner in class org.sonar.server.computation.CeQueueInitializer | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter type : String to s : String in method public setType(s String) : TaskSubmission in class org.sonar.server.computation.TestTaskSubmission | From | To |