sonarqube af3d0b3c6b555616b3f6207620dd92360a653996

af3d0b3c6b555616b3f6207620dd92360a653996

Files Diff

Added: 15
Removed: 16
Renamed: 0
Modified: 67

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Change Parameter Type	15
Change Parameter Type system2 : System2 to settings : Settings in method public ReportQueue(dbClient DbClient, settings Settings) in class org.sonar.server.computation.ReportQueue	From	To
Change Parameter Type reportDto : AnalysisReportDto to reportReader : BatchReportReader in method public ComputationContext(reportReader BatchReportReader, project ComponentDto) in class org.sonar.server.computation.ComputationContext	From	To
Change Parameter Type queue : AnalysisReportQueue to queue : ReportQueue in method public SubmitReportWsAction(queue ReportQueue, workerLauncher ComputationThreadLauncher) in class org.sonar.server.computation.ws.SubmitReportWsAction	From	To
Change Parameter Type report : AnalysisReportDto to item : ReportQueue.Item in method public process(item ReportQueue.Item) : void in class org.sonar.server.computation.ComputationService	From	To
Change Parameter Type queue : AnalysisReportQueue to queue : ReportQueue in method public QueueWsAction(queue ReportQueue) in class org.sonar.server.computation.ws.QueueWsAction	From	To
Change Parameter Type queue : AnalysisReportQueue to queue : ReportQueue in method public ComputationThreadLauncher(queue ReportQueue) in class org.sonar.server.computation.ComputationThreadLauncher	From	To
Change Parameter Type report : AnalysisReportDto to reportSnapshotId : long in method private disablePreviousSnapshot(session DbSession, reportSnapshotId long) : void in class org.sonar.server.computation.step.SwitchSnapshotStep	From	To
Change Parameter Type report : AnalysisReportDto to reportSnapshotId : long in method private enableCurrentSnapshot(session DbSession, reportSnapshotId long) : void in class org.sonar.server.computation.step.SwitchSnapshotStep	From	To
Change Parameter Type report : AnalysisReportDto to queueItem : ReportQueue.Item in method private loadProject(queueItem ReportQueue.Item) : ComponentDto in class org.sonar.server.computation.ComputationService	From	To
Change Parameter Type queue : AnalysisReportQueue to queue : ReportQueue in method public IsQueueEmptyWebService(queue ReportQueue) in class org.sonar.server.computation.ws.IsQueueEmptyWebService	From	To
Change Parameter Type queue : AnalysisReportQueue to queue : ReportQueue in method public IsQueueEmptyWsAction(queue ReportQueue) in class org.sonar.server.computation.ws.IsQueueEmptyWebService.IsQueueEmptyWsAction	From	To
Change Parameter Type report : AnalysisReportDto to item : ReportQueue.Item in method private removeSilentlyFromQueue(item ReportQueue.Item) : void in class org.sonar.server.computation.ComputationThread	From	To
Change Parameter Type queue : AnalysisReportQueue to queue : ReportQueue in method public ComputationThread(queue ReportQueue) in class org.sonar.server.computation.ComputationThread	From	To
Change Parameter Type queue : AnalysisReportQueue to queue : ReportQueue in method package ComputationThreadLauncher(queue ReportQueue, delayForFirstStart long, delayBetweenTasks long, timeUnit TimeUnit) in class org.sonar.server.computation.ComputationThreadLauncher	From	To
Change Parameter Type dbClient : DbClient to queue : ReportQueue in method public ReportQueueCleaner(serverUpgradeStatus ServerUpgradeStatus, queue ReportQueue) in class org.sonar.server.computation.ReportQueueCleaner	From	To
Move Attribute	3
Move Attribute private dbClient : DbClient from class org.sonar.server.computation.step.ParseReportStep to private dbClient : DbClient from class org.sonar.server.computation.ReportQueue	From	To
Move Attribute private tempFolder : TempFolder from class org.sonar.server.computation.step.ParseReportStep to private tempFolder : TempFolder from class org.sonar.server.computation.ComputationService	From	To
Move Attribute private dbClient : DbClient from class org.sonar.server.computation.AnalysisReportQueueCleaner to private dbClient : DbClient from class org.sonar.server.computation.ReportQueue	From	To
Extract Class	1
Extract Class org.sonar.server.computation.ReportQueue from class org.sonar.server.computation.AnalysisReportQueueCleaner	From	To
Rename Class	5
Rename Class org.sonar.server.computation.AnalysisReportLog renamed to org.sonar.server.computation.ReportActivity	From	To
Rename Class org.sonar.batch.protocol.output.BatchOutputReaderTest renamed to org.sonar.batch.protocol.output.BatchReportReaderTest	From	To
Rename Class org.sonar.batch.protocol.output.BatchOutputReader renamed to org.sonar.batch.protocol.output.BatchReportReader	From	To
Rename Class org.sonar.server.computation.AnalysisReportQueue renamed to org.sonar.server.computation.ReportQueue	From	To
Rename Class org.sonar.server.computation.AnalysisReportQueueCleaner renamed to org.sonar.server.computation.ReportQueueCleaner	From	To
Extract Variable	28
Extract Variable issues : Iterable<BatchReport.Issue> in method private recursivelyProcessComponent(context ComputationContext, componentRef int) : void from class org.sonar.server.computation.step.ParseReportStep	From	To
Extract Variable bs : ByteString in method private Issue(input CodedInputStream, extensionRegistry ExtensionRegistryLite) from class org.sonar.batch.protocol.output.BatchReport.Issue	From	To
Extract Variable s : String in method public log(level LoggerLevel, msg String, args Object...) : void from class org.sonar.api.utils.log.ListInterceptor	From	To
Extract Variable s : String in method public log(level LoggerLevel, msg String, arg Object) : void from class org.sonar.api.utils.log.ListInterceptor	From	To
Extract Variable bs : ByteString in method private Metadata(input CodedInputStream, extensionRegistry ExtensionRegistryLite) from class org.sonar.batch.protocol.output.BatchReport.Metadata	From	To
Extract Variable s : String in method public log(level LoggerLevel, msg String, arg1 Object, arg2 Object) : void from class org.sonar.api.utils.log.ListInterceptor	From	To
Extract Variable bs : ByteString in method private Line(input CodedInputStream, extensionRegistry ExtensionRegistryLite) from class org.sonar.server.source.db.FileSourceDb.Line	From	To
Extract Variable bs : ByteString in method private Component(input CodedInputStream, extensionRegistry ExtensionRegistryLite) from class org.sonar.batch.protocol.output.BatchReport.Component	From	To
Change Variable Type	4
Change Variable Type report : AnalysisReportDto to item : ReportQueue.Item in method public run() : void in class org.sonar.server.computation.ComputationThread	From	To
Change Variable Type reportKey : String to item : ReportQueue.Item in method public handle(request Request, response Response) : void in class org.sonar.server.computation.ws.SubmitReportWsAction	From	To
Change Variable Type reader : BatchOutputReader to reader : BatchReportReader in method public create_dir_if_does_not_exist() : void in class org.sonar.batch.protocol.output.BatchReportReaderTest	From	To
Change Variable Type metadata : BatchReport.Metadata to builder : BatchReport.Metadata.Builder in method public publish(writer BatchOutputWriter) : void in class org.sonar.batch.report.ComponentsPublisher	From	To
Rename Method	5
Rename Method public when_the_analysis_throws_an_exception_it_does_not_break_the_task() : void renamed to public handle_error_during_queue_pop() : void in class org.sonar.server.computation.ComputationThreadTest	From	To
Rename Method public add(projectKey String, snapshotId Long, reportData InputStream) : String renamed to public resetToPendingStatus() : void in class org.sonar.server.computation.ReportQueue	From	To
Rename Method public call_findAndBook_and_no_call_to_analyze_if_no_report_found() : void renamed to public do_nothing_if_queue_empty() : void in class org.sonar.server.computation.ComputationThreadTest	From	To
Rename Method public call_findAndBook_and_then_analyze_if_there_is_a_report() : void renamed to public pop_queue_and_integrate_report() : void in class org.sonar.server.computation.ComputationThreadTest	From	To
Rename Method public remove(report AnalysisReportDto) : void renamed to public clear() : void in class org.sonar.server.computation.ReportQueue	From	To
Inline Method	1
Inline Method private insertInDb(reportTemplate AnalysisReportDto, session DbSession) : AnalysisReportDto inlined to public resetToPendingStatus() : void in class org.sonar.server.computation.ReportQueue	From	To
Rename Variable	4
Rename Variable report : AnalysisReportDto to item : ReportQueue.Item in method public run() : void in class org.sonar.server.computation.ComputationThread	From	To
Rename Variable reportKey : String to item : ReportQueue.Item in method public handle(request Request, response Response) : void in class org.sonar.server.computation.ws.SubmitReportWsAction	From	To
Rename Variable report : AnalysisReportDto to dto : AnalysisReportDto in method public process_project() : void in class org.sonar.server.computation.ComputationServiceTest	From	To
Rename Variable metadata : BatchReport.Metadata to builder : BatchReport.Metadata.Builder in method public publish(writer BatchOutputWriter) : void in class org.sonar.batch.report.ComponentsPublisher	From	To
Change Return Type	5
Change Return Type String to void in method public resetToPendingStatus() : void in class org.sonar.server.computation.ReportQueue	From	To
Change Return Type List<java.lang.String> to ProtocolStringList in method public getTagsList() : ProtocolStringList in class org.sonar.batch.protocol.output.BatchReport.Issue.Builder	From	To
Change Return Type List<java.lang.String> to ProtocolStringList in method public getTagsList() : ProtocolStringList in class org.sonar.batch.protocol.output.BatchReport.Issue	From	To
Change Return Type List<java.lang.String> to ProtocolStringList in method public getTagsList() : ProtocolStringList in class org.sonar.batch.protocol.output.BatchReport.IssueOrBuilder	From	To
Change Return Type AnalysisReportDto to Item in method public pop() : Item in class org.sonar.server.computation.ReportQueue	From	To
Replace Variable With Attribute	3
Replace Variable With Attribute step : SendIssueNotificationsStep to sut : SendIssueNotificationsStep in method public do_not_send_notifications_if_no_subscribers() : void in class org.sonar.server.computation.step.SendIssueNotificationsStepTest	From	To
Replace Variable With Attribute step : SendIssueNotificationsStep to sut : SendIssueNotificationsStep in method public send_notifications_if_subscribers() : void in class org.sonar.server.computation.step.SendIssueNotificationsStepTest	From	To
Replace Variable With Attribute step : ParseReportStep to sut : ParseReportStep in method public extract_report_from_db_and_browse_components() : void in class org.sonar.server.computation.step.ParseReportStepTest	From	To
Extract Superclass	1
Extract Superclass org.sonar.server.computation.step.BaseStepTest from classes [org.sonar.server.computation.step.ApplyPermissionsStepTest, org.sonar.server.computation.step.IndexComponentsStepTest, org.sonar.server.computation.step.IndexViewsStepTest, org.sonar.server.computation.step.ParseReportStepTest, org.sonar.server.computation.step.PurgeDatastoresStepTest, org.sonar.server.computation.step.PurgeRemovedViewsStepTest, org.sonar.server.computation.step.SendIssueNotificationsStepTest]	From	To
Rename Attribute	5
Rename Attribute reportDto : AnalysisReportDto to reportReader : BatchReportReader in class org.sonar.server.computation.ComputationContext	From	To
Rename Attribute dbClient : DbClient to queue : ReportQueue in class org.sonar.server.computation.ReportQueueCleaner	From	To
Rename Attribute step : PurgeRemovedViewsStep to sut : PurgeRemovedViewsStep in class org.sonar.server.computation.step.PurgeRemovedViewsStepTest	From	To
Rename Attribute logService : ActivityService to activityService : ActivityService in class org.sonar.server.computation.ws.HistoryWsAction	From	To
Rename Attribute system2 : System2 to settings : Settings in class org.sonar.server.computation.ReportQueue	From	To
Change Attribute Type	14
Change Attribute Type queue : AnalysisReportQueue to queue : ReportQueue in class org.sonar.server.computation.ComputationThread	From	To
Change Attribute Type queue : AnalysisReportQueue to queue : ReportQueue in class org.sonar.server.computation.ComputationThreadTest	From	To
Change Attribute Type queue : AnalysisReportQueue to queue : ReportQueue in class org.sonar.server.computation.ws.IsQueueEmptyWebService.IsQueueEmptyWsAction	From	To
Change Attribute Type queue : AnalysisReportQueue to queue : ReportQueue in class org.sonar.server.computation.ws.QueueWsAction	From	To
Change Attribute Type queue : AnalysisReportQueue to queue : ReportQueue in class org.sonar.server.computation.ws.QueueWsActionTest	From	To
Change Attribute Type queue : AnalysisReportQueue to queue : ReportQueue in class org.sonar.server.computation.ws.SubmitReportWsActionTest	From	To
Change Attribute Type queue : AnalysisReportQueue to queue : ReportQueue in class org.sonar.server.computation.ws.IsQueueEmptyWebServiceTest	From	To
Change Attribute Type queue : AnalysisReportQueue to queue : ReportQueue in class org.sonar.server.computation.ws.HistoryWsActionMediumTest	From	To
Change Attribute Type queue : AnalysisReportQueue to queue : ReportQueue in class org.sonar.server.computation.ComputationThreadLauncher	From	To
Change Attribute Type queue : AnalysisReportQueue to queue : ReportQueue in class org.sonar.server.computation.ws.SubmitReportWsAction	From	To
Change Attribute Type queue : AnalysisReportQueue to queue : ReportQueue in class org.sonar.server.computation.ComputationThreadLauncherTest	From	To
Change Attribute Type reportDto : AnalysisReportDto to reportReader : BatchReportReader in class org.sonar.server.computation.ComputationContext	From	To
Change Attribute Type dbClient : DbClient to queue : ReportQueue in class org.sonar.server.computation.ReportQueueCleaner	From	To
Change Attribute Type system2 : System2 to settings : Settings in class org.sonar.server.computation.ReportQueue	From	To
Rename Parameter	9
Rename Parameter logService : ActivityService to activityService : ActivityService in method public HistoryWsAction(activityService ActivityService, mapping ActivityMapping) in class org.sonar.server.computation.ws.HistoryWsAction	From	To
Rename Parameter report : AnalysisReportDto to reportSnapshotId : long in method private disablePreviousSnapshot(session DbSession, reportSnapshotId long) : void in class org.sonar.server.computation.step.SwitchSnapshotStep	From	To
Rename Parameter report : AnalysisReportDto to reportSnapshotId : long in method private enableCurrentSnapshot(session DbSession, reportSnapshotId long) : void in class org.sonar.server.computation.step.SwitchSnapshotStep	From	To
Rename Parameter report : AnalysisReportDto to queueItem : ReportQueue.Item in method private loadProject(queueItem ReportQueue.Item) : ComponentDto in class org.sonar.server.computation.ComputationService	From	To
Rename Parameter system2 : System2 to settings : Settings in method public ReportQueue(dbClient DbClient, settings Settings) in class org.sonar.server.computation.ReportQueue	From	To
Rename Parameter reportDto : AnalysisReportDto to reportReader : BatchReportReader in method public ComputationContext(reportReader BatchReportReader, project ComponentDto) in class org.sonar.server.computation.ComputationContext	From	To
Rename Parameter report : AnalysisReportDto to item : ReportQueue.Item in method private removeSilentlyFromQueue(item ReportQueue.Item) : void in class org.sonar.server.computation.ComputationThread	From	To
Rename Parameter report : AnalysisReportDto to item : ReportQueue.Item in method public process(item ReportQueue.Item) : void in class org.sonar.server.computation.ComputationService	From	To
Rename Parameter dbClient : DbClient to queue : ReportQueue in method public ReportQueueCleaner(serverUpgradeStatus ServerUpgradeStatus, queue ReportQueue) in class org.sonar.server.computation.ReportQueueCleaner	From	To

af3d0b3c6b555616b3f6207620dd92360a653996

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: