sonarqube b3a419922a4bad044c8f6beb9e05e2a59e3422e8

b3a419922a4bad044c8f6beb9e05e2a59e3422e8

Files Diff

Added: 0
Removed: 0
Renamed: 0
Modified: 16

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Change Parameter Type	26
Change Parameter Type ruleDto : RuleDto to ruleDto : RuleDefinitionDto in method private defaultDebtRemediationFunction(ruleDto RuleDefinitionDto) : DebtRemediationFunction in class org.sonar.server.rule.ws.RuleMapper	From	To
Change Parameter Type ruleDto : RuleDto to ruleDto : RuleMetadataDto in method private setNotesFields(ruleResponse Rules.Rule.Builder, ruleDto RuleMetadataDto, fieldsToReturn Set<String>) : void in class org.sonar.server.rule.ws.RuleMapper	From	To
Change Parameter Type ruleDto : RuleDto to ruleDto : RuleDefinitionDto in method private setStatus(ruleResponse Rules.Rule.Builder, ruleDto RuleDefinitionDto, fieldsToReturn Set<String>) : void in class org.sonar.server.rule.ws.RuleMapper	From	To
Change Parameter Type ruleDto : RuleDto to ruleDto : RuleDefinitionDto in method private setLanguageName(ruleResponse Rules.Rule.Builder, ruleDto RuleDefinitionDto, fieldsToReturn Set<String>) : void in class org.sonar.server.rule.ws.RuleMapper	From	To
Change Parameter Type ruleDto : RuleDto to ruleDto : RuleDefinitionDto in method private setDefaultDebtRemediationFunctionFields(ruleResponse Rules.Rule.Builder, ruleDto RuleDefinitionDto, fieldsToReturn Set<String>) : void in class org.sonar.server.rule.ws.RuleMapper	From	To
Change Parameter Type organizationUuid : String to organization : OrganizationDto in method private readRequest(dbSession DbSession, request Request, organization OrganizationDto) : RuleUpdate in class org.sonar.server.rule.ws.UpdateAction	From	To
Change Parameter Type ruleDto : RuleDto to ruleDefinitionDto : RuleDefinitionDto in method public applyRuleDefinition(ruleResponse Rules.Rule.Builder, ruleDefinitionDto RuleDefinitionDto, result SearchResult, fieldsToReturn Set<String>) : Rules.Rule.Builder in class org.sonar.server.rule.ws.RuleMapper	From	To
Change Parameter Type ruleDto : RuleDto to ruleDto : RuleDefinitionDto in method private setTemplateKey(ruleResponse Rules.Rule.Builder, ruleDto RuleDefinitionDto, result SearchResult, fieldsToReturn Set<String>) : void in class org.sonar.server.rule.ws.RuleMapper	From	To
Change Parameter Type ruleDto : RuleDto to ruleDto : RuleMetadataDto in method private setIsRemediationFunctionOverloaded(ruleResponse Rules.Rule.Builder, ruleDto RuleMetadataDto, fieldsToReturn Set<String>) : void in class org.sonar.server.rule.ws.RuleMapper	From	To
Change Parameter Type ruleDto : RuleDto to ruleDto : RuleDefinitionDto in method private setEffortToFixDescription(ruleResponse Rules.Rule.Builder, ruleDto RuleDefinitionDto, fieldsToReturn Set<String>) : void in class org.sonar.server.rule.ws.RuleMapper	From	To
Change Parameter Type ruleDto : RuleDto to ruleDto : RuleMetadataDto in method private setTags(ruleResponse Rules.Rule.Builder, ruleDto RuleMetadataDto, fieldsToReturn Set<String>) : void in class org.sonar.server.rule.ws.RuleMapper	From	To
Change Parameter Type ruleDto : RuleDto to ruleDto : RuleDefinitionDto in method private setName(ruleResponse Rules.Rule.Builder, ruleDto RuleDefinitionDto, fieldsToReturn Set<String>) : void in class org.sonar.server.rule.ws.RuleMapper	From	To
Change Parameter Type ruleDto : RuleDto to ruleDto : RuleDefinitionDto in method private setCreatedAt(ruleResponse Rules.Rule.Builder, ruleDto RuleDefinitionDto, fieldsToReturn Set<String>) : void in class org.sonar.server.rule.ws.RuleMapper	From	To
Change Parameter Type ruleDto : RuleDto to ruleDefinitionDto : RuleDefinitionDto in method public toWsRule(ruleDefinitionDto RuleDefinitionDto, result SearchResult, fieldsToReturn Set<String>, metadata RuleMetadataDto) : Rules.Rule in class org.sonar.server.rule.ws.RuleMapper	From	To
Change Parameter Type ruleDto : RuleDto to ruleDto : RuleDefinitionDto in method private setParams(ruleResponse Rules.Rule.Builder, ruleDto RuleDefinitionDto, searchResult SearchResult, fieldsToReturn Set<String>) : void in class org.sonar.server.rule.ws.RuleMapper	From	To
Change Parameter Type ruleDto : RuleDto to ruleDto : RuleDefinitionDto in method private setSeverity(ruleResponse Rules.Rule.Builder, ruleDto RuleDefinitionDto, fieldsToReturn Set<String>) : void in class org.sonar.server.rule.ws.RuleMapper	From	To
Change Parameter Type ruleDto : RuleDto to metadata : RuleMetadataDto in method private applyRuleMetadata(ruleResponse Rules.Rule.Builder, metadata RuleMetadataDto, fieldsToReturn Set<String>) : void in class org.sonar.server.rule.ws.RuleMapper	From	To
Change Parameter Type organizationUuid : String to organization : OrganizationDto in method public selectOrFailByKey(session DbSession, organization OrganizationDto, key RuleKey) : RuleDto in class org.sonar.db.rule.RuleDao	From	To
Change Parameter Type organizationUuid : String to organization : OrganizationDto in method private buildResponse(dbSession DbSession, key RuleKey, organization OrganizationDto) : UpdateResponse in class org.sonar.server.rule.ws.UpdateAction	From	To
Change Parameter Type ruleDto : RuleDto to ruleDto : RuleDefinitionDto in method private setInternalKey(ruleResponse Rules.Rule.Builder, ruleDto RuleDefinitionDto, fieldsToReturn Set<String>) : void in class org.sonar.server.rule.ws.RuleMapper	From	To
Change Parameter Type ruleDto : RuleDto to ruleDto : RuleDefinitionDto in method private setDescriptionFields(ruleResponse Rules.Rule.Builder, ruleDto RuleDefinitionDto, fieldsToReturn Set<String>) : void in class org.sonar.server.rule.ws.RuleMapper	From	To
Change Parameter Type ruleDto : RuleDto to ruleDto : RuleDefinitionDto in method private setLanguage(ruleResponse Rules.Rule.Builder, ruleDto RuleDefinitionDto, fieldsToReturn Set<String>) : void in class org.sonar.server.rule.ws.RuleMapper	From	To
Change Parameter Type ruleDto : RuleDto to ruleDto : RuleDefinitionDto in method private setRepository(ruleResponse Rules.Rule.Builder, ruleDto RuleDefinitionDto, fieldsToReturn Set<String>) : void in class org.sonar.server.rule.ws.RuleMapper	From	To
Change Parameter Type ruleDto : RuleDto to ruleDto : RuleDefinitionDto in method private setIsTemplate(ruleResponse Rules.Rule.Builder, ruleDto RuleDefinitionDto, fieldsToReturn Set<String>) : void in class org.sonar.server.rule.ws.RuleMapper	From	To
Change Parameter Type rule : RuleDto to rule : RuleMetadataDto in method private isRemediationFunctionOverloaded(rule RuleMetadataDto) : boolean in class org.sonar.server.rule.ws.RuleMapper	From	To
Change Parameter Type ruleDto : RuleDto to ruleDto : RuleDefinitionDto in method private setSysTags(ruleResponse Rules.Rule.Builder, ruleDto RuleDefinitionDto, fieldsToReturn Set<String>) : void in class org.sonar.server.rule.ws.RuleMapper	From	To
Rename Variable	1
Rename Variable defaultOrganizationUuid : String to organization : OrganizationDto in method public handle(request Request, response Response) : void in class org.sonar.server.rule.ws.UpdateAction	From	To
Inline Method	1
Inline Method private write409(dbSession DbSession, request Request, response Response, ruleKey RuleKey) : void inlined to public handle(request Request, response Response) : void in class org.sonar.server.rule.ws.CreateAction	From	To
Move Attribute	1
Move Attribute private isCustomRule : boolean from class org.sonar.server.rule.RuleUpdate to public isCustomRule : boolean from class org.sonar.server.rule.RuleUpdate.RuleUpdateUseCase	From	To
Change Variable Type	4
Change Variable Type customRule : RuleDto to customRule : RuleDefinitionDto in method public fail_to_update_custom_rule_when_empty_name() : void in class org.sonar.server.rule.RuleUpdaterMediumTest	From	To
Change Variable Type templateRule : RuleDto to templateRule : RuleDefinitionDto in method public fail_to_update_custom_rule_when_empty_name() : void in class org.sonar.server.rule.RuleUpdaterMediumTest	From	To
Change Variable Type defaultOrganizationUuid : String to organization : OrganizationDto in method public handle(request Request, response Response) : void in class org.sonar.server.rule.ws.UpdateAction	From	To
Change Variable Type rule : RuleDto to rule : RuleDefinitionDto in method private createResponse(dbSession DbSession, ruleKey RuleKey) : Rules.CreateResponse in class org.sonar.server.rule.ws.CreateAction	From	To
Extract Variable	3
Extract Variable ruleKey : RuleKey in method public update(dbSession DbSession, update RuleUpdate, organization OrganizationDto, userSession UserSession) : boolean from class org.sonar.server.rule.RuleUpdater	From	To
Extract Variable defaultOrganization : OrganizationDto in method public update_and_remove_rules_on_changes() : void from class org.sonar.server.rule.RegisterRulesTest	From	To
Extract Variable defaultOrganization : OrganizationDto in method public add_new_tag() : void from class org.sonar.server.rule.RegisterRulesTest	From	To
Inline Variable	1
Inline Variable type : Common.RuleType in method public toWsRule(ruleDto RuleDto, result SearchResult, fieldsToReturn Set<String>) : Rules.Rule from class org.sonar.server.rule.ws.RuleMapper	From	To
Extract Method	2
Extract Method public applyRuleDefinition(ruleResponse Rules.Rule.Builder, ruleDefinitionDto RuleDefinitionDto, result SearchResult, fieldsToReturn Set<String>) : Rules.Rule.Builder extracted from public toWsRule(ruleDto RuleDto, result SearchResult, fieldsToReturn Set<String>) : Rules.Rule in class org.sonar.server.rule.ws.RuleMapper	From	To
Extract Method private applyRuleMetadata(ruleResponse Rules.Rule.Builder, metadata RuleMetadataDto, fieldsToReturn Set<String>) : void extracted from public toWsRule(ruleDto RuleDto, result SearchResult, fieldsToReturn Set<String>) : Rules.Rule in class org.sonar.server.rule.ws.RuleMapper	From	To
Extract And Move Method	1
Extract And Move Method public setOrganization(organization OrganizationDto) : RuleUpdate extracted from public remove_user_tags_that_are_newly_declared_as_system() : void in class org.sonar.server.rule.RegisterRulesMediumTest & moved to class org.sonar.server.rule.RuleUpdate	From	To
Rename Parameter	6
Rename Parameter ruleDto : RuleDto to metadata : RuleMetadataDto in method private applyRuleMetadata(ruleResponse Rules.Rule.Builder, metadata RuleMetadataDto, fieldsToReturn Set<String>) : void in class org.sonar.server.rule.ws.RuleMapper	From	To
Rename Parameter organizationUuid : String to organization : OrganizationDto in method private readRequest(dbSession DbSession, request Request, organization OrganizationDto) : RuleUpdate in class org.sonar.server.rule.ws.UpdateAction	From	To
Rename Parameter organizationUuid : String to organization : OrganizationDto in method public selectOrFailByKey(session DbSession, organization OrganizationDto, key RuleKey) : RuleDto in class org.sonar.db.rule.RuleDao	From	To
Rename Parameter ruleDto : RuleDto to ruleDefinitionDto : RuleDefinitionDto in method public applyRuleDefinition(ruleResponse Rules.Rule.Builder, ruleDefinitionDto RuleDefinitionDto, result SearchResult, fieldsToReturn Set<String>) : Rules.Rule.Builder in class org.sonar.server.rule.ws.RuleMapper	From	To
Rename Parameter organizationUuid : String to organization : OrganizationDto in method private buildResponse(dbSession DbSession, key RuleKey, organization OrganizationDto) : UpdateResponse in class org.sonar.server.rule.ws.UpdateAction	From	To
Rename Parameter ruleDto : RuleDto to ruleDefinitionDto : RuleDefinitionDto in method public toWsRule(ruleDefinitionDto RuleDefinitionDto, result SearchResult, fieldsToReturn Set<String>, metadata RuleMetadataDto) : Rules.Rule in class org.sonar.server.rule.ws.RuleMapper	From	To

b3a419922a4bad044c8f6beb9e05e2a59e3422e8

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: