b4e4af137329f4c90e6365e233cdcba3a5322697
Files Diff
- Added: 7
- Removed: 0
- Renamed: 0
- Modified: 17
Refactorings reported:
Refactoring Name | Occurences | ||
---|---|---|---|
Rename Method | 1 | ||
Rename Method private membership(params Map<String,Object>) : String renamed to public toMembership(selectionModeString String) : String in class org.sonar.server.permission.PermissionQueryParser | From | To | |
Move And Inline Method | 3 | ||
Move And Inline Method package selectUsers(query PermissionQuery, componentId Long) : List<UserWithPermissionDto> moved from class org.sonar.db.permission.PermissionDao to class org.sonar.db.permission.UserWithPermissionDaoTest & inlined to public select_all_users_for_project_permission() : void | From | To | |
Move And Inline Method package selectUsers(query PermissionQuery, componentId Long) : List<UserWithPermissionDto> moved from class org.sonar.db.permission.PermissionDao to class org.sonar.db.permission.UserWithPermissionDaoTest & inlined to public select_all_users_for_global_permission() : void | From | To | |
Move And Inline Method package selectUsers(query PermissionQuery, componentId Long) : List<UserWithPermissionDto> moved from class org.sonar.db.permission.PermissionDao to class org.sonar.db.permission.UserWithPermissionDaoTest & inlined to public select_only_enable_users() : void | From | To | |
Change Parameter Type | 2 | ||
Change Parameter Type params : Map<String,Object> to selectionModeString : String in method public toMembership(selectionModeString String) : String in class org.sonar.server.permission.PermissionQueryParser | From | To | |
Change Parameter Type hasMoreResults : boolean to total : int in method public UserWithPermissionQueryResult(users List<UserWithPermission>, total int) in class org.sonar.server.permission.UserWithPermissionQueryResult | From | To | |
Move Method | 1 | ||
Move Method public selectUsers(query PermissionQuery, componentId Long, offset int, limit int) : List<UserWithPermissionDto> from class org.sonar.db.permission.PermissionDao to public selectUsers(session DbSession, query PermissionQuery, templateId Long, offset int, limit int) : List<UserWithPermissionDto> from class org.sonar.db.permission.PermissionTemplateDao | From | To | |
Merge Parameter | 1 | ||
Merge Parameter [resourceDao : ResourceDao, permissionDao : PermissionDao, permissionTemplateDao : PermissionTemplateDao] to dbClient : DbClient in method public PermissionFinder(dbClient DbClient) in class org.sonar.server.permission.PermissionFinder | From | To | |
Parameterize Variable | 1 | ||
Parameterize Variable hasMoreResults : boolean to total : int in method private toUserQueryResult(dtos List<UserWithPermissionDto>, total int) : UserWithPermissionQueryResult in class org.sonar.server.permission.PermissionFinder | From | To | |
Rename Attribute | 1 | ||
Rename Attribute finder : PermissionFinder to underTest : PermissionFinder in class org.sonar.server.permission.PermissionFinderTest | From | To | |
Change Variable Type | 2 | ||
Change Variable Type hasMoreResults : boolean to total : int in method private toUserQueryResult(dtos List<UserWithPermissionDto>, total int) : UserWithPermissionQueryResult in class org.sonar.server.permission.PermissionFinder | From | To | |
Change Variable Type session : SqlSession to session : DbSession in method public selectUsers(query PermissionQuery, templateId Long, offset int, limit int) : List<UserWithPermissionDto> in class org.sonar.db.permission.PermissionTemplateDao | From | To | |
Extract Method | 1 | ||
Extract Method public selectUsers(session DbSession, query PermissionQuery, templateId Long, offset int, limit int) : List<UserWithPermissionDto> extracted from public selectUsers(query PermissionQuery, templateId Long, offset int, limit int) : List<UserWithPermissionDto> in class org.sonar.db.permission.PermissionTemplateDao | From | To | |
Rename Parameter | 3 | ||
Rename Parameter hasMoreResults : boolean to total : int in method public UserWithPermissionQueryResult(users List<UserWithPermission>, total int) in class org.sonar.server.permission.UserWithPermissionQueryResult | From | To | |
Rename Parameter params : Map<String,Object> to selectionModeString : String in method public toMembership(selectionModeString String) : String in class org.sonar.server.permission.PermissionQueryParser | From | To | |
Rename Parameter componentId : Long to templateId : Long in method public selectUsers(session DbSession, query PermissionQuery, templateId Long, offset int, limit int) : List<UserWithPermissionDto> in class org.sonar.db.permission.PermissionTemplateDao | From | To |