sonarqube bce59a878501872b105e120bc0d8e13494f79aee

bce59a878501872b105e120bc0d8e13494f79aee

Files Diff

Added: 3
Removed: 0
Renamed: 0
Modified: 34

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Rename Method	3
Rename Method package profile() : QProfileDto renamed to package getProfile() : QProfileDto in class org.sonar.server.qualityprofile.RuleActivatorContext	From	To
Rename Method private create(ruleKey RuleKey, dbSession DbSession, context RuleActivatorContext) : RuleActivatorContext renamed to private init(dbSession DbSession, ruleKey RuleKey, context RuleActivatorContext) : RuleActivatorContext in class org.sonar.server.qualityprofile.RuleActivatorContextFactory	From	To
Rename Method package rule() : RuleDefinitionDto renamed to package getRule() : RuleDefinitionDto in class org.sonar.server.qualityprofile.RuleActivatorContext	From	To
Change Parameter Type	2
Change Parameter Type profile : QProfileDto to context : RuleActivatorContext in method private cascadeActivation(dbSession DbSession, activation RuleActivation, context RuleActivatorContext) : List<ActiveRuleChange> in class org.sonar.server.qualityprofile.RuleActivator	From	To
Change Parameter Type profile : QProfileDto to rulesProfile : RulesProfileDto in method private initActiveRules(rulesProfile RulesProfileDto, ruleKey RuleKey, context RuleActivatorContext, dbSession DbSession, isParent boolean) : void in class org.sonar.server.qualityprofile.RuleActivatorContextFactory	From	To
Move Method	1
Move Method package isCascade() : boolean from class org.sonar.server.qualityprofile.RuleActivation to package isCascade() : boolean from class org.sonar.server.qualityprofile.RuleActivatorContext	From	To
Inline Method	1
Inline Method package getQualityProfileDto(session DbSession, profileKey String) : QProfileDto inlined to private init(dbSession DbSession, ruleKey RuleKey, context RuleActivatorContext) : RuleActivatorContext in class org.sonar.server.qualityprofile.RuleActivatorContextFactory	From	To
Change Return Type	1
Change Return Type ActiveRuleDto to void in method private persist(change ActiveRuleChange, context RuleActivatorContext, dbSession DbSession) : void in class org.sonar.server.qualityprofile.RuleActivator	From	To
Extract Method	2
Extract Method private loadPersistedProfiles(dbSession DbSession) : Map<QProfileName,RulesProfileDto> extracted from public start() : void in class org.sonar.server.qualityprofile.RegisterQualityProfiles	From	To
Extract Method private readActivation(request Request) : RuleActivation extracted from public handle(request Request, response Response) : void in class org.sonar.server.qualityprofile.ws.ActivateRuleAction	From	To
Extract And Move Method	37
Extract And Move Method public create(ruleKey RuleKey, severity String, parameters Map<String,String>) : RuleActivation extracted from public user_activates_rule_without_parameters() : void in class org.sonar.server.qualityprofile.RuleActivatorTest & moved to class org.sonar.server.qualityprofile.RuleActivation	From	To
Extract And Move Method public create(ruleKey RuleKey, severity String, parameters Map<String,String>) : RuleActivation extracted from public activation_ignores_unsupported_parameters() : void in class org.sonar.server.qualityprofile.RuleActivatorTest & moved to class org.sonar.server.qualityprofile.RuleActivation	From	To
Extract And Move Method public create(ruleKey RuleKey, severity String, parameters Map<String,String>) : RuleActivation extracted from public system_activates_rule_without_parameters() : void in class org.sonar.server.qualityprofile.RuleActivatorTest & moved to class org.sonar.server.qualityprofile.RuleActivation	From	To
Extract And Move Method public create(ruleKey RuleKey, severity String, parameters Map<String,String>) : RuleActivation extracted from public update_activation_with_parameter_without_default_value() : void in class org.sonar.server.qualityprofile.RuleActivatorTest & moved to class org.sonar.server.qualityprofile.RuleActivation	From	To
Extract And Move Method public create(ruleKey RuleKey, severity String, parameters Map<String,String>) : RuleActivation extracted from public update_activation_with_new_parameter() : void in class org.sonar.server.qualityprofile.RuleActivatorTest & moved to class org.sonar.server.qualityprofile.RuleActivation	From	To
Extract And Move Method public create(ruleKey RuleKey, severity String, parameters Map<String,String>) : RuleActivation extracted from private parseRuleActivations(rulesCursor SMInputCursor) : List<RuleActivation> in class org.sonar.server.qualityprofile.QProfileBackuperImpl & moved to class org.sonar.server.qualityprofile.RuleActivation	From	To
Extract And Move Method public create(ruleKey RuleKey, severity String, parameters Map<String,String>) : RuleActivation extracted from public reset_parent_is_not_propagated_when_child_overrides() : void in class org.sonar.server.qualityprofile.RuleActivatorTest & moved to class org.sonar.server.qualityprofile.RuleActivation	From	To
Extract And Move Method public createReset(ruleKey RuleKey) : RuleActivation extracted from public ignore_reset_if_not_activated() : void in class org.sonar.server.qualityprofile.RuleActivatorTest & moved to class org.sonar.server.qualityprofile.RuleActivation	From	To
Extract And Move Method public create(ruleKey RuleKey, severity String, parameters Map<String,String>) : RuleActivation extracted from public do_not_mark_as_overridden_if_same_values_than_parent() : void in class org.sonar.server.qualityprofile.RuleActivatorTest & moved to class org.sonar.server.qualityprofile.RuleActivation	From	To
Extract And Move Method public create(ruleKey RuleKey, severity String, parameters Map<String,String>) : RuleActivation extracted from public do_not_change_severity_and_params_if_unset_and_already_activated() : void in class org.sonar.server.qualityprofile.RuleActivatorTest & moved to class org.sonar.server.qualityprofile.RuleActivation	From	To
Extract And Move Method public create(ruleKey RuleKey, severity String, parameters Map<String,String>) : RuleActivation extracted from public update_on_child_profile_is_propagated_to_descendants() : void in class org.sonar.server.qualityprofile.RuleActivatorTest & moved to class org.sonar.server.qualityprofile.RuleActivation	From	To
Extract And Move Method public create(ruleKey RuleKey, severity String, parameters Map<String,String>) : RuleActivation extracted from public override_activation_of_inherited_profile() : void in class org.sonar.server.qualityprofile.RuleActivatorTest & moved to class org.sonar.server.qualityprofile.RuleActivation	From	To
Extract And Move Method public create(ruleKey RuleKey, severity String, parameters Map<String,String>) : RuleActivation extracted from public activate_rule_with_negative_integer_value_on_parameter_having_no_default_value() : void in class org.sonar.server.qualityprofile.RuleActivatorTest & moved to class org.sonar.server.qualityprofile.RuleActivation	From	To
Extract And Move Method public create(ruleKey RuleKey, severity String, parameters Map<String,String>) : RuleActivation extracted from public activate_rule_with_parameters() : void in class org.sonar.server.qualityprofile.RuleActivatorTest & moved to class org.sonar.server.qualityprofile.RuleActivation	From	To
Extract And Move Method public create(ruleKey RuleKey, severity String, parameters Map<String,String>) : RuleActivation extracted from public update_active_rules_on_param_changes() : void in class org.sonar.server.rule.RegisterRulesMediumTest & moved to class org.sonar.server.qualityprofile.RuleActivation	From	To
Extract And Move Method public create(ruleKey RuleKey, severity String, parameters Map<String,String>) : RuleActivation extracted from public update_activation_removes_parameter_without_default_value() : void in class org.sonar.server.qualityprofile.RuleActivatorTest & moved to class org.sonar.server.qualityprofile.RuleActivation	From	To
Extract And Move Method public create(ruleKey RuleKey, severity String, parameters Map<String,String>) : RuleActivation extracted from public setParent(dbSession DbSession, profile QProfileDto, parent QProfileDto) : List<ActiveRuleChange> in class org.sonar.server.qualityprofile.RuleActivator & moved to class org.sonar.server.qualityprofile.RuleActivation	From	To
Extract And Move Method public createReset(ruleKey RuleKey) : RuleActivation extracted from public reset_on_parent_is_not_propagated_to_overridden_profiles() : void in class org.sonar.server.qualityprofile.RuleActivatorTest & moved to class org.sonar.server.qualityprofile.RuleActivation	From	To
Extract And Move Method public create(ruleKey RuleKey, severity String, parameters Map<String,String>) : RuleActivation extracted from public reset_on_parent_is_not_propagated_to_overridden_profiles() : void in class org.sonar.server.qualityprofile.RuleActivatorTest & moved to class org.sonar.server.qualityprofile.RuleActivation	From	To
Extract And Move Method public create(ruleKey RuleKey, severity String, parameters Map<String,String>) : RuleActivation extracted from public do_not_deactivate_removed_rules_if_repository_accidentally_uninstalled() : void in class org.sonar.server.rule.RegisterRulesMediumTest & moved to class org.sonar.server.qualityprofile.RuleActivation	From	To
Extract And Move Method public create(ruleKey RuleKey, severity String, parameters Map<String,String>) : RuleActivation extracted from public compare_same() : void in class org.sonar.server.qualityprofile.QProfileComparisonMediumTest & moved to class org.sonar.server.qualityprofile.RuleActivation	From	To
Extract And Move Method public create(ruleKey RuleKey, severity String, parameters Map<String,String>) : RuleActivation extracted from public activate_rule_with_empty_parameter_having_no_default_value() : void in class org.sonar.server.qualityprofile.RuleActivatorTest & moved to class org.sonar.server.qualityprofile.RuleActivation	From	To
Extract And Move Method public createReset(ruleKey RuleKey) : RuleActivation extracted from public reset_child_profile_do_not_change_parent() : void in class org.sonar.server.qualityprofile.RuleActivatorTest & moved to class org.sonar.server.qualityprofile.RuleActivation	From	To
Extract And Move Method public createReset(ruleKey RuleKey) : RuleActivation extracted from public reset_parent_is_not_propagated_when_child_overrides() : void in class org.sonar.server.qualityprofile.RuleActivatorTest & moved to class org.sonar.server.qualityprofile.RuleActivation	From	To
Extract And Move Method public create(ruleKey RuleKey, severity String, parameters Map<String,String>) : RuleActivation extracted from public reset_child_profile_do_not_change_parent() : void in class org.sonar.server.qualityprofile.RuleActivatorTest & moved to class org.sonar.server.qualityprofile.RuleActivation	From	To
Extract And Move Method public create(ruleKey RuleKey, severity String, parameters Map<String,String>) : RuleActivation extracted from public bulkActivate(dbSession DbSession, ruleQuery RuleQuery, profile QProfileDto, severity String) : BulkChangeResult in class org.sonar.server.qualityprofile.RuleActivator & moved to class org.sonar.server.qualityprofile.RuleActivation	From	To
Extract And Move Method public create(ruleKey RuleKey, severity String, parameters Map<String,String>) : RuleActivation extracted from public active_on_parent_a_rule_already_activated_on_child() : void in class org.sonar.server.qualityprofile.RuleActivatorTest & moved to class org.sonar.server.qualityprofile.RuleActivation	From	To
Extract And Move Method public create(ruleKey RuleKey, severity String, parameters Map<String,String>) : RuleActivation extracted from public update_an_already_activated_rule() : void in class org.sonar.server.qualityprofile.RuleActivatorTest & moved to class org.sonar.server.qualityprofile.RuleActivation	From	To
Extract And Move Method public create(ruleKey RuleKey, severity String, parameters Map<String,String>) : RuleActivation extracted from public compare_different_params() : void in class org.sonar.server.qualityprofile.QProfileComparisonMediumTest & moved to class org.sonar.server.qualityprofile.RuleActivation	From	To
Extract And Move Method public create(ruleKey RuleKey, severity String, parameters Map<String,String>) : RuleActivation extracted from public set_then_unset_parent_keep_overridden_rules() : void in class org.sonar.server.qualityprofile.RuleActivatorTest & moved to class org.sonar.server.qualityprofile.RuleActivation	From	To
Extract And Move Method public create(ruleKey RuleKey, severity String, parameters Map<String,String>) : RuleActivation extracted from public updated_activation_on_parent_is_not_propagated_to_overridden_profiles() : void in class org.sonar.server.qualityprofile.RuleActivatorTest & moved to class org.sonar.server.qualityprofile.RuleActivation	From	To
Extract And Move Method public create(ruleKey RuleKey, severity String, parameters Map<String,String>) : RuleActivation extracted from public propagate_deactivation_on_children_even_when_overridden() : void in class org.sonar.server.qualityprofile.RuleActivatorTest & moved to class org.sonar.server.qualityprofile.RuleActivation	From	To
Extract And Move Method public create(ruleKey RuleKey, severity String, parameters Map<String,String>) : RuleActivation extracted from public reset_parameter_to_default_value() : void in class org.sonar.server.qualityprofile.RuleActivatorTest & moved to class org.sonar.server.qualityprofile.RuleActivation	From	To
Extract And Move Method public create(ruleKey RuleKey, severity String, parameters Map<String,String>) : RuleActivation extracted from public compare_modified_severity() : void in class org.sonar.server.qualityprofile.QProfileComparisonMediumTest & moved to class org.sonar.server.qualityprofile.RuleActivation	From	To
Extract And Move Method public create(ruleKey RuleKey, severity String, parameters Map<String,String>) : RuleActivation extracted from public fail_to_activate_if_invalid_parameter() : void in class org.sonar.server.qualityprofile.RuleActivatorTest & moved to class org.sonar.server.qualityprofile.RuleActivation	From	To
Extract And Move Method public create(ruleKey RuleKey, severity String, parameters Map<String,String>) : RuleActivation extracted from public deactivate_removed_rules_only_if_repository_still_exists() : void in class org.sonar.server.rule.RegisterRulesMediumTest & moved to class org.sonar.server.qualityprofile.RuleActivation	From	To
Extract And Move Method public create(ruleKey RuleKey, severity String, parameters Map<String,String>) : RuleActivation extracted from public compare_modified_param() : void in class org.sonar.server.qualityprofile.QProfileComparisonMediumTest & moved to class org.sonar.server.qualityprofile.RuleActivation	From	To
Rename Parameter	7
Rename Parameter session : DbSession to dbSession : DbSession in method package create(dbSession DbSession, ruleKey RuleKey, profile QProfileDto, cascade boolean) : RuleActivatorContext in class org.sonar.server.qualityprofile.RuleActivatorContextFactory	From	To
Rename Parameter profile : QProfileDto to context : RuleActivatorContext in method private cascadeActivation(dbSession DbSession, activation RuleActivation, context RuleActivatorContext) : List<ActiveRuleChange> in class org.sonar.server.qualityprofile.RuleActivator	From	To
Rename Parameter profileDto : QProfileDto to profile : QProfileDto in method public activate(dbSession DbSession, activation RuleActivation, profile QProfileDto) : List<ActiveRuleChange> in class org.sonar.server.qualityprofile.RuleActivator	From	To
Rename Parameter builtInProfile : BuiltInQProfile to builtIn : BuiltInQProfile in method private register(dbSession DbSession, batchDbSession DbSession, builtIn BuiltInQProfile) : void in class org.sonar.server.qualityprofile.RegisterQualityProfiles	From	To
Rename Parameter parent : boolean to isParent : boolean in method private initActiveRules(rulesProfile RulesProfileDto, ruleKey RuleKey, context RuleActivatorContext, dbSession DbSession, isParent boolean) : void in class org.sonar.server.qualityprofile.RuleActivatorContextFactory	From	To
Rename Parameter profile : QProfileDto to rulesProfile : RulesProfileDto in method private initActiveRules(rulesProfile RulesProfileDto, ruleKey RuleKey, context RuleActivatorContext, dbSession DbSession, isParent boolean) : void in class org.sonar.server.qualityprofile.RuleActivatorContextFactory	From	To
Rename Parameter session : DbSession to dbSession : DbSession in method private initActiveRules(rulesProfile RulesProfileDto, ruleKey RuleKey, context RuleActivatorContext, dbSession DbSession, isParent boolean) : void in class org.sonar.server.qualityprofile.RuleActivatorContextFactory	From	To

bce59a878501872b105e120bc0d8e13494f79aee

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: