sonarqube be8707ef18df79c56b14d8296a0955a6f81eae89

be8707ef18df79c56b14d8296a0955a6f81eae89

Files Diff

Added: 9
Removed: 2
Renamed: 0
Modified: 37

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Replace Attribute	1
Replace Attribute package reader : BatchReportReader from class org.sonar.server.computation.step.PersistTestsStep.TestDepthTraversalTypeAwareVisitor with public reportReader : BatchReportReaderRule from class org.sonar.server.benchmark.PersistFileSourcesStepTest	From	To
Rename Method	1
Rename Method public fail_if_corrupted_zip() : void renamed to public fail_if_step_throws_error() : void in class org.sonar.server.computation.ComputationServiceTest	From	To
Change Parameter Type	2
Change Parameter Type s : ComputationStep... to ceContainer : CEContainer in method public ComputationSteps(ceContainer CEContainer) in class org.sonar.server.computation.step.ComputationSteps	From	To
Change Parameter Type activityService : ActivityService to activityManager : CEActivityManager in method public ComputationService(item ReportQueue.Item, steps ComputationSteps, activityManager CEActivityManager, system System2, reportReader BatchReportReader, dbClient DbClient, languageRepository LanguageRepository) in class org.sonar.server.computation.ComputationService	From	To
Move Method	5
Move Method private newDefaultReport() : AnalysisReportDto from class org.sonar.server.computation.ComputationServiceTest to private newDefaultReport() : AnalysisReportDto from class org.sonar.server.computation.batch.ReportExtractorTest	From	To
Move Method public process_existing_project() : void from class org.sonar.server.computation.ComputationServiceTest to public process_existing_project() : void from class org.sonar.server.computation.activity.CEActivityManagerTest	From	To
Move Method private loadProject(projectKey String) : ComponentDto from class org.sonar.server.computation.ComputationService to private loadProject(projectKey String) : ComponentDto from class org.sonar.server.computation.activity.CEActivityManager	From	To
Move Method private extractReportInDir(item ReportQueue.Item) : File from class org.sonar.server.computation.ComputationService to public extractReportInDir(item ReportQueue.Item) : File from class org.sonar.server.computation.batch.ReportExtractor	From	To
Move Method private saveActivity(report AnalysisReportDto) : void from class org.sonar.server.computation.ComputationService to public saveActivity(report AnalysisReportDto) : void from class org.sonar.server.computation.activity.CEActivityManager	From	To
Rename Variable	1
Rename Variable child : ComponentContainer to ceContainer : ComponentContainer in method public execute(item ReportQueue.Item) : void in class org.sonar.server.computation.ComputationContainer	From	To
Move Attribute	31
Move Attribute private reportReader : BatchReportReader from class org.sonar.server.computation.step.PersistComponentsStep.ComponentContext to private reportReader : BatchReportReader from class org.sonar.server.computation.step.PersistMeasuresStep	From	To
Move Attribute private reportReader : BatchReportReader from class org.sonar.server.computation.step.PersistComponentsStep.ComponentContext to private reportReader : BatchReportReader from class org.sonar.server.computation.step.PersistEventsStep	From	To
Move Attribute private reportReader : BatchReportReader from class org.sonar.server.computation.step.ParseReportStep.IssueDepthTraversalTypeAwareVisitor to private reportReader : BatchReportReader from class org.sonar.server.computation.step.PersistDuplicationsStep	From	To
Move Attribute private reportReader : BatchReportReader from class org.sonar.server.computation.step.PersistComponentsStep.ComponentContext to private reportReader : BatchReportReader from class org.sonar.server.computation.step.PersistComponentsStep	From	To
Move Attribute private reportReader : BatchReportReader from class org.sonar.server.computation.step.PersistComponentsStep.ComponentContext to private reportReader : BatchReportReader from class org.sonar.server.computation.step.PersistProjectLinksStep	From	To
Move Attribute private reportReader : BatchReportReader from class org.sonar.server.computation.step.PersistComponentsStep.ComponentContext to private reportReader : BatchReportReader from class org.sonar.server.computation.step.PersistFileSourcesStep	From	To
Move Attribute private reportReader : BatchReportReader from class org.sonar.server.computation.step.ParseReportStep.IssueDepthTraversalTypeAwareVisitor to private reportReader : BatchReportReader from class org.sonar.server.computation.step.PersistTestsStep	From	To
Move Attribute private reportReader : BatchReportReader from class org.sonar.server.computation.step.PersistComponentsStep.ComponentContext to private reportReader : BatchReportReader from class org.sonar.server.computation.step.SendIssueNotificationsStep	From	To
Move Attribute private reportReader : BatchReportReader from class org.sonar.server.computation.step.ParseReportStep.IssueDepthTraversalTypeAwareVisitor to private reportReader : BatchReportReader from class org.sonar.server.computation.step.PersistFileSourcesStep	From	To
Move Attribute private tempFolder : TempFolder from class org.sonar.server.computation.ComputationService to private tempFolder : TempFolder from class org.sonar.server.computation.batch.ReportExtractor	From	To
Move Attribute private reportReader : BatchReportReader from class org.sonar.server.computation.step.ParseReportStep.IssueDepthTraversalTypeAwareVisitor to private reportReader : BatchReportReader from class org.sonar.server.computation.step.PersistEventsStep	From	To
Move Attribute public tempFolder : JUnitTempFolder from class org.sonar.server.computation.ComputationServiceTest to public tempFolder : JUnitTempFolder from class org.sonar.server.computation.batch.ReportExtractorTest	From	To
Move Attribute package activityArgumentCaptor : ArgumentCaptor<Activity> from class org.sonar.server.computation.ComputationServiceTest to package activityArgumentCaptor : ArgumentCaptor<Activity> from class org.sonar.server.computation.activity.CEActivityManagerTest	From	To
Move Attribute package activityService : ActivityService from class org.sonar.server.computation.ComputationServiceTest to package activityService : ActivityService from class org.sonar.server.computation.activity.CEActivityManagerTest	From	To
Move Attribute private reportReader : BatchReportReader from class org.sonar.server.computation.step.PersistComponentsStep.ComponentContext to private reportReader : BatchReportReader from class org.sonar.server.computation.step.PersistNumberOfDaysSinceLastCommitStep	From	To
Move Attribute private reportReader : BatchReportReader from class org.sonar.server.computation.step.ParseReportStep.IssueDepthTraversalTypeAwareVisitor to private reportReader : BatchReportReader from class org.sonar.server.computation.step.PersistMeasuresStep	From	To
Move Attribute private reportReader : BatchReportReader from class org.sonar.server.computation.step.PersistComponentsStep.ComponentContext to private reportReader : BatchReportReader from class org.sonar.server.computation.step.PopulateComponentsUuidAndKeyStep	From	To
Move Attribute private reportReader : BatchReportReader from class org.sonar.server.computation.step.ParseReportStep.IssueDepthTraversalTypeAwareVisitor to private reportReader : BatchReportReader from class org.sonar.server.computation.step.PersistNumberOfDaysSinceLastCommitStep	From	To
Move Attribute private reportReader : BatchReportReader from class org.sonar.server.computation.step.PersistComponentsStep.ComponentContext to private reportReader : BatchReportReader from class org.sonar.server.computation.step.ParseReportStep	From	To
Move Attribute private reportReader : BatchReportReader from class org.sonar.server.computation.step.ParseReportStep.IssueDepthTraversalTypeAwareVisitor to private reportReader : BatchReportReader from class org.sonar.server.computation.step.PersistComponentsStep	From	To
Move Attribute private reportReader : BatchReportReader from class org.sonar.server.computation.step.PersistComponentsStep.ComponentContext to private reportReader : BatchReportReader from class org.sonar.server.computation.step.PersistDuplicationsStep	From	To
Move Attribute private reportReader : BatchReportReader from class org.sonar.server.computation.step.ParseReportStep.IssueDepthTraversalTypeAwareVisitor to private reportReader : BatchReportReader from class org.sonar.server.computation.step.ParseReportStep	From	To
Move Attribute private reportReader : BatchReportReader from class org.sonar.server.computation.step.ParseReportStep.IssueDepthTraversalTypeAwareVisitor to private reportReader : BatchReportReader from class org.sonar.server.computation.step.SendIssueNotificationsStep	From	To
Move Attribute private reportReader : BatchReportReader from class org.sonar.server.computation.step.ParseReportStep.IssueDepthTraversalTypeAwareVisitor to private reportReader : BatchReportReader from class org.sonar.server.computation.step.PopulateComponentsUuidAndKeyStep	From	To
Move Attribute private reportReader : BatchReportReader from class org.sonar.server.computation.step.ParseReportStep.IssueDepthTraversalTypeAwareVisitor to private reportReader : BatchReportReader from class org.sonar.server.computation.step.PersistProjectLinksStep	From	To
Move Attribute public dbTester : DbTester from class org.sonar.server.computation.ComputationServiceTest to public dbTester : DbTester from class org.sonar.server.computation.activity.CEActivityManagerTest	From	To
Move Attribute private activityService : ActivityService from class org.sonar.server.computation.ComputationService to private activityService : ActivityService from class org.sonar.server.computation.activity.CEActivityManager	From	To
Move Attribute private reportReader : BatchReportReader from class org.sonar.server.computation.step.ParseReportStep.IssueDepthTraversalTypeAwareVisitor to private reportReader : BatchReportReader from class org.sonar.server.computation.ComputationService	From	To
Move Attribute private reportReader : BatchReportReader from class org.sonar.server.computation.step.ParseReportStep.IssueDepthTraversalTypeAwareVisitor to private reportReader : BatchReportReader from class org.sonar.server.computation.issue.IssueComputation	From	To
Move Attribute private reportReader : BatchReportReader from class org.sonar.server.computation.step.PersistComponentsStep.ComponentContext to private reportReader : BatchReportReader from class org.sonar.server.computation.step.PersistTestsStep	From	To
Move Attribute private reportReader : BatchReportReader from class org.sonar.server.computation.step.PersistComponentsStep.ComponentContext to private reportReader : BatchReportReader from class org.sonar.server.computation.ComputationService	From	To
Extract Class	2
Extract Class org.sonar.server.computation.activity.CEActivityManager from class org.sonar.server.computation.ComputationService	From	To
Extract Class org.sonar.server.computation.activity.CEActivityManagerTest from class org.sonar.server.computation.ComputationServiceTest	From	To
Rename Class	1
Rename Class org.sonar.server.computation.batch.FileBatchReportReader renamed to org.sonar.server.computation.batch.CEBatchReportReader	From	To
Rename Attribute	2
Rename Attribute orderedSteps : List<ComputationStep> to ceContainer : CEContainer in class org.sonar.server.computation.step.ComputationSteps	From	To
Rename Attribute activityService : ActivityService to activityManager : CEActivityManager in class org.sonar.server.computation.ComputationService	From	To
Change Attribute Type	2
Change Attribute Type activityService : ActivityService to activityManager : CEActivityManager in class org.sonar.server.computation.ComputationService	From	To
Change Attribute Type orderedSteps : List<ComputationStep> to ceContainer : CEContainer in class org.sonar.server.computation.step.ComputationSteps	From	To
Rename Parameter	2
Rename Parameter activityService : ActivityService to activityManager : CEActivityManager in method public ComputationService(item ReportQueue.Item, steps ComputationSteps, activityManager CEActivityManager, system System2, reportReader BatchReportReader, dbClient DbClient, languageRepository LanguageRepository) in class org.sonar.server.computation.ComputationService	From	To
Rename Parameter s : ComputationStep... to ceContainer : CEContainer in method public ComputationSteps(ceContainer CEContainer) in class org.sonar.server.computation.step.ComputationSteps	From	To

be8707ef18df79c56b14d8296a0955a6f81eae89

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: