c004eacf334304b7a850185fe2cc4d6d521506b0
Files Diff
- Added: 5
- Removed: 13
- Renamed: 0
- Modified: 8
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 1 | ||
| Rename Method public apply_default_permission_template_from_component_id() : void renamed to public applyDefaultPermissionTemplate_from_component_key() : void in class org.sonar.server.permission.PermissionTemplateServiceTest | From | To | |
| Move And Rename Method | 2 | ||
| Move And Rename Method public apply(session DbSession, template PermissionTemplateDto, project ComponentDto, currentUserId Long) : void from class org.sonar.db.permission.PermissionRepository to private copyPermissions(dbSession DbSession, template PermissionTemplateDto, project ComponentDto, projectCreatorUserId Long) : void from class org.sonar.server.permission.PermissionTemplateService | From | To | |
| Move And Rename Method private getApplicablePermissionTemplate(dbSession DbSession, component ComponentDto) : PermissionTemplateDto from class org.sonar.db.permission.PermissionRepository to private findDefaultTemplate(dbSession DbSession, component ComponentDto) : PermissionTemplateDto from class org.sonar.server.permission.PermissionTemplateService | From | To | |
| Change Parameter Type | 1 | ||
| Change Parameter Type permissionRepository : PermissionRepository to settings : Settings in method public PermissionTemplateService(dbClient DbClient, settings Settings, permissionIndexer PermissionIndexer, userSession UserSession) in class org.sonar.server.permission.PermissionTemplateService | From | To | |
| Move Method | 2 | ||
| Move Method private checkAtMostOneMatchForComponentKey(componentKey String, matchingTemplates List<PermissionTemplateDto>) : void from class org.sonar.db.permission.PermissionRepository to private checkAtMostOneMatchForComponentKey(componentKey String, matchingTemplates List<PermissionTemplateDto>) : void from class org.sonar.server.permission.PermissionTemplateService | From | To | |
| Move Method public wouldUserHavePermissionWithDefaultTemplate(dbSession DbSession, currentUserId Long, permission String, projectKey String, qualifier String) : boolean from class org.sonar.db.permission.PermissionRepository to public wouldUserHavePermissionWithDefaultTemplate(dbSession DbSession, userId Long, permission String, branch String, projectKey String, qualifier String) : boolean from class org.sonar.server.permission.PermissionTemplateService | From | To | |
| Rename Variable | 1 | ||
| Rename Variable currentUserId : Integer to userId : Integer in method private createProject(dbSession DbSession, projectKey String, projectBranch String, projectName String) : ComponentDto in class org.sonar.server.computation.queue.ReportSubmitter | From | To | |
| Move Attribute | 1 | ||
| Move Attribute private settings : Settings from class org.sonar.db.permission.PermissionRepository to private settings : Settings from class org.sonar.server.permission.PermissionTemplateService | From | To | |
| Move And Rename Class | 1 | ||
| Move And Rename Class org.sonar.db.permission.PermissionRepositoryTest moved and renamed to org.sonar.server.permission.PermissionTemplateServiceTest | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type underTest : PermissionRepository to underTest : PermissionTemplateService in class org.sonar.server.permission.PermissionTemplateServiceTest | From | To | |
| Rename Parameter | 4 | ||
| Rename Parameter session : DbSession to dbSession : DbSession in method private copyPermissions(dbSession DbSession, template PermissionTemplateDto, project ComponentDto, projectCreatorUserId Long) : void in class org.sonar.server.permission.PermissionTemplateService | From | To | |
| Rename Parameter currentUserId : Long to projectCreatorUserId : Long in method private copyPermissions(dbSession DbSession, template PermissionTemplateDto, project ComponentDto, projectCreatorUserId Long) : void in class org.sonar.server.permission.PermissionTemplateService | From | To | |
| Rename Parameter permissionRepository : PermissionRepository to settings : Settings in method public PermissionTemplateService(dbClient DbClient, settings Settings, permissionIndexer PermissionIndexer, userSession UserSession) in class org.sonar.server.permission.PermissionTemplateService | From | To | |
| Rename Parameter currentUserId : Long to userId : Long in method public wouldUserHavePermissionWithDefaultTemplate(dbSession DbSession, userId Long, permission String, branch String, projectKey String, qualifier String) : boolean in class org.sonar.server.permission.PermissionTemplateService | From | To |