sonarqube c41709236fb221313de5e65377b761f03217a830

c41709236fb221313de5e65377b761f03217a830

Files Diff

Added: 2
Removed: 1
Renamed: 0
Modified: 14

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Rename Method	1
Rename Method private addProjectToPermissionChange(dbSession DbSession, permissionChange PermissionChange, request PermissionRequest) : void renamed to package searchProject(dbSession DbSession, request PermissionRequest) : Optional<ComponentDto> in class org.sonar.server.permission.ws.PermissionDependenciesFinder	From	To
Change Parameter Type	4
Change Parameter Type permissionWsCommons : PermissionWsCommons to permissionChangeBuilder : PermissionChangeBuilder in method public AddGroupAction(dbClient DbClient, permissionChangeBuilder PermissionChangeBuilder, permissionUpdater PermissionUpdater) in class org.sonar.server.permission.ws.AddGroupAction	From	To
Change Parameter Type permissionWsCommons : PermissionWsCommons to permissionChangeBuilder : PermissionChangeBuilder in method public RemoveGroupAction(dbClient DbClient, permissionChangeBuilder PermissionChangeBuilder, permissionUpdater PermissionUpdater) in class org.sonar.server.permission.ws.RemoveGroupAction	From	To
Change Parameter Type permissionWsCommons : PermissionWsCommons to permissionChangeBuilder : PermissionChangeBuilder in method public RemoveUserAction(dbClient DbClient, permissionUpdater PermissionUpdater, permissionChangeBuilder PermissionChangeBuilder) in class org.sonar.server.permission.ws.RemoveUserAction	From	To
Change Parameter Type permissionWsCommons : PermissionWsCommons to permissionWsCommons : PermissionChangeBuilder in method public AddUserAction(dbClient DbClient, permissionUpdater PermissionUpdater, permissionWsCommons PermissionChangeBuilder) in class org.sonar.server.permission.ws.AddUserAction	From	To
Move Method	2
Move Method package buildGroupPermissionChange(dbSession DbSession, request PermissionRequest) : PermissionChange from class org.sonar.server.permission.ws.PermissionWsCommons to package buildGroupPermissionChange(dbSession DbSession, request PermissionRequest) : PermissionChange from class org.sonar.server.permission.ws.PermissionChangeBuilder	From	To
Move Method package buildUserPermissionChange(dbSession DbSession, request PermissionRequest) : PermissionChange from class org.sonar.server.permission.ws.PermissionWsCommons to package buildUserPermissionChange(dbSession DbSession, request PermissionRequest) : PermissionChange from class org.sonar.server.permission.ws.PermissionChangeBuilder	From	To
Rename Variable	1
Rename Variable permissionWsCommons : PermissionWsCommons to dependenciesFinder : PermissionDependenciesFinder in method public setUp() : void in class org.sonar.server.permission.ws.UsersActionTest	From	To
Change Return Type	1
Change Return Type void to Optional<ComponentDto> in method package searchProject(dbSession DbSession, request PermissionRequest) : Optional<ComponentDto> in class org.sonar.server.permission.ws.PermissionDependenciesFinder	From	To
Move Attribute	4
Move Attribute private dbClient : DbClient from class org.sonar.server.permission.ws.PermissionWsCommons to private dbClient : DbClient from class org.sonar.server.permission.ws.GroupsAction	From	To
Move Attribute private dbClient : DbClient from class org.sonar.server.permission.ws.PermissionWsCommons to private dbClient : DbClient from class org.sonar.server.permission.ws.PermissionDependenciesFinder	From	To
Move Attribute private componentFinder : ComponentFinder from class org.sonar.server.permission.ws.PermissionWsCommons to private componentFinder : ComponentFinder from class org.sonar.server.permission.ws.PermissionDependenciesFinder	From	To
Move Attribute private dbClient : DbClient from class org.sonar.server.permission.ws.PermissionWsCommons to private dbClient : DbClient from class org.sonar.server.permission.ws.UsersAction	From	To
Extract Class	2
Extract Class org.sonar.server.permission.ws.PermissionDependenciesFinder from class org.sonar.server.permission.ws.PermissionWsCommons	From	To
Extract Class org.sonar.server.permission.ws.PermissionChangeBuilder from class org.sonar.server.permission.ws.PermissionWsCommons	From	To
Rename Class	2
Rename Class org.sonar.server.permission.ws.PermissionWsCommons renamed to org.sonar.server.permission.ws.PermissionChangeBuilder	From	To
Rename Class org.sonar.server.permission.ws.PermissionWsCommons renamed to org.sonar.server.permission.ws.PermissionDependenciesFinder	From	To
Rename Attribute	6
Rename Attribute permissionWsCommons : PermissionWsCommons to permissionChangeBuilder : PermissionChangeBuilder in class org.sonar.server.permission.ws.AddGroupAction	From	To
Rename Attribute permissionWsCommons : PermissionWsCommons to dependenciesFinder : PermissionDependenciesFinder in class org.sonar.server.permission.ws.GroupsAction	From	To
Rename Attribute permissionWsCommons : PermissionWsCommons to dbClient : DbClient in class org.sonar.server.permission.ws.UsersAction	From	To
Rename Attribute permissionWsCommons : PermissionWsCommons to permissionChangeBuilder : PermissionChangeBuilder in class org.sonar.server.permission.ws.RemoveGroupAction	From	To
Rename Attribute permissionWsCommons : PermissionWsCommons to permissionChangeBuilder : PermissionChangeBuilder in class org.sonar.server.permission.ws.AddUserAction	From	To
Rename Attribute permissionWsCommons : PermissionWsCommons to permissionChangeBuilder : PermissionChangeBuilder in class org.sonar.server.permission.ws.RemoveUserAction	From	To
Change Variable Type	1
Change Variable Type permissionWsCommons : PermissionWsCommons to dependenciesFinder : PermissionDependenciesFinder in method public setUp() : void in class org.sonar.server.permission.ws.UsersActionTest	From	To
Change Attribute Type	6
Change Attribute Type permissionWsCommons : PermissionWsCommons to dbClient : DbClient in class org.sonar.server.permission.ws.UsersAction	From	To
Change Attribute Type permissionWsCommons : PermissionWsCommons to permissionChangeBuilder : PermissionChangeBuilder in class org.sonar.server.permission.ws.RemoveGroupAction	From	To
Change Attribute Type permissionWsCommons : PermissionWsCommons to permissionChangeBuilder : PermissionChangeBuilder in class org.sonar.server.permission.ws.AddUserAction	From	To
Change Attribute Type permissionWsCommons : PermissionWsCommons to permissionChangeBuilder : PermissionChangeBuilder in class org.sonar.server.permission.ws.RemoveUserAction	From	To
Change Attribute Type permissionWsCommons : PermissionWsCommons to permissionChangeBuilder : PermissionChangeBuilder in class org.sonar.server.permission.ws.AddGroupAction	From	To
Change Attribute Type permissionWsCommons : PermissionWsCommons to dependenciesFinder : PermissionDependenciesFinder in class org.sonar.server.permission.ws.GroupsAction	From	To
Rename Parameter	3
Rename Parameter permissionWsCommons : PermissionWsCommons to permissionChangeBuilder : PermissionChangeBuilder in method public RemoveUserAction(dbClient DbClient, permissionUpdater PermissionUpdater, permissionChangeBuilder PermissionChangeBuilder) in class org.sonar.server.permission.ws.RemoveUserAction	From	To
Rename Parameter permissionWsCommons : PermissionWsCommons to permissionChangeBuilder : PermissionChangeBuilder in method public AddGroupAction(dbClient DbClient, permissionChangeBuilder PermissionChangeBuilder, permissionUpdater PermissionUpdater) in class org.sonar.server.permission.ws.AddGroupAction	From	To
Rename Parameter permissionWsCommons : PermissionWsCommons to permissionChangeBuilder : PermissionChangeBuilder in method public RemoveGroupAction(dbClient DbClient, permissionChangeBuilder PermissionChangeBuilder, permissionUpdater PermissionUpdater) in class org.sonar.server.permission.ws.RemoveGroupAction	From	To

c41709236fb221313de5e65377b761f03217a830

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: