cd73d0a82c060fc68d2b6306ab0a6286b5717abf
Files Diff
- Added: 3
- Removed: 2
- Renamed: 0
- Modified: 19
Refactorings reported:
Refactoring Name | Occurences | ||
---|---|---|---|
Change Parameter Type | 5 | ||
Change Parameter Type compressedPlugin : RemotePluginFile to installedFile : InstalledPlugin in method public writePluginInfo(json JsonWriter, pluginInfo PluginInfo, category String, pluginDto PluginDto, installedFile InstalledPlugin) : void in class org.sonar.server.plugins.ws.PluginWSCommons | From | To | |
Change Parameter Type pluginCompression : PluginCompression to pluginFileSystem : PluginFileSystem in method public ServerPluginJarExploder(fs ServerFileSystem, pluginFileSystem PluginFileSystem) in class org.sonar.server.plugins.ServerPluginJarExploder | From | To | |
Change Parameter Type repository : PluginRepository to pluginFs : PluginFileSystem in method public GeneratePluginIndex(serverFs ServerFileSystem, pluginFs PluginFileSystem) in class org.sonar.server.startup.GeneratePluginIndex | From | To | |
Change Parameter Type pluginRepository : ServerPluginRepository to pluginFileSystem : PluginFileSystem in method public InstalledAction(pluginFileSystem PluginFileSystem, updateCenterMatrixFactory UpdateCenterMatrixFactory, dbClient DbClient) in class org.sonar.server.plugins.ws.InstalledAction | From | To | |
Change Parameter Type repository : ServerPluginRepository to pluginFileSystem : PluginFileSystem in method public RegisterPlugins(pluginFileSystem PluginFileSystem, dbClient DbClient, uuidFactory UuidFactory, system System2) in class org.sonar.server.startup.RegisterPlugins | From | To | |
Move Attribute | 2 | ||
Move Attribute public temp : TemporaryFolder from class org.sonar.server.plugins.PluginCompressionTest to public temp : TemporaryFolder from class org.sonar.server.plugins.ws.InstalledActionTest | From | To | |
Move Attribute public temp : TemporaryFolder from class org.sonar.server.plugins.PluginCompressionTest to public temp : TemporaryFolder from class org.sonar.server.plugins.ws.PluginWSCommonsTest | From | To | |
Rename Class | 1 | ||
Rename Class org.sonar.server.plugins.PluginCompression renamed to org.sonar.server.plugins.PluginFileSystem | From | To | |
Merge Parameter | 1 | ||
Merge Parameter [pluginInfo : PluginInfo, pluginDto : PluginDto] to installedFile : InstalledPlugin in method public writePluginInfo(json JsonWriter, pluginInfo PluginInfo, category String, pluginDto PluginDto, installedFile InstalledPlugin) : void in class org.sonar.server.plugins.ws.PluginWSCommons | From | To | |
Extract Variable | 1 | ||
Extract Variable info : PluginInfo in method private plugin(key String, name String) : InstalledPlugin from class org.sonar.server.plugins.ws.InstalledActionTest | From | To | |
Change Variable Type | 3 | ||
Change Variable Type repository : PluginRepository to pluginFileSystem : PluginFileSystem in method public shouldWriteIndex() : void in class org.sonar.server.startup.GeneratePluginIndexTest | From | To | |
Change Variable Type pluginInfo : PluginInfo to plugin : InstalledPlugin in method private writeIndex(indexFile File) : void in class org.sonar.server.startup.GeneratePluginIndex | From | To | |
Change Variable Type repository : PluginRepository to pluginFileSystem : PluginFileSystem in method public shouldThrowWhenUnableToWrite() : void in class org.sonar.server.startup.GeneratePluginIndexTest | From | To | |
Inline Variable | 1 | ||
Inline Variable packer : Pack200.Packer in method private pack200(jarPath Path, toPath Path, pluginKey String) : void from class org.sonar.server.plugins.PluginCompression | From | To | |
Rename Method | 3 | ||
Rename Method private searchPluginInfoList() : SortedSet<PluginInfo> renamed to private loadInstalledPlugins() : SortedSet<InstalledPlugin> in class org.sonar.server.plugins.ws.InstalledAction | From | To | |
Rename Method public add_compressed_plugin_info() : void renamed to public return_compression_fields_if_available() : void in class org.sonar.server.plugins.ws.InstalledActionTest | From | To | |
Rename Method public verify_properties_displayed_in_json_per_plugin() : void renamed to public return_default_fields() : void in class org.sonar.server.plugins.ws.InstalledActionTest | From | To | |
Rename Variable | 4 | ||
Rename Variable jsonWriter : JsonWriter to json : JsonWriter in method public handle(request Request, response Response) : void in class org.sonar.server.plugins.ws.InstalledAction | From | To | |
Rename Variable pluginDtosByKey : Map<String,PluginDto> to dtosByKey : Map<String,PluginDto> in method public handle(request Request, response Response) : void in class org.sonar.server.plugins.ws.InstalledAction | From | To | |
Rename Variable pluginInfo : PluginInfo to plugin : InstalledPlugin in method private writeIndex(indexFile File) : void in class org.sonar.server.startup.GeneratePluginIndex | From | To | |
Rename Variable jar : File to sourceJar : File in method public copy_all_classloader_files_to_dedicated_directory() : void in class org.sonar.server.plugins.ServerPluginJarExploderTest | From | To | |
Change Return Type | 2 | ||
Change Return Type SortedSet<PluginInfo> to SortedSet<InstalledPlugin> in method private loadInstalledPlugins() : SortedSet<InstalledPlugin> in class org.sonar.server.plugins.ws.InstalledAction | From | To | |
Change Return Type PluginInfo to InstalledPlugin in method private plugin(key String, name String) : InstalledPlugin in class org.sonar.server.plugins.ws.InstalledActionTest | From | To | |
Replace Variable With Attribute | 2 | ||
Replace Variable With Attribute repository : PluginRepository to pluginFileSystem : PluginFileSystem in method public shouldThrowWhenUnableToWrite() : void in class org.sonar.server.startup.GeneratePluginIndexTest | From | To | |
Replace Variable With Attribute repository : PluginRepository to pluginFileSystem : PluginFileSystem in method public shouldWriteIndex() : void in class org.sonar.server.startup.GeneratePluginIndexTest | From | To | |
Rename Attribute | 6 | ||
Rename Attribute fileSystem : ServerFileSystem to serverFs : ServerFileSystem in class org.sonar.server.startup.GeneratePluginIndex | From | To | |
Rename Attribute pluginRepository : ServerPluginRepository to pluginFileSystem : PluginFileSystem in class org.sonar.server.plugins.ws.InstalledAction | From | To | |
Rename Attribute serverPluginRepository : ServerPluginRepository to pluginFileSystem : PluginFileSystem in class org.sonar.server.startup.RegisterPluginsTest | From | To | |
Rename Attribute repository : PluginRepository to pluginFs : PluginFileSystem in class org.sonar.server.startup.GeneratePluginIndex | From | To | |
Rename Attribute fileSystem : ServerFileSystem to serverFileSystem : ServerFileSystem in class org.sonar.server.startup.GeneratePluginIndexTest | From | To | |
Rename Attribute pluginCompression : PluginCompression to pluginFileSystem : PluginFileSystem in class org.sonar.server.plugins.ServerPluginJarExploder | From | To | |
Change Attribute Type | 4 | ||
Change Attribute Type pluginRepository : ServerPluginRepository to pluginFileSystem : PluginFileSystem in class org.sonar.server.plugins.ws.InstalledAction | From | To | |
Change Attribute Type serverPluginRepository : ServerPluginRepository to pluginFileSystem : PluginFileSystem in class org.sonar.server.startup.RegisterPluginsTest | From | To | |
Change Attribute Type repository : PluginRepository to pluginFs : PluginFileSystem in class org.sonar.server.startup.GeneratePluginIndex | From | To | |
Change Attribute Type pluginCompression : PluginCompression to pluginFileSystem : PluginFileSystem in class org.sonar.server.plugins.ServerPluginJarExploder | From | To | |
Rename Parameter | 7 | ||
Rename Parameter compressedPlugin : RemotePluginFile to installedFile : InstalledPlugin in method public writePluginInfo(json JsonWriter, pluginInfo PluginInfo, category String, pluginDto PluginDto, installedFile InstalledPlugin) : void in class org.sonar.server.plugins.ws.PluginWSCommons | From | To | |
Rename Parameter toPath : Path to toPack200Path : Path in method private pack200(jarPath Path, toPack200Path Path, pluginKey String) : void in class org.sonar.server.plugins.PluginFileSystem | From | To | |
Rename Parameter fileSystem : ServerFileSystem to serverFs : ServerFileSystem in method public GeneratePluginIndex(serverFs ServerFileSystem, pluginFs PluginFileSystem) in class org.sonar.server.startup.GeneratePluginIndex | From | To | |
Rename Parameter repository : PluginRepository to pluginFs : PluginFileSystem in method public GeneratePluginIndex(serverFs ServerFileSystem, pluginFs PluginFileSystem) in class org.sonar.server.startup.GeneratePluginIndex | From | To | |
Rename Parameter repository : ServerPluginRepository to pluginFileSystem : PluginFileSystem in method public RegisterPlugins(pluginFileSystem PluginFileSystem, dbClient DbClient, uuidFactory UuidFactory, system System2) in class org.sonar.server.startup.RegisterPlugins | From | To | |
Rename Parameter pluginCompression : PluginCompression to pluginFileSystem : PluginFileSystem in method public ServerPluginJarExploder(fs ServerFileSystem, pluginFileSystem PluginFileSystem) in class org.sonar.server.plugins.ServerPluginJarExploder | From | To | |
Rename Parameter pluginRepository : ServerPluginRepository to pluginFileSystem : PluginFileSystem in method public InstalledAction(pluginFileSystem PluginFileSystem, updateCenterMatrixFactory UpdateCenterMatrixFactory, dbClient DbClient) in class org.sonar.server.plugins.ws.InstalledAction | From | To |