ce39ae27e9fdcab9b379bf5d9eb552e78e0d9416
Files Diff
- Added: 3
- Removed: 1
- Renamed: 0
- Modified: 16
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Merge Attribute | 1 | ||
| Merge Attribute [groupName : String, groupId : Long] to request : Request in class org.sonar.server.permission.ws.PermissionRequest.Builder | From | To | |
| Change Parameter Type | 1 | ||
| Change Parameter Type templateId : Long to templateId : long in method private countGroups(session DbSession, query PermissionQuery, templateId long, groupName String) : int in class org.sonar.db.permission.PermissionTemplateDao | From | To | |
| Rename Class | 1 | ||
| Rename Class org.sonar.server.permission.PermissionValueValidator renamed to org.sonar.server.permission.PermissionRequestValidator | From | To | |
| Change Variable Type | 1 | ||
| Change Variable Type session : SqlSession to session : DbSession in method public insertGroupPermission(templateId Long, groupId Long, permission String) : void in class org.sonar.db.permission.PermissionTemplateDao | From | To | |
| Extract Method | 2 | ||
| Extract Method package getGroup(dbSession DbSession, groupId Long, groupName String) : GroupDto extracted from package getGroupName(dbSession DbSession, request PermissionRequest) : String in class org.sonar.server.permission.ws.PermissionDependenciesFinder | From | To | |
| Extract Method public insertGroupPermission(session DbSession, templateId Long, groupId Long, permission String) : void extracted from public insertGroupPermission(templateId Long, groupId Long, permission String) : void in class org.sonar.db.permission.PermissionTemplateDao | From | To | |
| Extract And Move Method | 2 | ||
| Extract And Move Method public checkFound(value T, message String) : T extracted from package getUser(dbSession DbSession, userLogin String) : UserDto in class org.sonar.server.permission.ws.PermissionDependenciesFinder & moved to class org.sonar.server.ws.WsUtils | From | To | |
| Extract And Move Method public checkFound(value T, message String) : T extracted from package getTemplate(templateKey String) : PermissionTemplateDto in class org.sonar.server.permission.ws.PermissionDependenciesFinder & moved to class org.sonar.server.ws.WsUtils | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter errorMessage : String to message : String in method public checkRequest(expression boolean, message String) : void in class org.sonar.server.ws.WsUtils | From | To |