sonarqube cfba7fcb6500d8217bd81ecfcb8f47ec48ad55f2

cfba7fcb6500d8217bd81ecfcb8f47ec48ad55f2

Files Diff

Added: 12
Removed: 5
Renamed: 0
Modified: 41

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Rename Method	6
Rename Method public persistNewExternalRules(dbSession DbSession) : void renamed to public persistNewAddHocRules(dbSession DbSession) : void in class org.sonar.ce.task.projectanalysis.issue.RuleRepositoryRule	From	To
Rename Method public insertNewExternalRuleIfAbsent(ruleKey RuleKey, ruleSupplier Supplier<NewExternalRule>) : void renamed to public addNewAddHocRuleIfAbsent(ruleKey RuleKey, ruleSupplier Supplier<NewAddHocRule>) : void in class org.sonar.ce.task.projectanalysis.issue.RuleRepositoryRule	From	To
Rename Method private toExternalRule(reportIssue ScannerReport.ExternalIssue) : NewExternalRule renamed to private toAdHocRule(reportIssue ScannerReport.ExternalIssue) : NewAddHocRule in class org.sonar.ce.task.projectanalysis.issue.TrackerRawInputFactory.RawLazyInput	From	To
Rename Method public persistNewExternalRules(dbSession DbSession) : void renamed to public persistNewAddHocRules(dbSession DbSession) : void in class org.sonar.ce.task.projectanalysis.issue.RuleRepository	From	To
Rename Method public insertNewExternalRuleIfAbsent(ruleKey RuleKey, ruleSupplier Supplier<NewExternalRule>) : void renamed to public addNewAddHocRuleIfAbsent(ruleKey RuleKey, ruleSupplier Supplier<NewAddHocRule>) : void in class org.sonar.ce.task.projectanalysis.issue.RuleRepository	From	To
Rename Method public persistNewExternalRules(dbSession DbSession) : void renamed to public persistNewAddHocRules(dbSession DbSession) : void in class org.sonar.ce.task.projectanalysis.issue.RuleRepositoryImpl	From	To
Push Down Method	2
Push Down Method public forRule(ruleKey RuleKey) : T from class org.sonar.api.batch.sensor.issue.internal.AbstractDefaultIssue to public forRule(ruleKey RuleKey) : DefaultIssue from class org.sonar.api.batch.sensor.issue.internal.DefaultIssue	From	To
Push Down Method public ruleKey() : RuleKey from class org.sonar.api.batch.sensor.issue.internal.AbstractDefaultIssue to public ruleKey() : RuleKey from class org.sonar.api.batch.sensor.issue.internal.DefaultIssue	From	To
Change Parameter Type	9
Change Parameter Type external : ExternalRuleWrapper to external : AdHocRuleWrapper in method private persistAndIndex(dbSession DbSession, external AdHocRuleWrapper) : void in class org.sonar.ce.task.projectanalysis.issue.RuleRepositoryImpl	From	To
Change Parameter Type issue : ExternalIssue to issue : DefaultExternalIssue in method public store(issue DefaultExternalIssue) : void in class org.sonar.api.batch.sensor.internal.SensorStorage	From	To
Change Parameter Type ruleSupplier : Supplier<NewExternalRule> to ruleSupplier : Supplier<NewAddHocRule> in method public addNewAddHocRuleIfAbsent(ruleKey RuleKey, ruleSupplier Supplier<NewAddHocRule>) : void in class org.sonar.ce.task.projectanalysis.issue.RuleRepositoryRule	From	To
Change Parameter Type externalIssue : ExternalIssue to externalIssue : DefaultExternalIssue in method public store(externalIssue DefaultExternalIssue) : void in class org.sonar.scanner.sensor.DefaultSensorStorage	From	To
Change Parameter Type creator : ExternalRuleCreator to creator : AddHocRuleCreator in method public RuleRepositoryImpl(creator AddHocRuleCreator, dbClient DbClient, analysisMetadataHolder AnalysisMetadataHolder) in class org.sonar.ce.task.projectanalysis.issue.RuleRepositoryImpl	From	To
Change Parameter Type external : NewExternalRule to adHoc : NewAddHocRule in method public persistAndIndex(dbSession DbSession, adHoc NewAddHocRule) : RuleDto in class org.sonar.server.rule.AddHocRuleCreator	From	To
Change Parameter Type externalRule : NewExternalRule to addHocRule : NewAddHocRule in method private AdHocRuleWrapper(addHocRule NewAddHocRule) in class org.sonar.ce.task.projectanalysis.issue.RuleRepositoryImpl.AdHocRuleWrapper	From	To
Change Parameter Type ruleSupplier : Supplier<NewExternalRule> to ruleSupplier : Supplier<NewAddHocRule> in method public addNewAddHocRuleIfAbsent(ruleKey RuleKey, ruleSupplier Supplier<NewAddHocRule>) : void in class org.sonar.ce.task.projectanalysis.issue.RuleRepository	From	To
Change Parameter Type issue : ExternalIssue to issue : DefaultExternalIssue in method public store(issue DefaultExternalIssue) : void in class org.sonar.api.batch.sensor.internal.InMemorySensorStorage	From	To
Inline Method	2
Inline Method private analyse(context SensorContext, language String, repo String) : void inlined to public execute(context SensorContext) : void in class org.sonar.xoo.rule.OneExternalIssuePerLineSensor	From	To
Inline Method private analyse(context SensorContext, language String, repo String) : void inlined to public execute(context SensorContext) : void in class org.sonar.xoo.rule.OnePredefinedRuleExternalIssuePerLineSensor	From	To
Change Return Type	4
Change Return Type NewExternalRule to NewAddHocRule in method private toAdHocRule(reportIssue ScannerReport.ExternalIssue) : NewAddHocRule in class org.sonar.ce.task.projectanalysis.issue.TrackerRawInputFactory.RawLazyInput	From	To
Change Return Type T to DefaultIssue in method public forRule(ruleKey RuleKey) : DefaultIssue in class org.sonar.api.batch.sensor.issue.internal.DefaultIssue	From	To
Change Return Type NewExternalRule to NewAddHocRule in method public getDelegate() : NewAddHocRule in class org.sonar.ce.task.projectanalysis.issue.RuleRepositoryImpl.AdHocRuleWrapper	From	To
Change Return Type NewExternalRule to NewAddHocRule in method public build() : NewAddHocRule in class org.sonar.server.rule.NewAddHocRule.Builder	From	To
Push Down Attribute	1
Push Down Attribute protected ruleKey : RuleKey from class org.sonar.api.batch.sensor.issue.internal.AbstractDefaultIssue to private ruleKey : RuleKey from class org.sonar.api.batch.sensor.issue.internal.DefaultIssue	From	To
Rename Class	6
Rename Class org.sonar.ce.task.projectanalysis.issue.RuleRepositoryImpl.ExternalRuleWrapper renamed to org.sonar.ce.task.projectanalysis.issue.RuleRepositoryImpl.AdHocRuleWrapper	From	To
Rename Class org.sonar.xoo.rule.OneExternalIssueWithDetailsPerLineSensor renamed to org.sonar.xoo.rule.OnePredefinedRuleExternalIssuePerLineSensor	From	To
Rename Class org.sonar.server.rule.NewExternalRule renamed to org.sonar.server.rule.NewAddHocRule	From	To
Rename Class org.sonar.server.rule.ExternalRuleCreator renamed to org.sonar.server.rule.AddHocRuleCreator	From	To
Rename Class org.sonar.server.rule.NewExternalRuleTest renamed to org.sonar.server.rule.NewAddHocRuleTest	From	To
Rename Class org.sonar.server.rule.ExternalRuleCreatorTest renamed to org.sonar.server.rule.AddHocRuleCreatorTest	From	To
Rename Attribute	6
Rename Attribute ACTIVATE_EXTERNAL_ISSUES : String to ACTIVATE : String in class org.sonar.xoo.rule.OneExternalIssuePerLineSensor	From	To
Rename Attribute externalRuleCreator : ExternalRuleCreator to addHocRuleCreator : AddHocRuleCreator in class org.sonar.ce.task.projectanalysis.issue.RuleRepositoryImplTest	From	To
Rename Attribute ACTIVATE_EXTERNAL_ISSUES : String to ACTIVATE : String in class org.sonar.xoo.rule.OnePredefinedRuleExternalIssuePerLineSensor	From	To
Rename Attribute externalRuleCreator : ExternalRuleCreator to addHocRuleCreator : AddHocRuleCreator in class org.sonar.ce.task.projectanalysis.step.PersistIssuesStepTest	From	To
Rename Attribute externalRuleCreator : ExternalRuleCreator to addHocRuleCreator : AddHocRuleCreator in class org.sonar.ce.task.projectanalysis.step.PersistExternalRulesStepTest	From	To
Rename Attribute externalRule : NewExternalRule to addHocRule : NewAddHocRule in class org.sonar.ce.task.projectanalysis.issue.RuleRepositoryImpl.AdHocRuleWrapper	From	To
Change Variable Type	4
Change Variable Type builder : NewExternalRule.Builder to builder : NewAddHocRule.Builder in method public should_build_new_external_rule() : void in class org.sonar.server.rule.NewAddHocRuleTest	From	To
Change Variable Type rule : NewExternalRule to rule : NewAddHocRule in method public should_build_new_external_rule() : void in class org.sonar.server.rule.NewAddHocRuleTest	From	To
Change Variable Type externalRule : NewExternalRule to externalRule : NewAddHocRule in method public create_external_rule() : void in class org.sonar.server.rule.AddHocRuleCreatorTest	From	To
Change Variable Type builder : NewExternalRule.Builder to builder : NewAddHocRule.Builder in method private toAdHocRule(reportIssue ScannerReport.ExternalIssue) : NewAddHocRule in class org.sonar.ce.task.projectanalysis.issue.TrackerRawInputFactory.RawLazyInput	From	To
Change Attribute Type	7
Change Attribute Type newExternalRulesById : Map<RuleKey,NewExternalRule> to newExternalRulesById : Map<RuleKey,NewAddHocRule> in class org.sonar.ce.task.projectanalysis.issue.RuleRepositoryRule	From	To
Change Attribute Type externalRuleCreator : ExternalRuleCreator to addHocRuleCreator : AddHocRuleCreator in class org.sonar.ce.task.projectanalysis.step.PersistIssuesStepTest	From	To
Change Attribute Type underTest : ExternalRuleCreator to underTest : AddHocRuleCreator in class org.sonar.server.rule.AddHocRuleCreatorTest	From	To
Change Attribute Type externalRuleCreator : ExternalRuleCreator to addHocRuleCreator : AddHocRuleCreator in class org.sonar.ce.task.projectanalysis.step.PersistExternalRulesStepTest	From	To
Change Attribute Type externalRule : NewExternalRule to addHocRule : NewAddHocRule in class org.sonar.ce.task.projectanalysis.issue.RuleRepositoryImpl.AdHocRuleWrapper	From	To
Change Attribute Type creator : ExternalRuleCreator to creator : AddHocRuleCreator in class org.sonar.ce.task.projectanalysis.issue.RuleRepositoryImpl	From	To
Change Attribute Type externalRuleCreator : ExternalRuleCreator to addHocRuleCreator : AddHocRuleCreator in class org.sonar.ce.task.projectanalysis.issue.RuleRepositoryImplTest	From	To
Rename Parameter	4
Rename Parameter reportIssue : ScannerReport.ExternalIssue to reportExternalIssue : ScannerReport.ExternalIssue in method private toExternalIssue(lineHashSeq LineHashSequence, reportExternalIssue ScannerReport.ExternalIssue) : DefaultIssue in class org.sonar.ce.task.projectanalysis.issue.TrackerRawInputFactory.RawLazyInput	From	To
Rename Parameter external : NewExternalRule to adHoc : NewAddHocRule in method public persistAndIndex(dbSession DbSession, adHoc NewAddHocRule) : RuleDto in class org.sonar.server.rule.AddHocRuleCreator	From	To
Rename Parameter key : String to engineId : String in method public createExternalRepository(engineId String, language String) : NewRepository in class org.sonar.api.server.rule.RulesDefinition.Context	From	To
Rename Parameter externalRule : NewExternalRule to addHocRule : NewAddHocRule in method private AdHocRuleWrapper(addHocRule NewAddHocRule) in class org.sonar.ce.task.projectanalysis.issue.RuleRepositoryImpl.AdHocRuleWrapper	From	To

cfba7fcb6500d8217bd81ecfcb8f47ec48ad55f2

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: