d5f10d28f6a996af9c34c4757e7dcdf446b43af9
Files Diff
- Added: 2
- Removed: 0
- Renamed: 0
- Modified: 25
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Variable | 4 | ||
| Rename Variable source : ByteSource to result : WSLoaderResult<ByteSource> in method public loadFromWs(userLogins List<String>) : Collection<BatchInput.User> in class org.sonar.batch.repository.user.UserRepository | From | To | |
| Rename Variable indexContent : String to wsResult : WSLoaderResult<String> in method private loadPluginIndex() : String in class org.sonar.batch.bootstrap.BatchPluginInstaller | From | To | |
| Rename Variable indexContent : String to pluginIndex : String in method package listRemotePlugins() : List<RemotePlugin> in class org.sonar.batch.bootstrap.BatchPluginInstaller | From | To | |
| Rename Variable request : ByteSource to result : WSLoaderResult<ByteSource> in method public load(componentKey String, consumer Function<ServerIssue,Void>, incremental boolean) : boolean in class org.sonar.batch.repository.DefaultServerIssuesLoader | From | To | |
| Change Return Type | 10 | ||
| Change Return Type byte[] to WSLoaderResult<byte[]> in method private loadFromCache(id String) : WSLoaderResult<byte[]> in class org.sonar.batch.bootstrap.WSLoader | From | To | |
| Change Return Type void to boolean in method public load(componentKey String, consumer Function<ServerIssue,Void>, incremental boolean) : boolean in class org.sonar.batch.repository.ServerIssuesLoader | From | To | |
| Change Return Type byte[] to WSLoaderResult<byte[]> in method private loadFromCacheFirst(id String) : WSLoaderResult<byte[]> in class org.sonar.batch.bootstrap.WSLoader | From | To | |
| Change Return Type void to boolean in method public load(componentKey String, consumer Function<ServerIssue,Void>, incremental boolean) : boolean in class org.sonar.batch.repository.DefaultServerIssuesLoader | From | To | |
| Change Return Type String to WSLoaderResult<String> in method public loadString(id String) : WSLoaderResult<String> in class org.sonar.batch.bootstrap.WSLoader | From | To | |
| Change Return Type byte[] to WSLoaderResult<byte[]> in method private loadFromServerFirst(id String) : WSLoaderResult<byte[]> in class org.sonar.batch.bootstrap.WSLoader | From | To | |
| Change Return Type byte[] to WSLoaderResult<byte[]> in method private loadFromServer(id String) : WSLoaderResult<byte[]> in class org.sonar.batch.bootstrap.WSLoader | From | To | |
| Change Return Type byte[] to WSLoaderResult<byte[]> in method public load(id String) : WSLoaderResult<byte[]> in class org.sonar.batch.bootstrap.WSLoader | From | To | |
| Change Return Type void to boolean in method public load(componentKey String, consumer Function<ServerIssue,Void>, incremental boolean) : boolean in class org.sonar.batch.mediumtest.BatchMediumTester.FakeServerIssuesLoader | From | To | |
| Change Return Type ByteSource to WSLoaderResult<ByteSource> in method public loadSource(id String) : WSLoaderResult<ByteSource> in class org.sonar.batch.bootstrap.WSLoader | From | To | |
| Extract Attribute | 2 | ||
| Extract Attribute private LOG_MSG : String in class org.sonar.batch.repository.ProjectRepositoriesProvider | From | To | |
| Extract Attribute private LOG_MSG : String in class org.sonar.batch.repository.GlobalRepositoriesProvider | From | To | |
| Extract Superclass | 1 | ||
| Extract Superclass org.sonar.batch.bootstrap.AbstractServerLoader from classes [org.sonar.batch.repository.DefaultGlobalRepositoriesLoader, org.sonar.batch.repository.DefaultProjectRepositoriesLoader, org.sonar.batch.rule.DefaultRulesLoader] | From | To | |
| Change Variable Type | 3 | ||
| Change Variable Type indexContent : String to wsResult : WSLoaderResult<String> in method private loadPluginIndex() : String in class org.sonar.batch.bootstrap.BatchPluginInstaller | From | To | |
| Change Variable Type source : ByteSource to result : WSLoaderResult<ByteSource> in method public loadFromWs(userLogins List<String>) : Collection<BatchInput.User> in class org.sonar.batch.repository.user.UserRepository | From | To | |
| Change Variable Type request : ByteSource to result : WSLoaderResult<ByteSource> in method public load(componentKey String, consumer Function<ServerIssue,Void>, incremental boolean) : boolean in class org.sonar.batch.repository.DefaultServerIssuesLoader | From | To | |
| Extract Method | 4 | ||
| Extract Method private loadPlugins(remotePlugins List<RemotePlugin>) : Map<String,PluginInfo> extracted from public installRemotes() : Map<String,PluginInfo> in class org.sonar.batch.bootstrap.BatchPluginInstaller | From | To | |
| Extract Method private loadPluginIndex() : String extracted from package listRemotePlugins() : List<RemotePlugin> in class org.sonar.batch.bootstrap.BatchPluginInstaller | From | To | |
| Extract Method private assertResult(result WSLoaderResult<T>, expected T, fromCache boolean) : void extracted from public dont_retry_server() : void in class org.sonar.batch.bootstrap.WSLoaderTest | From | To | |
| Extract Method private updateCache(id String, value byte[]) : void extracted from private loadFromServer(id String) : byte[] in class org.sonar.batch.bootstrap.WSLoader | From | To |