d82358c63d0fb979fb3cc27429a42ec833dc161a
Files Diff
- Added: 6
- Removed: 4
- Renamed: 0
- Modified: 12
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 1 | ||
| Rename Method public validate_token_fails_with_unauthorized_when_user_is_disabled() : void renamed to public validate_token_removes_session_when_user_is_disabled() : void in class org.sonar.server.authentication.JwtHttpHandlerTest | From | To | |
| Change Return Type | 3 | ||
| Change Return Type void to Optional<UserDto> in method private validate(request HttpServletRequest, response HttpServletResponse) : Optional<UserDto> in class org.sonar.server.authentication.JwtHttpHandler | From | To | |
| Change Return Type Optional<String> to java.util.Optional<String> in method public authenticate(token String) : java.util.Optional<String> in class org.sonar.server.usertoken.UserTokenAuthenticator | From | To | |
| Change Return Type void to Optional<UserDto> in method private validateToken(tokenEncoded String, request HttpServletRequest, response HttpServletResponse) : Optional<UserDto> in class org.sonar.server.authentication.JwtHttpHandler | From | To | |
| Move Attribute | 8 | ||
| Move Attribute private threadLocalUserSession : ThreadLocalUserSession from class org.sonar.server.authentication.JwtHttpHandler to private threadLocalUserSession : ThreadLocalUserSession from class org.sonar.server.authentication.OAuth2ContextFactory | From | To | |
| Move Attribute package threadLocalUserSession : ThreadLocalUserSession from class org.sonar.server.authentication.JwtHttpHandlerTest to private threadLocalUserSession : ThreadLocalUserSession from class org.sonar.server.authentication.BaseContextFactory | From | To | |
| Move Attribute package threadLocalUserSession : ThreadLocalUserSession from class org.sonar.server.authentication.JwtHttpHandlerTest to package threadLocalUserSession : ThreadLocalUserSession from class org.sonar.server.authentication.BaseContextFactoryTest | From | To | |
| Move Attribute package threadLocalUserSession : ThreadLocalUserSession from class org.sonar.server.authentication.JwtHttpHandlerTest to package threadLocalUserSession : ThreadLocalUserSession from class org.sonar.server.authentication.OAuth2ContextFactoryTest | From | To | |
| Move Attribute private threadLocalUserSession : ThreadLocalUserSession from class org.sonar.server.authentication.JwtHttpHandler to package threadLocalUserSession : ThreadLocalUserSession from class org.sonar.server.authentication.OAuth2ContextFactoryTest | From | To | |
| Move Attribute private threadLocalUserSession : ThreadLocalUserSession from class org.sonar.server.authentication.JwtHttpHandler to private threadLocalUserSession : ThreadLocalUserSession from class org.sonar.server.authentication.BaseContextFactory | From | To | |
| Move Attribute package threadLocalUserSession : ThreadLocalUserSession from class org.sonar.server.authentication.JwtHttpHandlerTest to private threadLocalUserSession : ThreadLocalUserSession from class org.sonar.server.authentication.OAuth2ContextFactory | From | To | |
| Move Attribute private threadLocalUserSession : ThreadLocalUserSession from class org.sonar.server.authentication.JwtHttpHandler to package threadLocalUserSession : ThreadLocalUserSession from class org.sonar.server.authentication.BaseContextFactoryTest | From | To | |
| Rename Class | 1 | ||
| Rename Class org.sonar.server.authentication.ValidateJwtTokenFilterTest renamed to org.sonar.server.authentication.UserSessionInitializerTest | From | To | |
| Move And Rename Class | 2 | ||
| Move And Rename Class org.sonar.server.authentication.AuthLoginAction moved and renamed to org.sonar.server.authentication.ws.LoginAction | From | To | |
| Move And Rename Class org.sonar.server.authentication.AuthLoginActionTest moved and renamed to org.sonar.server.authentication.ws.LoginActionTest | From | To | |
| Replace Variable With Attribute | 2 | ||
| Replace Variable With Attribute userSession : ThreadLocalUserSession to userSessionInitializer : UserSessionInitializer in method private init() : void in class org.sonar.server.user.UserSessionFilter | From | To | |
| Replace Variable With Attribute userSession : ThreadLocalUserSession to userSessionInitializer : UserSessionInitializer in method private isInitialized() : boolean in class org.sonar.server.user.UserSessionFilter | From | To | |
| Change Variable Type | 2 | ||
| Change Variable Type userSession : ThreadLocalUserSession to userSessionInitializer : UserSessionInitializer in method private isInitialized() : boolean in class org.sonar.server.user.UserSessionFilter | From | To | |
| Change Variable Type userSession : ThreadLocalUserSession to userSessionInitializer : UserSessionInitializer in method private init() : void in class org.sonar.server.user.UserSessionFilter | From | To | |
| Change Attribute Type | 3 | ||
| Change Attribute Type underTest : AuthLoginAction to underTest : LoginAction in class org.sonar.server.authentication.ws.LoginActionTest | From | To | |
| Change Attribute Type underTest : ValidateJwtTokenFilter to underTest : UserSessionInitializer in class org.sonar.server.authentication.UserSessionInitializerTest | From | To | |
| Change Attribute Type userSession : UserSessionRule to userSession : ThreadLocalUserSession in class org.sonar.server.authentication.UserSessionInitializerTest | From | To | |
| Extract Method | 2 | ||
| Extract Method private isInitialized() : boolean extracted from public doFilter(servletRequest ServletRequest, servletResponse ServletResponse, chain FilterChain) : void in class org.sonar.server.user.UserSessionFilter | From | To | |
| Extract Method private init() : void extracted from public doFilter(servletRequest ServletRequest, servletResponse ServletResponse, chain FilterChain) : void in class org.sonar.server.user.UserSessionFilter | From | To |