da5c6379ba907e7b2d22f8bcfd0a91b35dd6e200
Files Diff
- Added: 1
- Removed: 1
- Renamed: 0
- Modified: 7
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 3 | ||
| Rename Method public return_license_type_property_set() : void renamed to public return_license_type_in_property_set() : void in class org.sonar.server.setting.ws.ListDefinitionsActionTest | From | To | |
| Rename Method public fail_when_not_system_admin() : void renamed to public fail_when_user_has_not_project_browse_permission() : void in class org.sonar.server.setting.ws.ListDefinitionsActionTest | From | To | |
| Rename Method private getComponent(dbSession DbSession, wsRequest ListDefinitionsRequest) : Optional<ComponentDto> renamed to private loadComponent(valuesRequest ListDefinitionsRequest) : Optional<ComponentDto> in class org.sonar.server.setting.ws.ListDefinitionsAction | From | To | |
| Change Parameter Type | 1 | ||
| Change Parameter Type setting : Setting to settingKey : String in method private isLicenseRelated(settingKey String) : boolean in class org.sonar.server.setting.ws.SettingsPermissionPredicates | From | To | |
| Move Method | 3 | ||
| Move Method private isLicenseRelated(setting Setting) : boolean from class org.sonar.server.setting.ws.ValuesAction to private isLicenseRelated(settingKey String) : boolean from class org.sonar.server.setting.ws.SettingsPermissionPredicates | From | To | |
| Move Method private isVisible(component Optional<ComponentDto>) : Predicate<Setting> from class org.sonar.server.setting.ws.ValuesAction to package isVisible(settingKey String, component Optional<ComponentDto>) : boolean from class org.sonar.server.setting.ws.SettingsPermissionPredicates | From | To | |
| Move Method private hasAdminPermission(component Optional<ComponentDto>) : boolean from class org.sonar.server.setting.ws.ValuesAction to private hasAdminPermission(component Optional<ComponentDto>) : boolean from class org.sonar.server.setting.ws.SettingsPermissionPredicates | From | To | |
| Change Return Type | 1 | ||
| Change Return Type Predicate<Setting> to boolean in method package isVisible(settingKey String, component Optional<ComponentDto>) : boolean in class org.sonar.server.setting.ws.SettingsPermissionPredicates | From | To | |
| Move Attribute | 3 | ||
| Move Attribute private LICENSE_HASH_SUFFIX : String from class org.sonar.server.setting.ws.ValuesAction to package LICENSE_HASH_SUFFIX : String from class org.sonar.server.setting.ws.SettingsPermissionPredicates | From | To | |
| Move Attribute private SECURED_SUFFIX : String from class org.sonar.server.setting.ws.ValuesAction to private SECURED_SUFFIX : String from class org.sonar.server.setting.ws.SettingsPermissionPredicates | From | To | |
| Move Attribute private LICENSE_SUFFIX : String from class org.sonar.server.setting.ws.ValuesAction to package LICENSE_SUFFIX : String from class org.sonar.server.setting.ws.SettingsPermissionPredicates | From | To | |
| Extract Class | 1 | ||
| Extract Class org.sonar.server.setting.ws.SettingsPermissionPredicates from class org.sonar.server.setting.ws.ValuesAction | From | To | |
| Extract Variable | 1 | ||
| Extract Variable component : ComponentDto in method private loadComponent(valuesRequest ListDefinitionsRequest) : Optional<ComponentDto> from class org.sonar.server.setting.ws.ListDefinitionsAction | From | To | |
| Rename Parameter | 2 | ||
| Rename Parameter setting : Setting to settingKey : String in method private isLicenseRelated(settingKey String) : boolean in class org.sonar.server.setting.ws.SettingsPermissionPredicates | From | To | |
| Rename Parameter wsRequest : ListDefinitionsRequest to valuesRequest : ListDefinitionsRequest in method private loadComponent(valuesRequest ListDefinitionsRequest) : Optional<ComponentDto> in class org.sonar.server.setting.ws.ListDefinitionsAction | From | To |