e461d574c67ae1b3433e6314a1c938ef4660a2d5
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 3
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 2 | ||
| Rename Method private getComponentsPerQualifiers(more String, queryBuilder ComponentIndexQuery.Builder) : ComponentIndexResults renamed to private loadSuggestions(query String, more String, recentlyBrowsedKeys Set<String>, qualifiers List<String>) : SuggestionsWsResponse in class org.sonar.server.component.ws.SuggestionsAction | From | To | |
| Rename Method private toResponse(componentsPerQualifiers ComponentIndexResults, recentlyBrowsedKeys Set<String>, favoriteKeys Set<String>, warning String) : SuggestionsWsResponse renamed to private buildResponse(recentlyBrowsedKeys Set<String>, favoriteUuids Set<String>, componentsPerQualifiers ComponentIndexResults, dbSession DbSession, stream Stream<ComponentDto>) : SuggestionsWsResponse.Builder in class org.sonar.server.component.ws.SuggestionsAction | From | To | |
| Change Return Type | 3 | ||
| Change Return Type SuggestionsWsResponse to SuggestionsWsResponse.Builder in method private buildResponse(recentlyBrowsedKeys Set<String>, favoriteUuids Set<String>, componentsPerQualifiers ComponentIndexResults, dbSession DbSession, stream Stream<ComponentDto>) : SuggestionsWsResponse.Builder in class org.sonar.server.component.ws.SuggestionsAction | From | To | |
| Change Return Type ComponentIndexResults to SuggestionsWsResponse in method private loadSuggestions(query String, more String, recentlyBrowsedKeys Set<String>, qualifiers List<String>) : SuggestionsWsResponse in class org.sonar.server.component.ws.SuggestionsAction | From | To | |
| Change Return Type String to Optional<String> in method private getWarning(query String) : Optional<String> in class org.sonar.server.component.ws.SuggestionsAction | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute actionTester : WsActionTester to ws : WsActionTester in class org.sonar.server.component.ws.SuggestionsActionTest | From | To | |
| Extract Method | 5 | ||
| Extract Method private loadSuggestionsWithSearch(query String, more String, recentlyBrowsedKeys Set<String>, qualifiers List<String>) : SuggestionsWsResponse extracted from private getComponentsPerQualifiers(more String, queryBuilder ComponentIndexQuery.Builder) : ComponentIndexResults in class org.sonar.server.component.ws.SuggestionsAction | From | To | |
| Extract Method private loadOrganizations(dbSession DbSession, components Collection<ComponentDto>) : Map<String,OrganizationDto> extracted from private toResponse(componentsPerQualifiers ComponentIndexResults, recentlyBrowsedKeys Set<String>, favoriteKeys Set<String>, warning String) : SuggestionsWsResponse in class org.sonar.server.component.ws.SuggestionsAction | From | To | |
| Extract Method private loadProjects(dbSession DbSession, components Collection<ComponentDto>) : Map<String,ComponentDto> extracted from private toResponse(componentsPerQualifiers ComponentIndexResults, recentlyBrowsedKeys Set<String>, favoriteKeys Set<String>, warning String) : SuggestionsWsResponse in class org.sonar.server.component.ws.SuggestionsAction | From | To | |
| Extract Method private toResponse(componentsPerQualifiers ComponentIndexResults, recentlyBrowsedKeys Set<String>, favoriteUuids Set<String>, organizationsByUuids Map<String,OrganizationDto>, componentsByUuids Map<String,ComponentDto>, projectsByUuids Map<String,ComponentDto>) : SuggestionsWsResponse.Builder extracted from private toResponse(componentsPerQualifiers ComponentIndexResults, recentlyBrowsedKeys Set<String>, favoriteKeys Set<String>, warning String) : SuggestionsWsResponse in class org.sonar.server.component.ws.SuggestionsAction | From | To | |
| Extract Method private getRecentlyBrowsedKeys(wsRequest Request) : Set<String> extracted from public handle(wsRequest Request, wsResponse Response) : void in class org.sonar.server.component.ws.SuggestionsAction | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type MAXIMUM_RECENTLY_BROWSED : long to MAXIMUM_RECENTLY_BROWSED : int in class org.sonar.server.component.ws.SuggestionsAction | From | To | |
| Rename Parameter | 4 | ||
| Rename Parameter more : String to query : String in method private loadSuggestions(query String, more String, recentlyBrowsedKeys Set<String>, qualifiers List<String>) : SuggestionsWsResponse in class org.sonar.server.component.ws.SuggestionsAction | From | To | |
| Rename Parameter favoriteKeys : Set<String> to favoriteUuids : Set<String> in method private toSuggestion(hit ComponentHit, recentlyBrowsedKeys Set<String>, favoriteUuids Set<String>, componentsByUuids Map<String,ComponentDto>, organizationByUuids Map<String,OrganizationDto>, projectsByUuids Map<String,ComponentDto>) : Suggestion in class org.sonar.server.component.ws.SuggestionsAction | From | To | |
| Rename Parameter favoriteKeys : Set<String> to favoriteUuids : Set<String> in method private toCategories(componentsPerQualifiers ComponentIndexResults, recentlyBrowsedKeys Set<String>, favoriteUuids Set<String>, componentsByUuids Map<String,ComponentDto>, organizationByUuids Map<String,OrganizationDto>, projectsByUuids Map<String,ComponentDto>) : List<Category> in class org.sonar.server.component.ws.SuggestionsAction | From | To | |
| Rename Parameter favoriteKeys : Set<String> to favoriteUuids : Set<String> in method private buildResponse(recentlyBrowsedKeys Set<String>, favoriteUuids Set<String>, componentsPerQualifiers ComponentIndexResults, dbSession DbSession, stream Stream<ComponentDto>) : SuggestionsWsResponse.Builder in class org.sonar.server.component.ws.SuggestionsAction | From | To |