ebfad7894a43bc485b53caaec66b0cb8a0971b72
Files Diff
- Added: 3
- Removed: 3
- Renamed: 0
- Modified: 4
Refactorings reported:
Refactoring Name | Occurences | ||
---|---|---|---|
Inline Method | 1 | ||
Inline Method private failIfAuthenticationIsRequired() : void inlined to private loadUserSession(request HttpServletRequest, response HttpServletResponse, urlSupportsSystemPasscode boolean) : void in class org.sonar.server.authentication.UserSessionInitializer | From | To | |
Change Return Type | 2 | ||
Change Return Type Optional<UserDto> to UserSession in method public authenticate(request HttpServletRequest, response HttpServletResponse) : UserSession in class org.sonar.server.authentication.RequestAuthenticator | From | To | |
Change Return Type Optional<UserDto> to UserSession in method public authenticate(request HttpServletRequest, response HttpServletResponse) : UserSession in class org.sonar.server.authentication.RequestAuthenticatorImpl | From | To | |
Rename Class | 3 | ||
Rename Class org.sonar.server.authentication.AuthenticatorsImplTest renamed to org.sonar.server.authentication.RequestAuthenticatorImplTest | From | To | |
Rename Class org.sonar.server.authentication.AuthenticatorsImpl renamed to org.sonar.server.authentication.RequestAuthenticatorImpl | From | To | |
Rename Class org.sonar.server.authentication.Authenticators renamed to org.sonar.server.authentication.RequestAuthenticator | From | To | |
Rename Attribute | 4 | ||
Rename Attribute userSession : ThreadLocalUserSession to threadLocalSession : ThreadLocalUserSession in class org.sonar.server.authentication.UserSessionInitializerTest | From | To | |
Rename Attribute user : UserDto to A_USER : UserDto in class org.sonar.server.authentication.RequestAuthenticatorImplTest | From | To | |
Rename Attribute authenticators : Authenticators to authenticator : RequestAuthenticator in class org.sonar.server.authentication.UserSessionInitializerTest | From | To | |
Rename Attribute authenticators : Authenticators to requestAuthenticator : RequestAuthenticator in class org.sonar.server.authentication.UserSessionInitializer | From | To | |
Extract Method | 1 | ||
Extract Method private loadUser(request HttpServletRequest, response HttpServletResponse) : Optional<UserDto> extracted from public authenticate(request HttpServletRequest, response HttpServletResponse) : Optional<UserDto> in class org.sonar.server.authentication.RequestAuthenticatorImpl | From | To | |
Change Attribute Type | 3 | ||
Change Attribute Type authenticators : Authenticators to authenticator : RequestAuthenticator in class org.sonar.server.authentication.UserSessionInitializerTest | From | To | |
Change Attribute Type authenticators : Authenticators to requestAuthenticator : RequestAuthenticator in class org.sonar.server.authentication.UserSessionInitializer | From | To | |
Change Attribute Type underTest : Authenticators to underTest : RequestAuthenticator in class org.sonar.server.authentication.RequestAuthenticatorImplTest | From | To | |
Rename Parameter | 1 | ||
Rename Parameter usingPasscode : boolean to urlSupportsSystemPasscode : boolean in method private loadUserSession(request HttpServletRequest, response HttpServletResponse, urlSupportsSystemPasscode boolean) : void in class org.sonar.server.authentication.UserSessionInitializer | From | To |