sonarqube f0b34e1199e974237c78870a4fca510c23addccd

f0b34e1199e974237c78870a4fca510c23addccd

Files Diff

Added: 12
Removed: 2
Renamed: 0
Modified: 24

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Rename Method	2
Rename Method protected getComponentByType(tClass Class<T>) : T renamed to protected getAll(tClass Class<T>) : List<T> in class org.sonar.server.platform.platformlevel.PlatformLevel	From	To
Rename Method public getUrl_returns_http_localhost_9000_when_serverBaseUrl_is_empty() : void renamed to public test_runtime() : void in class org.sonar.server.platform.ServerImplTest	From	To
Move And Rename Method	19
Move And Rename Method public get_context_path_from_settings() : void from class org.sonar.server.platform.ServerImplTest to public context_path_is_configured() : void from class org.sonar.server.platform.UrlSettingsTest	From	To
Move And Rename Method public get_public_root_url() : void from class org.sonar.server.platform.ServerImplTest to public base_url_is_configured() : void from class org.sonar.server.platform.UrlSettingsTest	From	To
Move And Rename Method public getUrl_returns_serverBaseUrl_it_is_non_empty() : void from class org.sonar.server.platform.ServerImplTest to public base_url_is_serverBaseUrl_if_non_empty() : void from class org.sonar.server.platform.UrlSettingsTest	From	To
Move And Rename Method public getUrl_throws_NFE_when_port_not_an_int() : void from class org.sonar.server.platform.ServerImplTest to public getBaseUrl_throws_NFE_when_port_not_an_int() : void from class org.sonar.server.platform.UrlSettingsTest	From	To
Move And Rename Method public getUrl_returns_http_localhost_900_specified_context_when_context_is_set() : void from class org.sonar.server.platform.ServerImplTest to public base_url_is_http_localhost_900_specified_context_when_context_is_set() : void from class org.sonar.server.platform.UrlSettingsTest	From	To
Move And Rename Method public is_dev() : void from class org.sonar.server.platform.ServerImplTest to public dev_mode_is_enabled() : void from class org.sonar.server.platform.UrlSettingsTest	From	To
Move And Rename Method public getUrl_returns_http_specified_host_9000_when_host_is_set() : void from class org.sonar.server.platform.ServerImplTest to public base_url_is_http_specified_host_9000_when_host_is_set() : void from class org.sonar.server.platform.UrlSettingsTest	From	To
Move And Rename Method public getUrl_returns_http_specified_host_no_port_when_host_is_set_and_port_is_80() : void from class org.sonar.server.platform.ServerImplTest to public base_url_is_http_specified_host_no_port_when_host_is_set_and_port_is_80() : void from class org.sonar.server.platform.UrlSettingsTest	From	To
Move And Rename Method public is_secured_on_secured_server() : void from class org.sonar.server.platform.ServerImplTest to public is_secured_on_https_server() : void from class org.sonar.server.platform.UrlSettingsTest	From	To
Move And Rename Method public getUrl_returns_http_localhost_9000_when_host_set_to_0_0_0_0() : void from class org.sonar.server.platform.ServerImplTest to public base_url_is_http_localhost_9000_when_host_set_to_0_0_0_0() : void from class org.sonar.server.platform.UrlSettingsTest	From	To
Move And Rename Method public getUrl_returns_http_localhost_no_port_when_port_is_80() : void from class org.sonar.server.platform.ServerImplTest to public base_url_is_http_localhost_no_port_when_port_is_80() : void from class org.sonar.server.platform.UrlSettingsTest	From	To
Move And Rename Method private computeUrl() : String from class org.sonar.server.platform.ServerImpl to private computeBaseUrl() : String from class org.sonar.server.platform.UrlSettings	From	To
Move And Rename Method public getUrl_returns_http_localhost_specified_port_when_port_is_set() : void from class org.sonar.server.platform.ServerImplTest to public base_url_is_http_localhost_specified_port_when_port_is_set() : void from class org.sonar.server.platform.UrlSettingsTest	From	To
Move And Rename Method public getUrl_returns_http_localhost_9000_when_not_settings_are_set() : void from class org.sonar.server.platform.ServerImplTest to public base_url_is_http_localhost_9000_when_host_set_to_0_0_0_0() : void from class org.sonar.server.platform.UrlSettingsTest	From	To
Move And Rename Method public is_secured_on_not_secured_server() : void from class org.sonar.server.platform.ServerImplTest to public is_not_secured_if_http() : void from class org.sonar.server.platform.UrlSettingsTest	From	To
Move And Rename Method public get_default_public_root_url() : void from class org.sonar.server.platform.ServerImplTest to public default_url() : void from class org.sonar.server.platform.UrlSettingsTest	From	To
Move And Rename Method public getUrl_returns_http_localhost_9000_when_serverBaseUrl_is_null() : void from class org.sonar.server.platform.ServerImplTest to public base_url_is_http_localhost_9000_when_serverBaseUrl_is_null() : void from class org.sonar.server.platform.UrlSettingsTest	From	To
Move And Rename Method public getUrl_returns_http_localhost_9000_when_port_is_0() : void from class org.sonar.server.platform.ServerImplTest to public base_url_is_http_localhost_9000_when_port_is_0() : void from class org.sonar.server.platform.UrlSettingsTest	From	To
Move And Rename Method public getUrl_does_not_cache_returned_value() : void from class org.sonar.server.platform.ServerImplTest to public getBaseUrl_does_not_cache_returned_value() : void from class org.sonar.server.platform.UrlSettingsTest	From	To
Change Parameter Type	2
Change Parameter Type persistentSettings : PersistentSettings to dbClient : DbClient in method public StartupMetadataPersister(metadata StartupMetadata, dbClient DbClient) in class org.sonar.server.platform.StartupMetadataPersister	From	To
Change Parameter Type server : Server to metadata : StartupMetadata in method public StartupMetadataPersister(metadata StartupMetadata, dbClient DbClient) in class org.sonar.server.platform.StartupMetadataPersister	From	To
Move Method	8
Move Method private appendHost(host String, res StringBuilder) : void from class org.sonar.server.platform.ServerImpl to private appendHost(host String, res StringBuilder) : void from class org.sonar.server.platform.UrlSettings	From	To
Move Method private appendPort(port int, res StringBuilder) : void from class org.sonar.server.platform.ServerImpl to private appendPort(port int, res StringBuilder) : void from class org.sonar.server.platform.UrlSettings	From	To
Move Method private appendContext(context String, res StringBuilder) : void from class org.sonar.server.platform.ServerImpl to private appendContext(context String, res StringBuilder) : void from class org.sonar.server.platform.UrlSettings	From	To
Move Method public use_default_context_path() : void from class org.sonar.server.platform.ServerImplTest to public use_default_context_path() : void from class org.sonar.server.platform.UrlSettingsTest	From	To
Move Method private read(filename String) : Properties from class org.sonar.server.platform.ServerImpl to private read(filePath String) : Properties from class org.sonar.server.platform.LogServerVersion	From	To
Move Method public start() : void from class org.sonar.server.platform.ServerImpl to public start() : void from class org.sonar.server.platform.LogServerVersion	From	To
Move Method public sanitize_context_path_from_settings() : void from class org.sonar.server.platform.ServerImplTest to public sanitize_context_path_from_settings() : void from class org.sonar.server.platform.UrlSettingsTest	From	To
Move Method public stop() : void from class org.sonar.server.platform.ServerImpl to public stop() : void from class org.sonar.server.platform.LogServerVersion	From	To
Change Return Type	1
Change Return Type T to List<T> in method protected getAll(tClass Class<T>) : List<T> in class org.sonar.server.platform.platformlevel.PlatformLevel	From	To
Move Attribute	8
Move Attribute private HOST_PROPERTY : String from class org.sonar.server.platform.ServerImplTest to private HOST_PROPERTY : String from class org.sonar.server.platform.UrlSettingsTest	From	To
Move Attribute private DEFAULT_HTTP_PORT : int from class org.sonar.server.platform.ServerImpl to private DEFAULT_HTTP_PORT : int from class org.sonar.server.platform.UrlSettings	From	To
Move Attribute private contextPath : String from class org.sonar.server.platform.ServerImpl to private contextPath : String from class org.sonar.server.platform.UrlSettings	From	To
Move Attribute private LOG : Logger from class org.sonar.server.platform.ServerImpl to private LOG : Logger from class org.sonar.server.platform.LogServerVersion	From	To
Move Attribute private ALL_IPS_HOST : String from class org.sonar.server.platform.ServerImpl to private ALL_IPS_HOST : String from class org.sonar.server.platform.UrlSettings	From	To
Move Attribute public DEFAULT_PORT : int from class org.sonar.server.platform.ServerImpl to private DEFAULT_PORT : int from class org.sonar.server.platform.UrlSettings	From	To
Move Attribute private CONTEXT_PROPERTY : String from class org.sonar.server.platform.ServerImplTest to private CONTEXT_PROPERTY : String from class org.sonar.server.platform.UrlSettingsTest	From	To
Move Attribute private PORT_PORPERTY : String from class org.sonar.server.platform.ServerImplTest to private PORT_PORPERTY : String from class org.sonar.server.platform.UrlSettingsTest	From	To
Extract Class	3
Extract Class org.sonar.server.platform.LogServerVersion from class org.sonar.server.platform.ServerImpl	From	To
Extract Class org.sonar.server.platform.UrlSettings from class org.sonar.server.platform.ServerImpl	From	To
Extract Class org.sonar.server.platform.UrlSettingsTest from class org.sonar.server.platform.ServerImplTest	From	To
Move And Rename Class	1
Move And Rename Class org.sonar.server.startup.ServerMetadataPersister moved and renamed to org.sonar.server.platform.StartupMetadataPersister	From	To
Rename Attribute	4
Rename Attribute server : Server to metadata : StartupMetadata in class org.sonar.server.platform.StartupMetadataPersister	From	To
Rename Attribute properties : Properties to bootstrapProperties : Properties in class org.sonar.server.platform.ServerSettingsImpl	From	To
Rename Attribute underTest : File to index : File in class org.sonar.server.startup.GeneratePluginIndexTest	From	To
Rename Attribute persistentSettings : PersistentSettings to dbClient : DbClient in class org.sonar.server.platform.StartupMetadataPersister	From	To
Change Attribute Type	2
Change Attribute Type server : Server to metadata : StartupMetadata in class org.sonar.server.platform.StartupMetadataPersister	From	To
Change Attribute Type persistentSettings : PersistentSettings to dbClient : DbClient in class org.sonar.server.platform.StartupMetadataPersister	From	To
Rename Parameter	4
Rename Parameter persistentSettings : PersistentSettings to dbClient : DbClient in method public StartupMetadataPersister(metadata StartupMetadata, dbClient DbClient) in class org.sonar.server.platform.StartupMetadataPersister	From	To
Rename Parameter server : Server to metadata : StartupMetadata in method public StartupMetadataPersister(metadata StartupMetadata, dbClient DbClient) in class org.sonar.server.platform.StartupMetadataPersister	From	To
Rename Parameter properties : Properties to bootstrapProperties : Properties in method public ServerSettingsImpl(definitions PropertyDefinitions, bootstrapProperties Properties) in class org.sonar.server.platform.ServerSettingsImpl	From	To
Rename Parameter filename : String to filePath : String in method private read(filePath String) : Properties in class org.sonar.server.platform.LogServerVersion	From	To

f0b34e1199e974237c78870a4fca510c23addccd

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: