f4d9bd4f139e9300dc08adceb370b660b1ec220b
Files Diff
- Added: 3
- Removed: 0
- Renamed: 0
- Modified: 8
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 3 | ||
| Rename Method private getDefinitions(keys Set<String>) : List<PropertyDefinition> renamed to private loadDefaultSettings(keys Set<String>) : List<Setting> in class org.sonar.server.settings.ws.ValuesAction | From | To | |
| Rename Method private processDefinitions() : void renamed to private processSettings() : void in class org.sonar.server.settings.ws.ValuesAction.ValuesResponseBuilder | From | To | |
| Rename Method public selectComponentPropertiesByKeys(session DbSession, keys Set<String>, componentId long) : List<PropertyDto> renamed to public selectPropertiesByKeysAndComponentId(session DbSession, keys Set<String>, componentId long) : List<PropertyDto> in class org.sonar.db.property.PropertiesDao | From | To | |
| Rename Variable | 1 | ||
| Rename Variable component : ComponentDto to componentDto : ComponentDto in method private doHandle(request Request) : ValuesWsResponse in class org.sonar.server.settings.ws.ValuesAction | From | To | |
| Change Return Type | 2 | ||
| Change Return Type List<PropertyDefinition> to List<Setting> in method private loadDefaultSettings(keys Set<String>) : List<Setting> in class org.sonar.server.settings.ws.ValuesAction | From | To | |
| Change Return Type void to ValuesWsResponse in method package build() : ValuesWsResponse in class org.sonar.server.settings.ws.ValuesAction.ValuesResponseBuilder | From | To | |
| Rename Class | 1 | ||
| Rename Class org.sonar.server.settings.ws.ValuesAction.SettingsBuilder renamed to org.sonar.server.settings.ws.ValuesAction.ValuesResponseBuilder | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type component : ComponentDto to component : Optional<ComponentDto> in class org.sonar.server.settings.ws.ValuesAction.ValuesResponseBuilder | From | To | |
| Inline Variable | 4 | ||
| Inline Variable globalPropertyValue : Settings.Setting in method public return_global_values() : void from class org.sonar.server.settings.ws.ValuesActionTest | From | To | |
| Inline Variable globalPropertyValue : Settings.Setting in method public return_is_inherited_to_true_when_property_is_defined_only_at_global_level() : void from class org.sonar.server.settings.ws.ValuesActionTest | From | To | |
| Inline Variable value : Settings.Setting in method public return_default_values() : void from class org.sonar.server.settings.ws.ValuesActionTest | From | To | |
| Inline Variable globalPropertyValue : Settings.Setting in method public return_project_values() : void from class org.sonar.server.settings.ws.ValuesActionTest | From | To | |
| Extract Method | 4 | ||
| Extract Method private assertSetting(setting Settings.Setting, expectedKey String, expectedValue String, expectedDefault boolean, expectedInherited boolean) : void extracted from public return_default_values() : void in class org.sonar.server.settings.ws.ValuesActionTest | From | To | |
| Extract Method private assertSetting(setting Settings.Setting, expectedKey String, expectedValue String, expectedDefault boolean, expectedInherited boolean) : void extracted from public return_is_inherited_to_true_when_property_is_defined_only_at_global_level() : void in class org.sonar.server.settings.ws.ValuesActionTest | From | To | |
| Extract Method private assertSetting(setting Settings.Setting, expectedKey String, expectedValue String, expectedDefault boolean, expectedInherited boolean) : void extracted from public return_global_values() : void in class org.sonar.server.settings.ws.ValuesActionTest | From | To | |
| Extract Method private assertSetting(setting Settings.Setting, expectedKey String, expectedValue String, expectedDefault boolean, expectedInherited boolean) : void extracted from public return_project_values() : void in class org.sonar.server.settings.ws.ValuesActionTest | From | To |