f79030e299ce766ec510ce2019c7b5e77105a1cd
Files Diff
- Added: 13
- Removed: 8
- Renamed: 0
- Modified: 173
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Extract Subclass | 1 | ||
| Extract Subclass org.sonar.api.config.MapSettings from class org.sonar.api.config.Settings | From | To | |
| Change Parameter Type | 1 | ||
| Change Parameter Type persistentSettings : PersistentSettings to dbClient : DbClient in method public StartupMetadataPersister(metadata StartupMetadata, dbClient DbClient) in class org.sonar.server.platform.StartupMetadataPersister | From | To | |
| Move Method | 2 | ||
| Move Method public start() : void from class org.sonar.server.platform.PersistentSettings to public start() : void from class org.sonar.server.setting.DatabaseSettingsEnabler | From | To | |
| Move Method public stop() : void from class org.sonar.server.platform.PersistentSettings to public stop() : void from class org.sonar.server.setting.DatabaseSettingsEnabler | From | To | |
| Push Down Attribute | 3 | ||
| Push Down Attribute protected properties : Map<String,String> from class org.sonar.api.config.Settings to private properties : Map<String,String> from class org.sonar.scanner.bootstrap.GlobalSettings | From | To | |
| Push Down Attribute protected properties : Map<String,String> from class org.sonar.api.config.Settings to private properties : Map<String,String> from class org.sonar.scanner.scan.ModuleSettings | From | To | |
| Push Down Attribute protected properties : Map<String,String> from class org.sonar.api.config.Settings to private properties : Map<String,String> from class org.sonar.scanner.scan.ProjectSettings | From | To | |
| Move Attribute | 1 | ||
| Move Attribute package dbClient : DbClient from class org.sonar.server.platform.PersistentSettingsTest to private dbClient : DbClient from class org.sonar.server.platform.StartupMetadataPersister | From | To | |
| Extract Class | 1 | ||
| Extract Class org.sonar.server.setting.DatabaseSettingsEnabler from class org.sonar.server.platform.PersistentSettings | From | To | |
| Rename Class | 1 | ||
| Rename Class org.sonar.api.config.SettingsTest renamed to org.sonar.api.config.MapSettingsTest | From | To | |
| Change Variable Type | 5 | ||
| Change Variable Type property : PropertyDefinition to def : Optional<PropertyDefinition> in method public getStringArray(key String) : String[] in class org.sonar.api.config.Settings | From | To | |
| Change Variable Type settings : Settings to settings : MapSettings in method public five_shards_and_one_replica_by_default_on_cluster() : void in class org.sonar.server.es.NewIndexTest | From | To | |
| Change Variable Type property : PropertyDefinition to def : Optional<PropertyDefinition> in method public setProperty(key String, values String[]) : Settings in class org.sonar.api.config.Settings | From | To | |
| Change Variable Type settings : Settings to settings : MapSettings in method public customize_number_of_shards() : void in class org.sonar.server.es.NewIndexTest | From | To | |
| Change Variable Type settings : Settings to settings : MapSettings in method public customize_number_of_shards_and_replicas() : void in class org.sonar.server.es.NewIndexTest | From | To | |
| Inline Variable | 1 | ||
| Inline Variable newSecretKey : SecretKey in method public start() : void from class org.sonar.server.authentication.JwtSerializer | From | To | |
| Rename Method | 7 | ||
| Rename Method public saveProperty() : void renamed to public insert_property_into_database_and_notify_extensions() : void in class org.sonar.server.platform.PersistentSettingsTest | From | To | |
| Rename Method protected doOnGetProperties(key String) : void renamed to protected get(key String) : Optional<String> in class org.sonar.scanner.scan.ProjectSettings | From | To | |
| Rename Method protected doOnGetProperties(key String) : void renamed to protected get(key String) : Optional<String> in class org.sonar.scanner.bootstrap.GlobalSettings | From | To | |
| Rename Method public does_not_generate_new_secret_key_in_start_if_already_exists() : void renamed to public load_secret_key_from_settings() : void in class org.sonar.server.authentication.JwtSerializerTest | From | To | |
| Rename Method public should_select_default_qgate_and_update_settings() : void renamed to public should_select_default_qgate() : void in class org.sonar.server.qualitygate.QualityGatesTest | From | To | |
| Rename Method public remove() : void renamed to public unload() : void in class org.sonar.server.user.ThreadLocalUserSession | From | To | |
| Rename Method protected doOnGetProperties(key String) : void renamed to protected get(key String) : Optional<String> in class org.sonar.scanner.scan.ModuleSettings | From | To | |
| Pull Up Method | 1 | ||
| Pull Up Method public ComputeEngineSettings(definitions PropertyDefinitions, rootProperties Properties, componentContainer ComponentContainer) from class org.sonar.ce.settings.ComputeEngineSettings to protected Settings(definitions PropertyDefinitions, encryption Encryption) from class org.sonar.api.config.Settings | From | To | |
| Push Down Method | 1 | ||
| Push Down Method public getProperties() : Map<String,String> from class org.sonar.api.config.Settings to public getProperties() : Map<String,String> from class org.sonar.api.config.MapSettings | From | To | |
| Inline Method | 3 | ||
| Inline Method private init() : void inlined to public doFilter(servletRequest ServletRequest, servletResponse ServletResponse, chain FilterChain) : void in class org.sonar.server.user.UserSessionFilter | From | To | |
| Inline Method protected getClearString(key String) : String inlined to public getString(key String) : String in class org.sonar.api.config.Settings | From | To | |
| Inline Method private isInitialized() : boolean inlined to public doFilter(servletRequest ServletRequest, servletResponse ServletResponse, chain FilterChain) : void in class org.sonar.server.user.UserSessionFilter | From | To | |
| Rename Variable | 6 | ||
| Rename Variable currentUserSession : UserSession to session : UserSession in method public get() : UserSession in class org.sonar.server.user.ThreadLocalUserSession | From | To | |
| Rename Variable property : PropertyDefinition to def : Optional<PropertyDefinition> in method public setProperty(key String, values String[]) : Settings in class org.sonar.api.config.Settings | From | To | |
| Rename Variable batchSettings : GlobalSettings to globalSettings : GlobalSettings in method public should_not_fail_when_accessing_secured_properties() : void in class org.sonar.scanner.scan.ModuleSettingsTest | From | To | |
| Rename Variable batchSettings : GlobalSettings to globalSettings : GlobalSettings in method public should_fail_when_accessing_secured_properties_in_issues() : void in class org.sonar.scanner.scan.ModuleSettingsTest | From | To | |
| Rename Variable property : PropertyDefinition to def : Optional<PropertyDefinition> in method public getStringArray(key String) : String[] in class org.sonar.api.config.Settings | From | To | |
| Rename Variable validKey : String to effectiveKey : String in method public getString(key String) : String in class org.sonar.api.config.Settings | From | To | |
| Change Return Type | 3 | ||
| Change Return Type void to Optional<String> in method protected get(key String) : Optional<String> in class org.sonar.scanner.scan.ModuleSettings | From | To | |
| Change Return Type void to Optional<String> in method protected get(key String) : Optional<String> in class org.sonar.scanner.scan.ProjectSettings | From | To | |
| Change Return Type void to Optional<String> in method protected get(key String) : Optional<String> in class org.sonar.scanner.bootstrap.GlobalSettings | From | To | |
| Rename Attribute | 3 | ||
| Rename Attribute THREAD_LOCAL : ThreadLocal<UserSession> to DELEGATE : ThreadLocal<UserSession> in class org.sonar.server.user.ThreadLocalUserSession | From | To | |
| Rename Attribute emailSettings : EmailSettings to underTest : EmailSettings in class org.sonar.api.config.EmailSettingsTest | From | To | |
| Rename Attribute persistentSettings : PersistentSettings to dbClient : DbClient in class org.sonar.server.platform.StartupMetadataPersister | From | To | |
| Change Attribute Type | 3 | ||
| Change Attribute Type globalSettings : Settings to globalSettings : MapSettings in class org.sonar.server.computation.task.projectanalysis.component.SettingsRepositoryTest | From | To | |
| Change Attribute Type persistentSettings : PersistentSettings to dbClient : DbClient in class org.sonar.server.platform.StartupMetadataPersister | From | To | |
| Change Attribute Type settings : org.sonar.api.config.Settings to settings : Settings in class org.sonar.server.email.ws.UpdateConfigurationActionTest | From | To | |
| Extract And Move Method | 2 | ||
| Extract And Move Method protected set(key String, value String) : void extracted from public setProperty(key String, value String) : Settings in class org.sonar.api.config.Settings & moved to class org.sonar.scanner.bootstrap.GlobalSettings | From | To | |
| Extract And Move Method public getProperties() : Map<String,String> extracted from public getKeysStartingWith(prefix String) : List<String> in class org.sonar.api.config.Settings & moved to class org.sonar.scanner.bootstrap.GlobalSettings | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter persistentSettings : PersistentSettings to dbClient : DbClient in method public StartupMetadataPersister(metadata StartupMetadata, dbClient DbClient) in class org.sonar.server.platform.StartupMetadataPersister | From | To |