ffc4e81629792f92b532e661b7a5d2a05550fd3a
Files Diff
- Added: 4
- Removed: 0
- Renamed: 0
- Modified: 25
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 6 | ||
| Rename Method public selectByKeyWithUserAndGroupPermissions(session DbSession, templateKey String) : PermissionTemplateDto renamed to public selectByUuidWithUserAndGroupPermissions(session DbSession, templateKey String) : PermissionTemplateDto in class org.sonar.db.permission.PermissionTemplateDao | From | To | |
| Rename Method public fail_if_key_is_not_provided() : void renamed to public fail_if_uuid_is_not_provided() : void in class org.sonar.server.permission.ws.DeleteTemplateActionTest | From | To | |
| Rename Method public selectByKey(templateKey String) : PermissionTemplateDto renamed to public selectByUuid(templateKey String) : PermissionTemplateDto in class org.sonar.db.permission.PermissionTemplateDao | From | To | |
| Rename Method public selectByKey(session DbSession, templateKey String) : PermissionTemplateDto renamed to public selectByUuid(session DbSession, templateKey String) : PermissionTemplateDto in class org.sonar.db.permission.PermissionTemplateDao | From | To | |
| Rename Method public selectByKey(templateKey String) : PermissionTemplateDto renamed to public selectByUuid(templateUuid String) : PermissionTemplateDto in class org.sonar.db.permission.PermissionTemplateMapper | From | To | |
| Rename Method public selectByKeyWithUserAndGroupPermissions(templateKey String) : PermissionTemplateDto renamed to public selectByUuidWithUserAndGroupPermissions(templateKey String) : PermissionTemplateDto in class org.sonar.db.permission.PermissionTemplateDao | From | To | |
| Move And Inline Method | 1 | ||
| Move And Inline Method public deleteById(templateId Long) : void moved from class org.sonar.db.permission.PermissionTemplateDao to class org.sonar.db.permission.PermissionTemplateDaoTest & inlined to public should_delete_permission_template() : void | From | To | |
| Inline Method | 2 | ||
| Inline Method private insertTemplate(template PermissionTemplateDto) : PermissionTemplateDto inlined to public setUp() : void in class org.sonar.server.permission.ws.DeleteTemplateActionTest | From | To | |
| Rename Variable | 1 | ||
| Rename Variable key : String to uuid : String in method public handle(wsRequest Request, wsResponse Response) : void in class org.sonar.server.permission.ws.DeleteTemplateAction | From | To | |
| Move Attribute | 1 | ||
| Move Attribute public DEFAULT_TEMPLATE_PROPERTY : String from class org.sonar.server.startup.RegisterPermissionTemplates to public DEFAULT_TEMPLATE_PROPERTY : String from class org.sonar.server.permission.DefaultPermissionTemplates | From | To | |
| Move And Rename Class | 1 | ||
| Move And Rename Class org.sonar.server.permission.ws.SearchProjectPermissionsDataLoader.ResourceTypeToQualifierFunction moved and renamed to org.sonar.server.permission.ws.ResourceTypeToQualifier.Singleton | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute TEMPLATE_KEY : String to TEMPLATE_UUID : String in class org.sonar.server.permission.ws.DeleteTemplateActionTest | From | To | |
| Extract Method | 2 | ||
| Extract Method private deleteTemplate(uuid String) : void extracted from public handle(wsRequest Request, wsResponse Response) : void in class org.sonar.server.permission.ws.DeleteTemplateAction | From | To | |
| Extract Method private insertTemplateAndAssociatedPermissions(template PermissionTemplateDto) : PermissionTemplateDto extracted from public setUp() : void in class org.sonar.server.permission.ws.DeleteTemplateActionTest | From | To | |
| Rename Parameter | 4 | ||
| Rename Parameter templateKey : String to templateUuid : String in method public selectByUuid(templateUuid String) : PermissionTemplateDto in class org.sonar.db.permission.PermissionTemplateMapper | From | To | |
| Rename Parameter key : String to id : String in method private newRequest(id String) : TestResponse in class org.sonar.server.permission.ws.DeleteTemplateActionTest | From | To | |
| Rename Parameter templateName : String to name : String in method public selectByName(dbSession DbSession, name String) : PermissionTemplateDto in class org.sonar.db.permission.PermissionTemplateDao | From | To | |
| Rename Parameter templateKey : String to uuid : String in method package getTemplate(dbSession DbSession, uuid String) : PermissionTemplateDto in class org.sonar.server.permission.ws.PermissionDependenciesFinder | From | To |