spark 9ba2e75c7ee4bb1a6c9df287021cf05141248fed

9ba2e75c7ee4bb1a6c9df287021cf05141248fed

Files Diff

Added: 10
Removed: 2
Renamed: 0
Modified: 7

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Pull Up Method	60
Pull Up Method public get(path String, route TemplateViewRoute, engine TemplateEngine) : void from class spark.SparkInstance to public get(path String, route TemplateViewRoute, engine TemplateEngine) : void from class spark.route.mapping.Routable	From	To
Pull Up Method public put(path String, route Route) : void from class spark.SparkInstance to public put(path String, route Route) : void from class spark.route.mapping.Routable	From	To
Pull Up Method public connect(path String, route TemplateViewRoute, engine TemplateEngine) : void from class spark.SparkInstance to public connect(path String, route TemplateViewRoute, engine TemplateEngine) : void from class spark.route.mapping.Routable	From	To
Pull Up Method public patch(path String, route Route, transformer ResponseTransformer) : void from class spark.SparkInstance to public patch(path String, route Route, transformer ResponseTransformer) : void from class spark.route.mapping.Routable	From	To
Pull Up Method public after(path String, acceptType String, filter Filter) : void from class spark.SparkInstance to public after(path String, acceptType String, filter Filter) : void from class spark.route.mapping.Routable	From	To
Pull Up Method public patch(path String, acceptType String, route TemplateViewRoute, engine TemplateEngine) : void from class spark.SparkInstance to public patch(path String, acceptType String, route TemplateViewRoute, engine TemplateEngine) : void from class spark.route.mapping.Routable	From	To
Pull Up Method public connect(path String, acceptType String, route Route) : void from class spark.SparkInstance to public connect(path String, acceptType String, route Route) : void from class spark.route.mapping.Routable	From	To
Pull Up Method public options(path String, route TemplateViewRoute, engine TemplateEngine) : void from class spark.SparkInstance to public options(path String, route TemplateViewRoute, engine TemplateEngine) : void from class spark.route.mapping.Routable	From	To
Pull Up Method public connect(path String, acceptType String, route TemplateViewRoute, engine TemplateEngine) : void from class spark.SparkInstance to public connect(path String, acceptType String, route TemplateViewRoute, engine TemplateEngine) : void from class spark.route.mapping.Routable	From	To
Pull Up Method public options(path String, acceptType String, route Route) : void from class spark.SparkInstance to public options(path String, acceptType String, route Route) : void from class spark.route.mapping.Routable	From	To
Pull Up Method public delete(path String, acceptType String, route TemplateViewRoute, engine TemplateEngine) : void from class spark.SparkInstance to public delete(path String, acceptType String, route TemplateViewRoute, engine TemplateEngine) : void from class spark.route.mapping.Routable	From	To
Pull Up Method public trace(path String, route Route) : void from class spark.SparkInstance to public trace(path String, route Route) : void from class spark.route.mapping.Routable	From	To
Pull Up Method public delete(path String, acceptType String, route Route) : void from class spark.SparkInstance to public delete(path String, acceptType String, route Route) : void from class spark.route.mapping.Routable	From	To
Pull Up Method public patch(path String, route Route) : void from class spark.SparkInstance to public patch(path String, route Route) : void from class spark.route.mapping.Routable	From	To
Pull Up Method public head(path String, route TemplateViewRoute, engine TemplateEngine) : void from class spark.SparkInstance to public head(path String, route TemplateViewRoute, engine TemplateEngine) : void from class spark.route.mapping.Routable	From	To
Pull Up Method public post(path String, acceptType String, route TemplateViewRoute, engine TemplateEngine) : void from class spark.SparkInstance to public post(path String, acceptType String, route TemplateViewRoute, engine TemplateEngine) : void from class spark.route.mapping.Routable	From	To
Pull Up Method public get(path String, acceptType String, route TemplateViewRoute, engine TemplateEngine) : void from class spark.SparkInstance to public get(path String, acceptType String, route TemplateViewRoute, engine TemplateEngine) : void from class spark.route.mapping.Routable	From	To
Pull Up Method public get(path String, acceptType String, route Route, transformer ResponseTransformer) : void from class spark.SparkInstance to public get(path String, acceptType String, route Route, transformer ResponseTransformer) : void from class spark.route.mapping.Routable	From	To
Pull Up Method public put(path String, acceptType String, route Route, transformer ResponseTransformer) : void from class spark.SparkInstance to public put(path String, acceptType String, route Route, transformer ResponseTransformer) : void from class spark.route.mapping.Routable	From	To
Pull Up Method public connect(path String, route Route, transformer ResponseTransformer) : void from class spark.SparkInstance to public connect(path String, route Route, transformer ResponseTransformer) : void from class spark.route.mapping.Routable	From	To
Pull Up Method public options(path String, acceptType String, route Route, transformer ResponseTransformer) : void from class spark.SparkInstance to public options(path String, acceptType String, route Route, transformer ResponseTransformer) : void from class spark.route.mapping.Routable	From	To
Pull Up Method public connect(path String, route Route) : void from class spark.SparkInstance to public connect(path String, route Route) : void from class spark.route.mapping.Routable	From	To
Pull Up Method public post(path String, acceptType String, route Route) : void from class spark.SparkInstance to public post(path String, acceptType String, route Route) : void from class spark.route.mapping.Routable	From	To
Pull Up Method public head(path String, acceptType String, route Route, transformer ResponseTransformer) : void from class spark.SparkInstance to public head(path String, acceptType String, route Route, transformer ResponseTransformer) : void from class spark.route.mapping.Routable	From	To
Pull Up Method public trace(path String, acceptType String, route Route) : void from class spark.SparkInstance to public trace(path String, acceptType String, route Route) : void from class spark.route.mapping.Routable	From	To
Pull Up Method public head(path String, acceptType String, route TemplateViewRoute, engine TemplateEngine) : void from class spark.SparkInstance to public head(path String, acceptType String, route TemplateViewRoute, engine TemplateEngine) : void from class spark.route.mapping.Routable	From	To
Pull Up Method public get(path String, route Route, transformer ResponseTransformer) : void from class spark.SparkInstance to public get(path String, route Route, transformer ResponseTransformer) : void from class spark.route.mapping.Routable	From	To
Pull Up Method public delete(path String, acceptType String, route Route, transformer ResponseTransformer) : void from class spark.SparkInstance to public delete(path String, acceptType String, route Route, transformer ResponseTransformer) : void from class spark.route.mapping.Routable	From	To
Pull Up Method public options(path String, route Route) : void from class spark.SparkInstance to public options(path String, route Route) : void from class spark.route.mapping.Routable	From	To
Pull Up Method public post(path String, acceptType String, route Route, transformer ResponseTransformer) : void from class spark.SparkInstance to public post(path String, acceptType String, route Route, transformer ResponseTransformer) : void from class spark.route.mapping.Routable	From	To
Pull Up Method public post(path String, route Route) : void from class spark.SparkInstance to public post(path String, route Route) : void from class spark.route.mapping.Routable	From	To
Pull Up Method public trace(path String, route TemplateViewRoute, engine TemplateEngine) : void from class spark.SparkInstance to public trace(path String, route TemplateViewRoute, engine TemplateEngine) : void from class spark.route.mapping.Routable	From	To
Pull Up Method public post(path String, route Route, transformer ResponseTransformer) : void from class spark.SparkInstance to public post(path String, route Route, transformer ResponseTransformer) : void from class spark.route.mapping.Routable	From	To
Pull Up Method public after(path String, filter Filter) : void from class spark.SparkInstance to public after(path String, filter Filter) : void from class spark.route.mapping.Routable	From	To
Pull Up Method public connect(path String, acceptType String, route Route, transformer ResponseTransformer) : void from class spark.SparkInstance to public connect(path String, acceptType String, route Route, transformer ResponseTransformer) : void from class spark.route.mapping.Routable	From	To
Pull Up Method public delete(path String, route Route, transformer ResponseTransformer) : void from class spark.SparkInstance to public delete(path String, route Route, transformer ResponseTransformer) : void from class spark.route.mapping.Routable	From	To
Pull Up Method public patch(path String, route TemplateViewRoute, engine TemplateEngine) : void from class spark.SparkInstance to public patch(path String, route TemplateViewRoute, engine TemplateEngine) : void from class spark.route.mapping.Routable	From	To
Pull Up Method public after(filter Filter) : void from class spark.SparkInstance to public after(filter Filter) : void from class spark.route.mapping.Routable	From	To
Pull Up Method public put(path String, route TemplateViewRoute, engine TemplateEngine) : void from class spark.SparkInstance to public put(path String, route TemplateViewRoute, engine TemplateEngine) : void from class spark.route.mapping.Routable	From	To
Pull Up Method public put(path String, acceptType String, route TemplateViewRoute, engine TemplateEngine) : void from class spark.SparkInstance to public put(path String, acceptType String, route TemplateViewRoute, engine TemplateEngine) : void from class spark.route.mapping.Routable	From	To
Pull Up Method public trace(path String, acceptType String, route Route, transformer ResponseTransformer) : void from class spark.SparkInstance to public trace(path String, acceptType String, route Route, transformer ResponseTransformer) : void from class spark.route.mapping.Routable	From	To
Pull Up Method public get(path String, route Route) : void from class spark.SparkInstance to public get(path String, route Route) : void from class spark.route.mapping.Routable	From	To
Pull Up Method public post(path String, route TemplateViewRoute, engine TemplateEngine) : void from class spark.SparkInstance to public post(path String, route TemplateViewRoute, engine TemplateEngine) : void from class spark.route.mapping.Routable	From	To
Pull Up Method public patch(path String, acceptType String, route Route, transformer ResponseTransformer) : void from class spark.SparkInstance to public patch(path String, acceptType String, route Route, transformer ResponseTransformer) : void from class spark.route.mapping.Routable	From	To
Pull Up Method public before(filter Filter) : void from class spark.SparkInstance to public before(filter Filter) : void from class spark.route.mapping.Routable	From	To
Pull Up Method public before(path String, acceptType String, filter Filter) : void from class spark.SparkInstance to public before(path String, acceptType String, filter Filter) : void from class spark.route.mapping.Routable	From	To
Pull Up Method public head(path String, route Route, transformer ResponseTransformer) : void from class spark.SparkInstance to public head(path String, route Route, transformer ResponseTransformer) : void from class spark.route.mapping.Routable	From	To
Pull Up Method public get(path String, acceptType String, route Route) : void from class spark.SparkInstance to public get(path String, acceptType String, route Route) : void from class spark.route.mapping.Routable	From	To
Pull Up Method public trace(path String, route Route, transformer ResponseTransformer) : void from class spark.SparkInstance to public trace(path String, route Route, transformer ResponseTransformer) : void from class spark.route.mapping.Routable	From	To
Pull Up Method public options(path String, acceptType String, route TemplateViewRoute, engine TemplateEngine) : void from class spark.SparkInstance to public options(path String, acceptType String, route TemplateViewRoute, engine TemplateEngine) : void from class spark.route.mapping.Routable	From	To
Pull Up Method public delete(path String, route TemplateViewRoute, engine TemplateEngine) : void from class spark.SparkInstance to public delete(path String, route TemplateViewRoute, engine TemplateEngine) : void from class spark.route.mapping.Routable	From	To
Pull Up Method public put(path String, acceptType String, route Route) : void from class spark.SparkInstance to public put(path String, acceptType String, route Route) : void from class spark.route.mapping.Routable	From	To
Pull Up Method public trace(path String, acceptType String, route TemplateViewRoute, engine TemplateEngine) : void from class spark.SparkInstance to public trace(path String, acceptType String, route TemplateViewRoute, engine TemplateEngine) : void from class spark.route.mapping.Routable	From	To
Pull Up Method public head(path String, route Route) : void from class spark.SparkInstance to public head(path String, route Route) : void from class spark.route.mapping.Routable	From	To
Pull Up Method public put(path String, route Route, transformer ResponseTransformer) : void from class spark.SparkInstance to public put(path String, route Route, transformer ResponseTransformer) : void from class spark.route.mapping.Routable	From	To
Pull Up Method public head(path String, acceptType String, route Route) : void from class spark.SparkInstance to public head(path String, acceptType String, route Route) : void from class spark.route.mapping.Routable	From	To
Pull Up Method public patch(path String, acceptType String, route Route) : void from class spark.SparkInstance to public patch(path String, acceptType String, route Route) : void from class spark.route.mapping.Routable	From	To
Pull Up Method public before(path String, filter Filter) : void from class spark.SparkInstance to public before(path String, filter Filter) : void from class spark.route.mapping.Routable	From	To
Pull Up Method public delete(path String, route Route) : void from class spark.SparkInstance to public delete(path String, route Route) : void from class spark.route.mapping.Routable	From	To
Pull Up Method public options(path String, route Route, transformer ResponseTransformer) : void from class spark.SparkInstance to public options(path String, route Route, transformer ResponseTransformer) : void from class spark.route.mapping.Routable	From	To
Move And Rename Method	2
Move And Rename Method private setExternalStaticFileLocationIfPresent(externalFilesRoute String, handlersInList List<Handler>) : void from class spark.webserver.SparkServer to public setExternalLocationIfPresent(externalFileLocation String, handlersInList List<Handler>) : void from class spark.webserver.staticfiles.StaticFiles	From	To
Move And Rename Method private setStaticFileLocationIfPresent(staticFilesRoute String, handlersInList List<Handler>) : void from class spark.webserver.SparkServer to public setLocationIfPresent(staticFileLocation String, handlersInList List<Handler>) : void from class spark.webserver.staticfiles.StaticFiles	From	To
Change Parameter Type	1
Change Parameter Type keystoreFile : String to sslStores : SslStores in method public ignite(host String, port int, sslStores SslStores, staticFilesFolder String, externalFilesFolder String, latch CountDownLatch, maxThreads int, minThreads int, threadIdleTimeoutMillis int, webSocketHandlers Map<String,Class<?>>, webSocketIdleTimeoutMillis Optional<Integer>) : void in class spark.webserver.SparkServer	From	To
Move Method	8
Move Method protected wrap(path String, route Route) : RouteImpl from class spark.SparkInstance to package wrap(path String, route Route) : RouteImpl from class spark.route.mapping.RouteWrapper	From	To
Move Method protected wrap(path String, filter Filter) : FilterImpl from class spark.SparkInstance to package wrap(path String, filter Filter) : FilterImpl from class spark.route.mapping.RouteWrapper	From	To
Move Method protected wrap(path String, acceptType String, route Route) : RouteImpl from class spark.SparkInstance to package wrap(path String, acceptType String, route Route) : RouteImpl from class spark.route.mapping.RouteWrapper	From	To
Move Method protected wrap(path String, acceptType String, filter Filter) : FilterImpl from class spark.SparkInstance to package wrap(path String, acceptType String, filter Filter) : FilterImpl from class spark.route.mapping.RouteWrapper	From	To
Move Method public configureStaticResources(folder String) : void from class spark.servlet.SparkFilter to public configureStaticResources(folder String) : void from class spark.servlet.staticfiles.ServletStaticFiles	From	To
Move Method private createSecureSocketConnector(server Server, keystoreFile String, keystorePassword String, truststoreFile String, truststorePassword String) : ServerConnector from class spark.webserver.SparkServer to public createSecureSocketConnector(server Server, host String, port int, sslStores SslStores) : ServerConnector from class spark.webserver.jetty.SocketConnectorFactory	From	To
Move Method private createServer(maxThreads int, minThreads int, threadTimeoutMillis int) : Server from class spark.webserver.SparkServer to public createServer(maxThreads int, minThreads int, threadTimeoutMillis int) : Server from class spark.webserver.jetty.JettyServerFactory	From	To
Move Method public configureExternalStaticResources(folder String) : void from class spark.servlet.SparkFilter to public configureExternalStaticResources(folder String) : void from class spark.servlet.staticfiles.ServletStaticFiles	From	To
Move Attribute	7
Move Attribute private staticResourcesSet : boolean from class spark.servlet.SparkFilter to private staticResourcesSet : boolean from class spark.servlet.staticfiles.ServletStaticFiles	From	To
Move Attribute private externalStaticResourcesSet : boolean from class spark.servlet.SparkFilter to private externalStaticResourcesSet : boolean from class spark.servlet.staticfiles.ServletStaticFiles	From	To
Move Attribute protected truststorePassword : String from class spark.SparkInstance to protected truststorePassword : String from class spark.webserver.ssl.SslStores	From	To
Move Attribute private staticResourceHandlers : List<AbstractResourceHandler> from class spark.servlet.SparkFilter to private staticResourceHandlers : List<AbstractResourceHandler> from class spark.servlet.staticfiles.ServletStaticFiles	From	To
Move Attribute protected keystorePassword : String from class spark.SparkInstance to protected keystorePassword : String from class spark.webserver.ssl.SslStores	From	To
Move Attribute protected keystoreFile : String from class spark.SparkInstance to protected keystoreFile : String from class spark.webserver.ssl.SslStores	From	To
Move Attribute protected truststoreFile : String from class spark.SparkInstance to protected truststoreFile : String from class spark.webserver.ssl.SslStores	From	To
Extract Class	3
Extract Class spark.webserver.ssl.SslStores from class spark.SparkInstance	From	To
Extract Class spark.servlet.staticfiles.ServletStaticFiles from class spark.servlet.SparkFilter	From	To
Extract Class spark.route.mapping.RouteWrapper from class spark.SparkInstance	From	To
Move Class	1
Move Class spark.webserver.JettyHandler moved to spark.webserver.jetty.JettyHandler	From	To
Extract Superclass	1
Extract Superclass spark.route.mapping.Routable from classes [spark.SparkInstance]	From	To
Rename Parameter	4
Rename Parameter keystoreFile : String to host : String in method public createSecureSocketConnector(server Server, host String, port int, sslStores SslStores) : ServerConnector in class spark.webserver.jetty.SocketConnectorFactory	From	To
Rename Parameter staticFilesRoute : String to staticFileLocation : String in method public setLocationIfPresent(staticFileLocation String, handlersInList List<Handler>) : void in class spark.webserver.staticfiles.StaticFiles	From	To
Rename Parameter keystoreFile : String to sslStores : SslStores in method public ignite(host String, port int, sslStores SslStores, staticFilesFolder String, externalFilesFolder String, latch CountDownLatch, maxThreads int, minThreads int, threadIdleTimeoutMillis int, webSocketHandlers Map<String,Class<?>>, webSocketIdleTimeoutMillis Optional<Integer>) : void in class spark.webserver.SparkServer	From	To
Rename Parameter externalFilesRoute : String to externalFileLocation : String in method public setExternalLocationIfPresent(externalFileLocation String, handlersInList List<Handler>) : void in class spark.webserver.staticfiles.StaticFiles	From	To

9ba2e75c7ee4bb1a6c9df287021cf05141248fed

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: