7ac81f8fd5a2428d995a430903952125d9edc1db
Files Diff
- Added: 15
- Removed: 6
- Renamed: 0
- Modified: 12
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Pull Up Method | 2 | ||
| Pull Up Method private isSecure(config IClientConfig) : boolean from class org.springframework.cloud.netflix.ribbon.apache.RibbonLoadBalancingHttpClient to protected isSecure(config IClientConfig) : boolean from class org.springframework.cloud.netflix.ribbon.support.AbstractLoadBalancingClient | From | To | |
| Pull Up Method public initWithNiwsConfig(clientConfig IClientConfig) : void from class org.springframework.cloud.netflix.ribbon.apache.RibbonLoadBalancingHttpClient to public initWithNiwsConfig(clientConfig IClientConfig) : void from class org.springframework.cloud.netflix.ribbon.support.AbstractLoadBalancingClient | From | To | |
| Change Parameter Type | 1 | ||
| Change Parameter Type request : RibbonApacheHttpRequest to request : S in method public getRequestSpecificRetryHandler(request S, requestConfig IClientConfig) : RequestSpecificRetryHandler in class org.springframework.cloud.netflix.ribbon.support.AbstractLoadBalancingClient | From | To | |
| Move Method | 1 | ||
| Move Method public getRequestSpecificRetryHandler(request RibbonApacheHttpRequest, requestConfig IClientConfig) : RequestSpecificRetryHandler from class org.springframework.cloud.netflix.ribbon.apache.RibbonLoadBalancingHttpClient to public getRequestSpecificRetryHandler(request S, requestConfig IClientConfig) : RequestSpecificRetryHandler from class org.springframework.cloud.netflix.ribbon.support.AbstractLoadBalancingClient | From | To | |
| Rename Variable | 1 | ||
| Rename Variable entry : Entry<String,List<String>> to key : Entry<String,List<String>> in method package transformHeaders(headers MultiValueMap<String,String>, output Map<String,Object>) : void in class org.springframework.cloud.netflix.zuul.filters.ProxyRequestHelper | From | To | |
| Pull Up Attribute | 5 | ||
| Pull Up Attribute private followRedirects : boolean from class org.springframework.cloud.netflix.ribbon.apache.RibbonLoadBalancingHttpClient to protected followRedirects : boolean from class org.springframework.cloud.netflix.ribbon.support.AbstractLoadBalancingClient | From | To | |
| Pull Up Attribute private okToRetryOnAllOperations : boolean from class org.springframework.cloud.netflix.ribbon.apache.RibbonLoadBalancingHttpClient to protected okToRetryOnAllOperations : boolean from class org.springframework.cloud.netflix.ribbon.support.AbstractLoadBalancingClient | From | To | |
| Pull Up Attribute private readTimeout : int from class org.springframework.cloud.netflix.ribbon.apache.RibbonLoadBalancingHttpClient to protected readTimeout : int from class org.springframework.cloud.netflix.ribbon.support.AbstractLoadBalancingClient | From | To | |
| Pull Up Attribute private connectTimeout : int from class org.springframework.cloud.netflix.ribbon.apache.RibbonLoadBalancingHttpClient to protected connectTimeout : int from class org.springframework.cloud.netflix.ribbon.support.AbstractLoadBalancingClient | From | To | |
| Pull Up Attribute private secure : boolean from class org.springframework.cloud.netflix.ribbon.apache.RibbonLoadBalancingHttpClient to protected secure : boolean from class org.springframework.cloud.netflix.ribbon.support.AbstractLoadBalancingClient | From | To | |
| Change Return Type | 1 | ||
| Change Return Type MyErrorController to ZuulProxyTestBase.MyErrorController in method public myErrorController(errorAttributes ErrorAttributes) : ZuulProxyTestBase.MyErrorController in class org.springframework.cloud.netflix.zuul.filters.route.apache.HttpClientRibbonCommandIntegrationTests.TestConfig | From | To | |
| Move Attribute | 3 | ||
| Move Attribute private method : String from class org.springframework.cloud.netflix.ribbon.apache.RibbonApacheHttpRequest to private method : String from class org.springframework.cloud.netflix.zuul.filters.route.RibbonCommandContext | From | To | |
| Move Attribute private contentLength : Long from class org.springframework.cloud.netflix.ribbon.apache.RibbonApacheHttpRequest to private contentLength : Long from class org.springframework.cloud.netflix.zuul.filters.route.RibbonCommandContext | From | To | |
| Move Attribute private method : String from class org.springframework.cloud.netflix.zuul.filters.route.apache.HttpClientRibbonCommand to private method : String from class org.springframework.cloud.netflix.zuul.filters.route.RibbonCommandContext | From | To | |
| Move And Rename Class | 4 | ||
| Move And Rename Class org.springframework.cloud.netflix.zuul.SampleZuulProxyWithHttpClientTests moved and renamed to org.springframework.cloud.netflix.zuul.filters.route.apache.HttpClientRibbonCommandIntegrationTests | From | To | |
| Move And Rename Class org.springframework.cloud.netflix.zuul.SampleZuulProxyApplicationTests moved and renamed to org.springframework.cloud.netflix.zuul.filters.route.restclient.RestClientRibbonCommandIntegrationTests | From | To | |
| Move And Rename Class org.springframework.cloud.netflix.zuul.SampleZuulProxyApplication moved and renamed to org.springframework.cloud.netflix.zuul.filters.route.restclient.RestClientRibbonCommandIntegrationTests.TestConfig | From | To | |
| Move And Rename Class org.springframework.cloud.netflix.zuul.SampleHttpClientZuulProxyApplication moved and renamed to org.springframework.cloud.netflix.zuul.filters.route.apache.HttpClientRibbonCommandIntegrationTests.TestConfig | From | To | |
| Move Class | 6 | ||
| Move Class org.springframework.cloud.netflix.zuul.SimpleRibbonClientConfiguration moved to org.springframework.cloud.netflix.zuul.filters.route.support.ZuulProxyTestBase.SimpleRibbonClientConfiguration | From | To | |
| Move Class org.springframework.cloud.netflix.zuul.MyErrorController moved to org.springframework.cloud.netflix.zuul.filters.route.support.ZuulProxyTestBase.MyErrorController | From | To | |
| Move Class org.springframework.cloud.netflix.zuul.ZuulProxyTestBase moved to org.springframework.cloud.netflix.zuul.filters.route.support.ZuulProxyTestBase | From | To | |
| Move Class org.springframework.cloud.netflix.zuul.ServletPathZuulProxyApplication moved to org.springframework.cloud.netflix.zuul.ServletPathZuulProxyApplicationTests.ServletPathZuulProxyApplication | From | To | |
| Move Class org.springframework.cloud.netflix.zuul.AnotherRibbonClientConfiguration moved to org.springframework.cloud.netflix.zuul.filters.route.support.ZuulProxyTestBase.AnotherRibbonClientConfiguration | From | To | |
| Move Class org.springframework.cloud.netflix.zuul.filters.route.RestClientRibbonCommandFactory moved to org.springframework.cloud.netflix.zuul.filters.route.restclient.RestClientRibbonCommandFactory | From | To | |
| Parameterize Variable | 1 | ||
| Parameterize Variable input : Map<String,Object> to output : Map<String,Object> in method package transformHeaders(headers MultiValueMap<String,String>, output Map<String,Object>) : void in class org.springframework.cloud.netflix.zuul.filters.ProxyRequestHelper | From | To | |
| Extract Superclass | 2 | ||
| Extract Superclass org.springframework.cloud.netflix.ribbon.support.AbstractLoadBalancingClient from classes [org.springframework.cloud.netflix.ribbon.apache.RibbonLoadBalancingHttpClient] | From | To | |
| Extract Superclass org.springframework.cloud.netflix.ribbon.support.ContextAwareRequest from classes [org.springframework.cloud.netflix.ribbon.apache.RibbonApacheHttpRequest] | From | To | |
| Extract Method | 2 | ||
| Extract Method package transformHeaders(headers MultiValueMap<String,String>, output Map<String,Object>) : void extracted from public debug(verb String, uri String, headers MultiValueMap<String,String>, params MultiValueMap<String,String>, requestEntity InputStream) : Map<String,Object> in class org.springframework.cloud.netflix.zuul.filters.ProxyRequestHelper | From | To | |
| Extract Method package transformHeaders(headers MultiValueMap<String,String>, output Map<String,Object>) : void extracted from public appendDebug(info Map<String,Object>, status int, headers MultiValueMap<String,String>) : void in class org.springframework.cloud.netflix.zuul.filters.ProxyRequestHelper | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter sMethod : String to method : String in method package getVerb(method String) : HttpRequest.Verb in class org.springframework.cloud.netflix.zuul.filters.route.restclient.RestClientRibbonCommandFactory | From | To |