5dfa1df950130c197a4a0656b7ecd5d6ce1d7c67
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 9
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Replace Attribute | 2 | ||
| Replace Attribute private socket : NioChannel from class org.apache.coyote.http11.InternalNioOutputBuffer with protected socketWrapper : SocketWrapperBase<S> from class org.apache.coyote.http11.AbstractOutputBuffer | From | To | |
| Replace Attribute private bufferedWrites : LinkedBlockingDeque<ByteBufferHolder> from class org.apache.coyote.ajp.AjpProcessor with protected socketWrapper : SocketWrapperBase<S> from class org.apache.coyote.http11.AbstractOutputBuffer | From | To | |
| Move Method | 4 | ||
| Move Method private addToBuffers(buf byte[], offset int, length int) : void from class org.apache.coyote.ajp.AjpProcessor to private addToBuffers(buf byte[], offset int, length int) : void from class org.apache.tomcat.util.net.NioEndpoint.NioSocketWrapper | From | To | |
| Move Method private writeToSocket(bytebuffer ByteBuffer, block boolean, flip boolean) : int from class org.apache.coyote.http11.InternalNioOutputBuffer to private writeToSocket(bytebuffer ByteBuffer, block boolean, flip boolean) : int from class org.apache.tomcat.util.net.NioEndpoint.NioSocketWrapper | From | To | |
| Move Method protected hasBufferedData() : boolean from class org.apache.coyote.http11.AbstractOutputBuffer to protected hasBufferedData() : boolean from class org.apache.tomcat.util.net.SocketWrapperBase | From | To | |
| Move Method private addToBuffers(buf byte[], offset int, length int) : void from class org.apache.coyote.http11.InternalNioOutputBuffer to private addToBuffers(buf byte[], offset int, length int) : void from class org.apache.tomcat.util.net.NioEndpoint.NioSocketWrapper | From | To | |
| Rename Variable | 1 | ||
| Rename Variable writtenThisLoop : int to dataLeft : boolean in method public write(block boolean, b byte[], off int, len int) : void in class org.apache.tomcat.util.net.NioEndpoint.NioSocketWrapper | From | To | |
| Change Return Type | 4 | ||
| Change Return Type int to void in method public abstract write(block boolean, b byte[], off int, len int) : void in class org.apache.tomcat.util.net.SocketWrapperBase | From | To | |
| Change Return Type int to void in method public write(block boolean, b byte[], off int, len int) : void in class org.apache.tomcat.util.net.NioEndpoint.NioSocketWrapper | From | To | |
| Change Return Type int to void in method public write(block boolean, b byte[], off int, len int) : void in class org.apache.tomcat.util.net.Nio2Endpoint.Nio2SocketWrapper | From | To | |
| Change Return Type int to void in method public write(block boolean, b byte[], off int, len int) : void in class org.apache.tomcat.util.net.AprEndpoint.AprSocketWrapper | From | To | |
| Move Attribute | 2 | ||
| Move Attribute private bufferedWriteSize : int from class org.apache.coyote.ajp.AjpProcessor to protected bufferedWriteSize : int from class org.apache.tomcat.util.net.SocketWrapperBase | From | To | |
| Move Attribute private bufferedWrites : LinkedBlockingDeque<ByteBufferHolder> from class org.apache.coyote.ajp.AjpProcessor to protected bufferedWrites : LinkedBlockingDeque<ByteBufferHolder> from class org.apache.tomcat.util.net.SocketWrapperBase | From | To | |
| Change Variable Type | 1 | ||
| Change Variable Type writtenThisLoop : int to dataLeft : boolean in method public write(block boolean, b byte[], off int, len int) : void in class org.apache.tomcat.util.net.NioEndpoint.NioSocketWrapper | From | To | |
| Extract And Move Method | 2 | ||
| Extract And Move Method public flush(block boolean) : boolean extracted from protected flushBuffer(block boolean) : boolean in class org.apache.coyote.http11.InternalNioOutputBuffer & moved to class org.apache.tomcat.util.net.NioEndpoint.NioSocketWrapper | From | To | |
| Extract And Move Method public hasDataToWrite() : boolean extracted from public hasDataToWrite() : boolean in class org.apache.coyote.http11.AbstractOutputBuffer & moved to class org.apache.tomcat.util.net.SocketWrapperBase | From | To |