f78f1a3e6847ff2b312fafaced7193bf67f9c1c1
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 20
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Change Parameter Type | 9 | ||
| Change Parameter Type config : BaseObjectPoolConfig to config : BaseObjectPoolConfig<T> in method public BaseGenericObjectPool(config BaseObjectPoolConfig<T>, jmxNameBase String, jmxNamePrefix String) in class org.apache.tomcat.dbcp.pool2.impl.BaseGenericObjectPool | From | To | |
| Change Parameter Type config : BaseObjectPoolConfig to config : BaseObjectPoolConfig<T> in method private jmxRegister(config BaseObjectPoolConfig<T>, jmxNameBase String, jmxNamePrefix String) : ObjectName in class org.apache.tomcat.dbcp.pool2.impl.BaseGenericObjectPool | From | To | |
| Change Parameter Type conf : GenericKeyedObjectPoolConfig to conf : GenericKeyedObjectPoolConfig<T> in method public setConfig(conf GenericKeyedObjectPoolConfig<T>) : void in class org.apache.tomcat.dbcp.pool2.impl.GenericKeyedObjectPool | From | To | |
| Change Parameter Type config : GenericKeyedObjectPoolConfig to config : GenericKeyedObjectPoolConfig<T> in method public GenericKeyedObjectPool(factory KeyedPooledObjectFactory<K,T>, config GenericKeyedObjectPoolConfig<T>) in class org.apache.tomcat.dbcp.pool2.impl.GenericKeyedObjectPool | From | To | |
| Change Parameter Type config : GenericObjectPoolConfig to config : GenericObjectPoolConfig<T> in method public GenericObjectPool(factory PooledObjectFactory<T>, config GenericObjectPoolConfig<T>) in class org.apache.tomcat.dbcp.pool2.impl.GenericObjectPool | From | To | |
| Change Parameter Type task : Runnable to task : BaseGenericObjectPool<?> in method package schedule(task BaseGenericObjectPool<?>, delay long, period long) : void in class org.apache.tomcat.dbcp.pool2.impl.EvictionTimer | From | To | |
| Change Parameter Type config : GenericObjectPoolConfig to config : GenericObjectPoolConfig<T> in method public GenericObjectPool(factory PooledObjectFactory<T>, config GenericObjectPoolConfig<T>, abandonedConfig AbandonedConfig) in class org.apache.tomcat.dbcp.pool2.impl.GenericObjectPool | From | To | |
| Change Parameter Type task : TimerTask to task : BaseGenericObjectPool<?> in method package cancel(task BaseGenericObjectPool<?>, timeout long, unit TimeUnit) : void in class org.apache.tomcat.dbcp.pool2.impl.EvictionTimer | From | To | |
| Change Parameter Type conf : GenericObjectPoolConfig to conf : GenericObjectPoolConfig<T> in method public setConfig(conf GenericObjectPoolConfig<T>) : void in class org.apache.tomcat.dbcp.pool2.impl.GenericObjectPool | From | To | |
| Rename Variable | 1 | ||
| Rename Variable vme : VirtualMachineError to e : VirtualMachineError in method package swallowException(swallowException Exception) : void in class org.apache.tomcat.dbcp.pool2.impl.BaseGenericObjectPool | From | To | |
| Change Return Type | 2 | ||
| Change Return Type GenericKeyedObjectPoolConfig to GenericKeyedObjectPoolConfig<T> in method public clone() : GenericKeyedObjectPoolConfig<T> in class org.apache.tomcat.dbcp.pool2.impl.GenericKeyedObjectPoolConfig | From | To | |
| Change Return Type GenericObjectPoolConfig to GenericObjectPoolConfig<T> in method public clone() : GenericObjectPoolConfig<T> in class org.apache.tomcat.dbcp.pool2.impl.GenericObjectPoolConfig | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute oname : ObjectName to objectName : ObjectName in class org.apache.tomcat.dbcp.pool2.impl.BaseGenericObjectPool | From | To | |
| Extract Variable | 1 | ||
| Extract Variable type : Class<PooledObjectFactory> in method package getFactoryType(factoryClass Class<? extends PooledObjectFactory>) : Class<?> from class org.apache.tomcat.dbcp.pool2.impl.PoolImplUtils | From | To | |
| Inline Variable | 1 | ||
| Inline Variable evicPolicy : EvictionPolicy<T> in method public setEvictionPolicyClassName(evictionPolicyClassName String) : void from class org.apache.tomcat.dbcp.pool2.impl.BaseGenericObjectPool | From | To | |
| Extract Method | 5 | ||
| Extract Method private whenWaitersAddObject(key K, idleObjects LinkedBlockingDeque<PooledObject<T>>) : void extracted from public returnObject(key K, obj T) : void in class org.apache.tomcat.dbcp.pool2.impl.GenericKeyedObjectPool | From | To | |
| Extract Method private getParameterizedType(type Class<T>, clazz Class<? extends T>) : ParameterizedType extracted from private getGenericType(type Class<T>, clazz Class<? extends T>) : Object in class org.apache.tomcat.dbcp.pool2.impl.PoolImplUtils | From | To | |
| Extract Method public setEvictionPolicyClassName(evictionPolicyClassName String, classLoader ClassLoader) : void extracted from public setEvictionPolicyClassName(evictionPolicyClassName String) : void in class org.apache.tomcat.dbcp.pool2.impl.BaseGenericObjectPool | From | To | |
| Extract Method private setEvictionPolicy(className String, classLoader ClassLoader) : void extracted from public setEvictionPolicyClassName(evictionPolicyClassName String) : void in class org.apache.tomcat.dbcp.pool2.impl.BaseGenericObjectPool | From | To | |
| Extract And Move Method | 2 | ||
| Extract And Move Method protected markReturningState(pooledObject PooledObject<T>) : void extracted from public returnObject(key K, obj T) : void in class org.apache.tomcat.dbcp.pool2.impl.GenericKeyedObjectPool & moved to class org.apache.tomcat.dbcp.pool2.impl.BaseGenericObjectPool | From | To | |
| Extract And Move Method protected markReturningState(pooledObject PooledObject<T>) : void extracted from public returnObject(obj T) : void in class org.apache.tomcat.dbcp.pool2.impl.GenericObjectPool & moved to class org.apache.tomcat.dbcp.pool2.impl.BaseGenericObjectPool | From | To | |
| Rename Parameter | 3 | ||
| Rename Parameter e : Exception to swallowException : Exception in method package swallowException(swallowException Exception) : void in class org.apache.tomcat.dbcp.pool2.impl.BaseGenericObjectPool | From | To | |
| Rename Parameter evictionPolicyClassName : String to className : String in method private setEvictionPolicy(className String, classLoader ClassLoader) : void in class org.apache.tomcat.dbcp.pool2.impl.BaseGenericObjectPool | From | To | |
| Rename Parameter factory : Class<? extends PooledObjectFactory> to factoryClass : Class<? extends PooledObjectFactory> in method package getFactoryType(factoryClass Class<? extends PooledObjectFactory>) : Class<?> in class org.apache.tomcat.dbcp.pool2.impl.PoolImplUtils | From | To |