0ff7dcf24618c8f956884f2bbdf9b067ed88c1cf
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 5
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Variable | 1 | ||
| Rename Variable retrieved : UserGoogleMfaCredentials to activeCreds : UserGoogleMfaCredentials in method private getMFACodeFromSession() : int in class org.cloudfoundry.identity.uaa.login.TotpEndpointMockMvcTests | From | To | |
| Change Return Type | 1 | ||
| Change Return Type String to ModelAndView in method public validateCode(model Model, session HttpSession, request HttpServletRequest, response HttpServletResponse, code String) : ModelAndView in class org.cloudfoundry.identity.uaa.login.TotpEndpoint | From | To | |
| Change Variable Type | 5 | ||
| Change Variable Type returnView : String to returnView : ModelAndView in method public testEmptyOTP() : void in class org.cloudfoundry.identity.uaa.login.TotpEndpointTest | From | To | |
| Change Variable Type returnView : String to returnView : ModelAndView in method public testValidateCodeThrowsException() : void in class org.cloudfoundry.identity.uaa.login.TotpEndpointTest | From | To | |
| Change Variable Type returnView : String to returnView : ModelAndView in method public testValidOTPTakesToHomePage() : void in class org.cloudfoundry.identity.uaa.login.TotpEndpointTest | From | To | |
| Change Variable Type returnView : String to returnView : ModelAndView in method public testNonNumericOTP() : void in class org.cloudfoundry.identity.uaa.login.TotpEndpointTest | From | To | |
| Change Variable Type returnView : String to returnView : ModelAndView in method public testInvalidOTPReturnsError() : void in class org.cloudfoundry.identity.uaa.login.TotpEndpointTest | From | To | |
| Inline Variable | 1 | ||
| Inline Variable secretKey : String in method public testGoogleAuthenticatorLoginFlow() : void from class org.cloudfoundry.identity.uaa.login.TotpEndpointMockMvcTests | From | To | |
| Extract Method | 8 | ||
| Extract Method private redirectToMFARegistration() : void extracted from public testQRCodeRedirectIfCodeValidated() : void in class org.cloudfoundry.identity.uaa.login.TotpEndpointMockMvcTests | From | To | |
| Extract Method private getMFACodeFromSession() : int extracted from public testRegisterFlowWithMfaProviderSwitch() : void in class org.cloudfoundry.identity.uaa.login.TotpEndpointMockMvcTests | From | To | |
| Extract Method private redirectToMFARegistration() : void extracted from public testQRCodeRedirectIfCodeNotValidated() : void in class org.cloudfoundry.identity.uaa.login.TotpEndpointMockMvcTests | From | To | |
| Extract Method private getMFACodeFromSession() : int extracted from public testGoogleAuthenticatorLoginFlow() : void in class org.cloudfoundry.identity.uaa.login.TotpEndpointMockMvcTests | From | To | |
| Extract Method private redirectToMFARegistration() : void extracted from public testRegisterFlowWithMfaProviderSwitch() : void in class org.cloudfoundry.identity.uaa.login.TotpEndpointMockMvcTests | From | To | |
| Extract Method private redirectToMFARegistration() : void extracted from public testGoogleAuthenticatorLoginFlow() : void in class org.cloudfoundry.identity.uaa.login.TotpEndpointMockMvcTests | From | To | |
| Extract Method private redirectToMFARegistration() : void extracted from public testRedirectToMfaAfterLogin() : void in class org.cloudfoundry.identity.uaa.login.TotpEndpointMockMvcTests | From | To | |
| Extract Method private getMFACodeFromSession() : int extracted from public testQRCodeRedirectIfCodeValidated() : void in class org.cloudfoundry.identity.uaa.login.TotpEndpointMockMvcTests | From | To |