131ff2f3f3db5e6e4729e26986b8fa03475ee92f
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 5
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Change Return Type | 1 | ||
| Change Return Type void to ScimUser in method private createZoneUser(idpZoneId String, zoneAdminToken String, zoneUserEmail String, zoneUrl String) : ScimUser in class org.cloudfoundry.identity.uaa.integration.feature.SamlLoginWithLocalIdpIT | From | To | |
| Parameterize Variable | 4 | ||
| Parameterize Variable zoneAdminToken : String to idpZoneAdminToken : String in method private getSamlServiceProvider(idpZoneId String, idpZoneAdminToken String, samlServiceProviderDefinition SamlServiceProviderDefinition, entityId String, local_saml_sp_for_testzone2 String, baseUrl String) : void in class org.cloudfoundry.identity.uaa.integration.feature.SamlLoginWithLocalIdpIT | From | To | |
| Parameterize Variable idpZoneId : String to zoneId : String in method private getZoneAdminToken(adminClient RestTemplate, identityClient RestTemplate, zoneId String) : String in class org.cloudfoundry.identity.uaa.integration.feature.SamlLoginWithLocalIdpIT | From | To | |
| Parameterize Variable zoneAdminToken : String to spZoneAdminToken : String in method private getSamlIdentityProvider(spZoneId String, spZoneAdminToken String, samlIdentityProviderDefinition SamlIdentityProviderDefinition) : IdentityProvider<SamlIdentityProviderDefinition> in class org.cloudfoundry.identity.uaa.integration.feature.SamlLoginWithLocalIdpIT | From | To | |
| Parameterize Variable zoneId : String to spZoneId : String in method private getSamlIdentityProvider(spZoneId String, spZoneAdminToken String, samlIdentityProviderDefinition SamlIdentityProviderDefinition) : IdentityProvider<SamlIdentityProviderDefinition> in class org.cloudfoundry.identity.uaa.integration.feature.SamlLoginWithLocalIdpIT | From | To | |
| Extract Method | 18 | ||
| Extract Method private getSamlServiceProvider(idpZoneId String, idpZoneAdminToken String, samlServiceProviderDefinition SamlServiceProviderDefinition, entityId String, local_saml_sp_for_testzone2 String, baseUrl String) : void extracted from public testLocalSamlIdpLoginInTestZone1Works() : void in class org.cloudfoundry.identity.uaa.integration.feature.SamlLoginWithLocalIdpIT | From | To | |
| Extract Method private getAdminClient() : RestTemplate extracted from public testCrossZoneSamlIntegration() : void in class org.cloudfoundry.identity.uaa.integration.feature.SamlLoginWithLocalIdpIT | From | To | |
| Extract Method private getZoneAdminToken(adminClient RestTemplate, identityClient RestTemplate, zoneId String) : String extracted from public testCrossZoneSamlIntegration() : void in class org.cloudfoundry.identity.uaa.integration.feature.SamlLoginWithLocalIdpIT | From | To | |
| Extract Method private getSamlIdentityProvider(spZoneId String, spZoneAdminToken String, samlIdentityProviderDefinition SamlIdentityProviderDefinition) : IdentityProvider<SamlIdentityProviderDefinition> extracted from public testWebSSOProfileWithRedirectPostSamlIntegration() : void in class org.cloudfoundry.identity.uaa.integration.feature.SamlLoginWithLocalIdpIT | From | To | |
| Extract Method private getIdentityClient() : RestTemplate extracted from public testWebSSOProfileWithArtifactInMetadataSamlIntegration() : void in class org.cloudfoundry.identity.uaa.integration.feature.SamlLoginWithLocalIdpIT | From | To | |
| Extract Method private getSamlServiceProvider(idpZoneId String, idpZoneAdminToken String, samlServiceProviderDefinition SamlServiceProviderDefinition, entityId String, local_saml_sp_for_testzone2 String, baseUrl String) : void extracted from public testCrossZoneSamlIntegration() : void in class org.cloudfoundry.identity.uaa.integration.feature.SamlLoginWithLocalIdpIT | From | To | |
| Extract Method private getSpZoneAdminUser(adminClient RestTemplate, spZoneAdminEmail String) : ScimUser extracted from public testWebSSOProfileWithRedirectPostSamlIntegration() : void in class org.cloudfoundry.identity.uaa.integration.feature.SamlLoginWithLocalIdpIT | From | To | |
| Extract Method private getAdminClient() : RestTemplate extracted from public testLocalSamlIdpLoginInTestZone1Works() : void in class org.cloudfoundry.identity.uaa.integration.feature.SamlLoginWithLocalIdpIT | From | To | |
| Extract Method private getSpZoneAdminUser(adminClient RestTemplate, spZoneAdminEmail String) : ScimUser extracted from public testWebSSOProfileWithArtifactInMetadataSamlIntegration() : void in class org.cloudfoundry.identity.uaa.integration.feature.SamlLoginWithLocalIdpIT | From | To | |
| Extract Method public createUserWithPhone(client RestTemplate, url String, username String, firstName String, lastName String, email String, verified boolean, phoneNumber String) : ScimUser extracted from public createUser(client RestTemplate, url String, username String, firstName String, lastName String, email String, verified boolean) : ScimUser in class org.cloudfoundry.identity.uaa.integration.util.IntegrationTestUtils | From | To | |
| Extract Method private getAdminClient() : RestTemplate extracted from public testWebSSOProfileWithArtifactInMetadataSamlIntegration() : void in class org.cloudfoundry.identity.uaa.integration.feature.SamlLoginWithLocalIdpIT | From | To | |
| Extract Method private getIdentityClient() : RestTemplate extracted from public testCrossZoneSamlIntegration() : void in class org.cloudfoundry.identity.uaa.integration.feature.SamlLoginWithLocalIdpIT | From | To | |
| Extract Method private getAdminClient() : RestTemplate extracted from public testWebSSOProfileWithRedirectPostSamlIntegration() : void in class org.cloudfoundry.identity.uaa.integration.feature.SamlLoginWithLocalIdpIT | From | To | |
| Extract Method private getSamlIdentityProvider(spZoneId String, spZoneAdminToken String, samlIdentityProviderDefinition SamlIdentityProviderDefinition) : IdentityProvider<SamlIdentityProviderDefinition> extracted from public testWebSSOProfileWithArtifactInMetadataSamlIntegration() : void in class org.cloudfoundry.identity.uaa.integration.feature.SamlLoginWithLocalIdpIT | From | To | |
| Extract Method private getSamlIdentityProvider(spZoneId String, spZoneAdminToken String, samlIdentityProviderDefinition SamlIdentityProviderDefinition) : IdentityProvider<SamlIdentityProviderDefinition> extracted from public testLocalSamlIdpLoginInTestZone1Works() : void in class org.cloudfoundry.identity.uaa.integration.feature.SamlLoginWithLocalIdpIT | From | To | |
| Extract Method private getIdentityClient() : RestTemplate extracted from public testLocalSamlIdpLoginInTestZone1Works() : void in class org.cloudfoundry.identity.uaa.integration.feature.SamlLoginWithLocalIdpIT | From | To | |
| Extract Method private getSamlIdentityProvider(spZoneId String, spZoneAdminToken String, samlIdentityProviderDefinition SamlIdentityProviderDefinition) : IdentityProvider<SamlIdentityProviderDefinition> extracted from public testCrossZoneSamlIntegration() : void in class org.cloudfoundry.identity.uaa.integration.feature.SamlLoginWithLocalIdpIT | From | To | |
| Extract Method private getIdentityClient() : RestTemplate extracted from public testWebSSOProfileWithRedirectPostSamlIntegration() : void in class org.cloudfoundry.identity.uaa.integration.feature.SamlLoginWithLocalIdpIT | From | To |