6a2158f689f960b9d9dc7519db3122d95dbe2900
Files Diff
- Added: 3
- Removed: 1
- Renamed: 0
- Modified: 8
Refactorings reported:
Refactoring Name | Occurences | ||
---|---|---|---|
Rename Method | 3 | ||
Rename Method public updatePasswordLastModified(id String, passwordLastModified long) : void renamed to public updatePasswordChangeRequired(userId String, passwordChangeRequired boolean) : void in class org.cloudfoundry.identity.uaa.scim.ScimUserProvisioning | From | To | |
Rename Method public updatePasswordLastModified(id String, passwordLastModified long) : void renamed to public updatePasswordChangeRequired(userId String, passwordChangeRequired boolean) : void in class org.cloudfoundry.identity.uaa.scim.remote.RemoteScimUserProvisioning | From | To | |
Rename Method public testForcePasswordExpireAccount() : void renamed to public testTryMultipleStatusUpdatesWithInvalidLock() : void in class org.cloudfoundry.identity.uaa.scim.endpoints.ScimUserEndpointsMockMvcTests | From | To | |
Inline Method | 1 | ||
Inline Method private validatePasswordExpiry(user ScimUser, status UserAccountStatus) : void inlined to public updateAccountStatus(status UserAccountStatus, userId String) : UserAccountStatus in class org.cloudfoundry.identity.uaa.scim.endpoints.ScimUserEndpoints | From | To | |
Parameterize Variable | 2 | ||
Parameterize Variable userToLockout : ScimUser to user : ScimUser in method private attemptLogin(user ScimUser) : ResultActions in class org.cloudfoundry.identity.uaa.scim.endpoints.ScimUserEndpointsMockMvcTests | From | To | |
Inline Variable | 2 | ||
Inline Variable jsonStatus : String in method public testUnlockAccount() : void from class org.cloudfoundry.identity.uaa.scim.endpoints.ScimUserEndpointsMockMvcTests | From | To | |
Inline Variable jsonStatus : String in method public testUnlockAccountWhenNotLocked() : void from class org.cloudfoundry.identity.uaa.scim.endpoints.ScimUserEndpointsMockMvcTests | From | To | |
Extract Method | 12 | ||
Extract Method private attemptLogin(user ScimUser) : ResultActions extracted from public testForcePasswordExpireAccount() : void in class org.cloudfoundry.identity.uaa.scim.endpoints.ScimUserEndpointsMockMvcTests | From | To | |
Extract Method private updateAccountStatus(user ScimUser, alteredAccountStatus UserAccountStatus) : ResultActions extracted from public testForcePasswordExpireAccount() : void in class org.cloudfoundry.identity.uaa.scim.endpoints.ScimUserEndpointsMockMvcTests | From | To | |
Extract Method private updateAccountStatus(user ScimUser, alteredAccountStatus UserAccountStatus) : ResultActions extracted from public testUnlockAccount() : void in class org.cloudfoundry.identity.uaa.scim.endpoints.ScimUserEndpointsMockMvcTests | From | To | |
Extract Method private attemptLogin(user ScimUser) : ResultActions extracted from public testUpdateStatusCannotLock() : void in class org.cloudfoundry.identity.uaa.scim.endpoints.ScimUserEndpointsMockMvcTests | From | To | |
Extract Method private attemptLogin(user ScimUser) : ResultActions extracted from public testUnlockAccountWhenNotLocked() : void in class org.cloudfoundry.identity.uaa.scim.endpoints.ScimUserEndpointsMockMvcTests | From | To | |
Extract Method private updateAccountStatus(user ScimUser, alteredAccountStatus UserAccountStatus) : ResultActions extracted from public testUpdateStatusCannotLock() : void in class org.cloudfoundry.identity.uaa.scim.endpoints.ScimUserEndpointsMockMvcTests | From | To | |
Extract Method private updateAccountStatus(user ScimUser, alteredAccountStatus UserAccountStatus) : ResultActions extracted from public testForcePasswordExpireAccountExternalUser() : void in class org.cloudfoundry.identity.uaa.scim.endpoints.ScimUserEndpointsMockMvcTests | From | To | |
Extract Method private updateAccountStatus(user ScimUser, alteredAccountStatus UserAccountStatus) : ResultActions extracted from public testUnlockAccountWhenNotLocked() : void in class org.cloudfoundry.identity.uaa.scim.endpoints.ScimUserEndpointsMockMvcTests | From | To | |
Extract Method private updateAccountStatus(user ScimUser, alteredAccountStatus UserAccountStatus) : ResultActions extracted from public testForcePasswordExpireAccountInvalid() : void in class org.cloudfoundry.identity.uaa.scim.endpoints.ScimUserEndpointsMockMvcTests | From | To | |
Extract Method private updateAccountStatus(user ScimUser, alteredAccountStatus UserAccountStatus) : ResultActions extracted from public testAccountStatusEmptyPatchDoesNotUnlock() : void in class org.cloudfoundry.identity.uaa.scim.endpoints.ScimUserEndpointsMockMvcTests | From | To | |
Extract Method private attemptLogin(user ScimUser) : ResultActions extracted from public testUnlockAccount() : void in class org.cloudfoundry.identity.uaa.scim.endpoints.ScimUserEndpointsMockMvcTests | From | To | |
Extract Method private attemptLogin(user ScimUser) : ResultActions extracted from public testAccountStatusEmptyPatchDoesNotUnlock() : void in class org.cloudfoundry.identity.uaa.scim.endpoints.ScimUserEndpointsMockMvcTests | From | To | |
Rename Parameter | 2 | ||
Rename Parameter id : String to userId : String in method public updatePasswordChangeRequired(userId String, passwordChangeRequired boolean) : void in class org.cloudfoundry.identity.uaa.scim.remote.RemoteScimUserProvisioning | From | To | |
Rename Parameter id : String to userId : String in method public updatePasswordChangeRequired(userId String, passwordChangeRequired boolean) : void in class org.cloudfoundry.identity.uaa.scim.ScimUserProvisioning | From | To |