uaa 6ac03f11d75db90d056953ed81565da96b7156b7

6ac03f11d75db90d056953ed81565da96b7156b7

Files Diff

Added: 3
Removed: 1
Renamed: 0
Modified: 12

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Push Down Method	5
Push Down Method public setSecurityContextAccessor(securityContextAccessor SecurityContextAccessor) : void from class org.cloudfoundry.identity.uaa.oauth.ClientDetailsValidator to public setSecurityContextAccessor(securityContextAccessor SecurityContextAccessor) : void from class org.cloudfoundry.identity.uaa.oauth.ClientAdminEndpointsValidator	From	To
Push Down Method public validate(prototype ClientDetails, create boolean) : ClientDetails from class org.cloudfoundry.identity.uaa.oauth.ClientDetailsValidator to public validate(prototype ClientDetails, create boolean) : ClientDetails from class org.cloudfoundry.identity.uaa.oauth.ClientAdminEndpointsValidator	From	To
Push Down Method public setClientDetailsService(clientDetailsService QueryableResourceManager<ClientDetails>) : void from class org.cloudfoundry.identity.uaa.oauth.ClientDetailsValidator to public setClientDetailsService(clientDetailsService QueryableResourceManager<ClientDetails>) : void from class org.cloudfoundry.identity.uaa.oauth.ClientAdminEndpointsValidator	From	To
Push Down Method public afterPropertiesSet() : void from class org.cloudfoundry.identity.uaa.oauth.ClientDetailsValidator to public afterPropertiesSet() : void from class org.cloudfoundry.identity.uaa.oauth.ClientAdminEndpointsValidator	From	To
Push Down Method public validate(prototype ClientDetails, create boolean, checkAdmin boolean) : ClientDetails from class org.cloudfoundry.identity.uaa.oauth.ClientDetailsValidator to public validate(prototype ClientDetails, create boolean, checkAdmin boolean) : ClientDetails from class org.cloudfoundry.identity.uaa.oauth.ClientAdminEndpointsValidator	From	To
Extract Subclass	1
Extract Subclass org.cloudfoundry.identity.uaa.oauth.ClientAdminEndpointsValidator from class org.cloudfoundry.identity.uaa.oauth.ClientDetailsValidator	From	To
Change Parameter Type	3
Change Parameter Type body : IdentityZoneCreationRequest to body : IdentityZone in method public updateIdentityZone(body IdentityZone, id String) : ResponseEntity<IdentityZone> in class org.cloudfoundry.identity.uaa.zone.IdentityZoneEndpoints	From	To
Change Parameter Type clientDetailsValidator : ClientDetailsValidator to clientDetailsValidator : ClientAdminEndpointsValidator in method public setClientDetailsValidator(clientDetailsValidator ClientAdminEndpointsValidator) : void in class org.cloudfoundry.identity.uaa.oauth.ClientAdminEndpoints	From	To
Change Parameter Type body : IdentityZoneCreationRequest to body : IdentityZone in method public createIdentityZone(body IdentityZone) : ResponseEntity<IdentityZone> in class org.cloudfoundry.identity.uaa.zone.IdentityZoneEndpoints	From	To
Rename Variable	1
Rename Variable tokenResponse : ResponseEntity<String> to clientCreateResponse : ResponseEntity<Void> in method public testCreateZoneWithClient() : void in class org.cloudfoundry.identity.uaa.integration.IdentityZoneEndpointsIntegrationTests	From	To
Push Down Attribute	7
Push Down Attribute private clientDetailsService : QueryableResourceManager<ClientDetails> from class org.cloudfoundry.identity.uaa.oauth.ClientDetailsValidator to private clientDetailsService : QueryableResourceManager<ClientDetails> from class org.cloudfoundry.identity.uaa.oauth.ClientAdminEndpointsValidator	From	To
Push Down Attribute private NON_ADMIN_INVALID_GRANTS : Collection<String> from class org.cloudfoundry.identity.uaa.oauth.ClientDetailsValidator to private NON_ADMIN_INVALID_GRANTS : Collection<String> from class org.cloudfoundry.identity.uaa.oauth.ClientAdminEndpointsValidator	From	To
Push Down Attribute private reservedClientIds : Set<String> from class org.cloudfoundry.identity.uaa.oauth.ClientDetailsValidator to private reservedClientIds : Set<String> from class org.cloudfoundry.identity.uaa.oauth.ClientAdminEndpointsValidator	From	To
Push Down Attribute private securityContextAccessor : SecurityContextAccessor from class org.cloudfoundry.identity.uaa.oauth.ClientDetailsValidator to private securityContextAccessor : SecurityContextAccessor from class org.cloudfoundry.identity.uaa.oauth.ClientAdminEndpointsValidator	From	To
Push Down Attribute private logger : Log from class org.cloudfoundry.identity.uaa.oauth.ClientDetailsValidator to private logger : Log from class org.cloudfoundry.identity.uaa.oauth.ClientAdminEndpointsValidator	From	To
Push Down Attribute private NON_ADMIN_VALID_AUTHORITIES : Collection<String> from class org.cloudfoundry.identity.uaa.oauth.ClientDetailsValidator to private NON_ADMIN_VALID_AUTHORITIES : Collection<String> from class org.cloudfoundry.identity.uaa.oauth.ClientAdminEndpointsValidator	From	To
Push Down Attribute private VALID_GRANTS : Set<String> from class org.cloudfoundry.identity.uaa.oauth.ClientDetailsValidator to private VALID_GRANTS : Set<String> from class org.cloudfoundry.identity.uaa.oauth.ClientAdminEndpointsValidator	From	To
Change Variable Type	2
Change Variable Type event : IdentityZoneModifiedEvent to event : T in method private checkAuditEventListener(eventCount int, eventType AuditEventType, eventListener TestApplicationEventListener<T>) : void in class org.cloudfoundry.identity.uaa.mock.zones.IdentityZoneEndpointsMockMvcTests	From	To
Change Variable Type tokenResponse : ResponseEntity<String> to clientCreateResponse : ResponseEntity<Void> in method public testCreateZoneWithClient() : void in class org.cloudfoundry.identity.uaa.integration.IdentityZoneEndpointsIntegrationTests	From	To
Extract Method	1
Extract Method private checkAuditEventListener(eventCount int, eventType AuditEventType, eventListener TestApplicationEventListener<T>) : void extracted from private checkAuditEventListener(eventCount int, eventType AuditEventType) : void in class org.cloudfoundry.identity.uaa.mock.zones.IdentityZoneEndpointsMockMvcTests	From	To
Change Attribute Type	1
Change Attribute Type clientDetailsValidator : ClientDetailsValidator to clientDetailsValidator : ClientAdminEndpointsValidator in class org.cloudfoundry.identity.uaa.oauth.ClientAdminEndpointsTests	From	To
Rename Parameter	1
Rename Parameter prototype : ClientDetails to clientDetails : ClientDetails in method public validate(clientDetails ClientDetails, create boolean) : ClientDetails in class org.cloudfoundry.identity.uaa.oauth.ClientDetailsValidator	From	To

6ac03f11d75db90d056953ed81565da96b7156b7

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: