6f64dbcea96096a5245ea88b7671313f8010ba40
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 18
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 2 | ||
| Rename Method public test_custom_user_attributes() : void renamed to public test_authentication_attributes() : void in class org.cloudfoundry.identity.uaa.authentication.manager.LdapLoginAuthenticationManagerTests | From | To | |
| Rename Method protected getUser(request Authentication) : UaaUser renamed to protected getExternalAuthenticationDetails(authentication Authentication) : AuthenticationData in class org.cloudfoundry.identity.uaa.provider.oauth.XOAuthAuthenticationManager | From | To | |
| Change Return Type | 1 | ||
| Change Return Type UaaUser to AuthenticationData in method protected getExternalAuthenticationDetails(authentication Authentication) : AuthenticationData in class org.cloudfoundry.identity.uaa.provider.oauth.XOAuthAuthenticationManager | From | To | |
| Parameterize Variable | 1 | ||
| Parameterize Variable success : UaaAuthentication to authentication : UaaAuthentication in method protected populateAuthenticationAttributes(authentication UaaAuthentication, request Authentication, authenticationData ExternalAuthenticationDetails) : void in class org.cloudfoundry.identity.uaa.authentication.manager.ExternalLoginAuthenticationManager | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute USER_NAME_ATTRIBUTE_PREFIX : String to USER_NAME_ATTRIBUTE_NAME : String in class org.cloudfoundry.identity.uaa.provider.ExternalIdentityProviderDefinition | From | To | |
| Change Variable Type | 1 | ||
| Change Variable Type success : Authentication to success : UaaAuthentication in method public authenticate(req Authentication) : Authentication in class org.cloudfoundry.identity.uaa.authentication.manager.AuthzAuthenticationManager | From | To | |
| Extract Method | 2 | ||
| Extract Method private addTheUserOnAuth() : void extracted from public exchangeExternalCodeForIdToken_andCreateShadowUser() : void in class org.cloudfoundry.identity.uaa.provider.oauth.XOAuthAuthenticationManagerTest | From | To | |
| Extract Method protected populateAuthenticationAttributes(authentication UaaAuthentication, request Authentication, authenticationData ExternalAuthenticationDetails) : void extracted from public authenticate(request Authentication) : Authentication in class org.cloudfoundry.identity.uaa.authentication.manager.ExternalLoginAuthenticationManager | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter request : Authentication to authentication : Authentication in method protected getExternalAuthenticationDetails(authentication Authentication) : AuthenticationData in class org.cloudfoundry.identity.uaa.provider.oauth.XOAuthAuthenticationManager | From | To |