750b0bb3c396e13bc76b14e6d8a01614e3b57610
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 18
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 1 | ||
| Rename Method package clientAdminEndpoints() : ClientAdminEndpoints renamed to package clientDetailsService() : ClientDetailsService in class org.cloudfoundry.identity.uaa.login.EmailInvitationsServiceTests.ContextConfiguration | From | To | |
| Move Method | 1 | ||
| Move Method public takeScreenShot() : void from class org.cloudfoundry.identity.uaa.integration.feature.SamlLoginIT to public takeScreenShot(webDriver WebDriver) : void from class org.cloudfoundry.identity.uaa.integration.util.IntegrationTestUtils | From | To | |
| Rename Variable | 2 | ||
| Rename Variable redirectLocation : String to invitation : InvitationsService.AcceptedInvitation in method public acceptInvitation(password String, passwordConfirmation String, clientId String, redirectUri String, model Model, request HttpServletRequest, response HttpServletResponse) : String in class org.cloudfoundry.identity.uaa.login.InvitationsController | From | To | |
| Rename Variable defaultMap : Map<String,Object> to definition : LdapIdentityProviderDefinition in method public testLdapProfileBootstrap() : void in class org.cloudfoundry.identity.uaa.config.IdentityProviderBootstrapTest | From | To | |
| Change Return Type | 3 | ||
| Change Return Type ClientAdminEndpoints to ClientDetailsService in method package clientDetailsService() : ClientDetailsService in class org.cloudfoundry.identity.uaa.login.EmailInvitationsServiceTests.ContextConfiguration | From | To | |
| Change Return Type String to AcceptedInvitation in method public acceptInvitation(userId String, email String, password String, clientId String, redirectUri String, origin String) : AcceptedInvitation in class org.cloudfoundry.identity.uaa.login.EmailInvitationsService | From | To | |
| Change Return Type String to AcceptedInvitation in method public acceptInvitation(userId String, email String, password String, clientId String, redirectUri String, origin String) : AcceptedInvitation in class org.cloudfoundry.identity.uaa.login.InvitationsService | From | To | |
| Replace Variable With Attribute | 1 | ||
| Replace Variable With Attribute token : String to loginToken : String in method private generateCode(username String, userEmail String, redirectUri String) : String in class org.cloudfoundry.identity.uaa.integration.feature.InvitationsIT | From | To | |
| Extract Variable | 2 | ||
| Extract Variable definition : LdapIdentityProviderDefinition in method public getLdapAuthenticationManager(zone IdentityZone, provider IdentityProvider) : DynamicLdapAuthenticationManager from class org.cloudfoundry.identity.uaa.authentication.manager.DynamicZoneAwareAuthenticationManager | From | To | |
| Extract Variable redirectUris : Set<String> in method public acceptInvitation(userId String, email String, password String, clientId String, redirectUri String, origin String) : AcceptedInvitation from class org.cloudfoundry.identity.uaa.login.EmailInvitationsService | From | To | |
| Change Variable Type | 2 | ||
| Change Variable Type defaultMap : Map<String,Object> to definition : LdapIdentityProviderDefinition in method public testLdapProfileBootstrap() : void in class org.cloudfoundry.identity.uaa.config.IdentityProviderBootstrapTest | From | To | |
| Change Variable Type redirectLocation : String to invitation : InvitationsService.AcceptedInvitation in method public acceptInvitation(password String, passwordConfirmation String, clientId String, redirectUri String, model Model, request HttpServletRequest, response HttpServletResponse) : String in class org.cloudfoundry.identity.uaa.login.InvitationsController | From | To | |
| Extract Method | 1 | ||
| Extract Method public performInviteUser(email String) : void extracted from public testInviteUser() : void in class org.cloudfoundry.identity.uaa.integration.feature.InvitationsIT | From | To | |
| Rename Parameter | 2 | ||
| Rename Parameter userEmail : String to username : String in method private generateCode(username String, userEmail String, redirectUri String) : String in class org.cloudfoundry.identity.uaa.integration.feature.InvitationsIT | From | To | |
| Rename Parameter zoneAdminToken : String to token : String in method public getUserId(token String, url String, origin String, username String) : String in class org.cloudfoundry.identity.uaa.integration.util.IntegrationTestUtils | From | To |