7bc0566af6c2b4c860d025c66847ab9cd0514230
Files Diff
- Added: 2
- Removed: 0
- Renamed: 0
- Modified: 19
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 2 | ||
| Rename Method public testDuplicateAlias() : void renamed to public testDuplicateAlias_In_LegacyConfig() : void in class org.cloudfoundry.identity.uaa.login.saml.IdentityProviderConfiguratorTests | From | To | |
| Rename Method public testGetIdentityProvidersWithLegacyProvider() : void renamed to public testGetIdentityProvidersWithLegacy_Invalid_Provider() : void in class org.cloudfoundry.identity.uaa.login.saml.IdentityProviderConfiguratorTests | From | To | |
| Move And Rename Method | 2 | ||
| Move And Rename Method public hashCode() : int from class org.cloudfoundry.identity.uaa.login.saml.FixedHttpMetaDataProvider to public getHashCode() : int from class org.cloudfoundry.identity.uaa.login.saml.ComparableProvider | From | To | |
| Move And Rename Method public hashCode() : int from class org.cloudfoundry.identity.uaa.login.saml.FilesystemMetadataProvider to public getHashCode() : int from class org.cloudfoundry.identity.uaa.login.saml.ComparableProvider | From | To | |
| Change Parameter Type | 1 | ||
| Change Parameter Type providerDefinitionList : List<IdentityProviderDefinition> to providerDefinitionList : IdentityProviderConfigurator in method public setProviderDefinitionList(providerDefinitionList IdentityProviderConfigurator) : void in class org.cloudfoundry.identity.uaa.login.saml.LoginSamlEntryPoint | From | To | |
| Rename Variable | 2 | ||
| Rename Variable delegate : ExtendedMetadataDelegate to metadata : byte[] in method protected configureURLMetadata(def IdentityProviderDefinition) : ExtendedMetadataDelegate in class org.cloudfoundry.identity.uaa.login.saml.IdentityProviderConfigurator | From | To | |
| Rename Variable delegate : ExtendedMetadataDelegate to metadata : byte[] in method protected configureFileMetadata(def IdentityProviderDefinition) : ExtendedMetadataDelegate in class org.cloudfoundry.identity.uaa.login.saml.IdentityProviderConfigurator | From | To | |
| Change Return Type | 4 | ||
| Change Return Type void to ExtendedMetadataDelegate in method public removeIdentityProviderDefinition(providerDefinition IdentityProviderDefinition) : ExtendedMetadataDelegate in class org.cloudfoundry.identity.uaa.login.saml.IdentityProviderConfigurator | From | To | |
| Change Return Type List<IdentityProviderDefinition> to void in method protected parseIdentityProviderDefinitions() : void in class org.cloudfoundry.identity.uaa.login.saml.IdentityProviderConfigurator | From | To | |
| Change Return Type ExtendedMetadataDelegate to ExtendedMetadataDelegate[] in method public addIdentityProviderDefinition(providerDefinition IdentityProviderDefinition) : ExtendedMetadataDelegate[] in class org.cloudfoundry.identity.uaa.login.saml.IdentityProviderConfigurator | From | To | |
| Change Return Type void to Set<ComparableProvider> in method protected refreshZoneManager(manager ExtensionMetadataManager) : Set<ComparableProvider> in class org.cloudfoundry.identity.uaa.login.saml.ZoneAwareMetadataManager | From | To | |
| Move Attribute | 1 | ||
| Move Attribute public IDP_META_DATA : String from class org.cloudfoundry.identity.uaa.login.saml.SamlIDPRefreshMockMvcTests to public IDP_META_DATA : String from class org.cloudfoundry.identity.uaa.mock.util.MockMvcUtils | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute IDP_META_DATA : String to DEFAULT_SIMPLE_SAML_METADATA : String in class org.cloudfoundry.identity.uaa.login.saml.SamlIDPRefreshMockMvcTests | From | To | |
| Change Variable Type | 2 | ||
| Change Variable Type delegate : ExtendedMetadataDelegate to metadata : byte[] in method protected configureURLMetadata(def IdentityProviderDefinition) : ExtendedMetadataDelegate in class org.cloudfoundry.identity.uaa.login.saml.IdentityProviderConfigurator | From | To | |
| Change Variable Type delegate : ExtendedMetadataDelegate to metadata : byte[] in method protected configureFileMetadata(def IdentityProviderDefinition) : ExtendedMetadataDelegate in class org.cloudfoundry.identity.uaa.login.saml.IdentityProviderConfigurator | From | To | |
| Extract Method | 1 | ||
| Extract Method public getProviderDefinitionList() : IdentityProviderConfigurator extracted from private getIDPDefinition(alias String) : IdentityProviderDefinition in class org.cloudfoundry.identity.uaa.login.saml.LoginSamlEntryPoint | From | To | |
| Change Attribute Type | 2 | ||
| Change Attribute Type providerDefinitionList : List<IdentityProviderDefinition> to providerDefinitionList : IdentityProviderConfigurator in class org.cloudfoundry.identity.uaa.login.saml.LoginSamlEntryPoint | From | To | |
| Change Attribute Type identityProviders : List<IdentityProviderDefinition> to identityProviders : Map<IdentityProviderDefinition,ExtendedMetadataDelegate> in class org.cloudfoundry.identity.uaa.login.saml.IdentityProviderConfigurator | From | To |